Code Review for hs-gc-numa-bug

Prepared by:brutisso on Fri Mar 23 13:21:24 WEST 2012
Workspace:/cygdrive/d/repos/hs-gc-numa-bug
Compare against: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot
Compare against version:3215
Summary of changes: 44 lines changed: 16 ins; 9 del; 19 mod; 2193 unchg
Patch of changes: hs-gc-numa-bug.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp

rev 3216 : 7103665: HeapWord*ParallelScavengeHeap::failed_mem_allocate(unsigned long,bool)+0x97
Summary: Make sure that MutableNUMASpace::ensure_parsability() only calls CollectedHeap::fill_with_object() with valid sizes and make sure CollectedHeap::filler_array_max_size() returns a value that can be converted to an int without overflow
Reviewed-by: duke
32 lines changed: 11 ins; 3 del; 18 mod; 944 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_interface/collectedHeap.cpp

rev 3216 : 7103665: HeapWord*ParallelScavengeHeap::failed_mem_allocate(unsigned long,bool)+0x97
Summary: Make sure that MutableNUMASpace::ensure_parsability() only calls CollectedHeap::fill_with_object() with valid sizes and make sure CollectedHeap::filler_array_max_size() returns a value that can be converted to an int without overflow
Reviewed-by: duke
6 lines changed: 1 ins; 4 del; 1 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_interface/collectedHeap.hpp

rev 3216 : 7103665: HeapWord*ParallelScavengeHeap::failed_mem_allocate(unsigned long,bool)+0x97
Summary: Make sure that MutableNUMASpace::ensure_parsability() only calls CollectedHeap::fill_with_object() with valid sizes and make sure CollectedHeap::filler_array_max_size() returns a value that can be converted to an int without overflow
Reviewed-by: duke
6 lines changed: 4 ins; 2 del; 0 mod; 723 unchg

This code review page was prepared using /cygdrive/k/bin/webrev.sh (vers 23.18-hg).