Code Review for jdk

Prepared by:igerasim on Mon Oct 6 14:13:42 MSK 2014
Workspace:/home/igerasim/JDK/jdk9/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:10763
Summary of changes: 233 lines changed: 132 ins; 66 del; 35 mod; 5170 unchg
Changeset: jdk.changeset
Bug id: JDK-8023173 : FileOutputStream(FileDescriptor) does not respect append flag on Windows
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/mapfiles/libjava/mapfile-vers 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
1 line changed: 1 ins; 0 del; 0 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/FileOutputStream.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
25 lines changed: 0 ins; 20 del; 5 mod; 410 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/misc/JavaIOFileDescriptorAccess.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
2 lines changed: 2 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
24 lines changed: 8 ins; 11 del; 5 mod; 1178 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/native/libjava/RandomAccessFile.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
2 lines changed: 0 ins; 0 del; 2 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/native/libjava/io_util.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
12 lines changed: 0 ins; 8 del; 4 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/native/libjava/io_util.h 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
3 lines changed: 1 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/java/io/FileDescriptor.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
13 lines changed: 13 ins; 0 del; 0 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/sun/nio/ch/FileDispatcherImpl.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
4 lines changed: 0 ins; 4 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/sun/nio/fs/UnixChannelFactory.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
1 line changed: 0 ins; 0 del; 1 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/native/libjava/FileDescriptor_md.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
10 lines changed: 10 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/native/libjava/FileOutputStream_md.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
4 lines changed: 0 ins; 0 del; 4 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/native/libjava/io_util_md.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
3 lines changed: 2 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/native/libjava/io_util_md.h 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
3 lines changed: 1 ins; 1 del; 1 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/classes/java/io/FileDescriptor.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
14 lines changed: 14 ins; 0 del; 0 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/classes/sun/nio/ch/FileDispatcherImpl.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
18 lines changed: 3 ins; 13 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/classes/sun/nio/fs/WindowsChannelFactory.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
2 lines changed: 1 ins; 0 del; 1 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/native/libjava/FileDescriptor_md.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
4 lines changed: 4 ins; 0 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/native/libjava/FileOutputStream_md.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
4 lines changed: 0 ins; 0 del; 4 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/native/libjava/io_util_md.c 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
27 lines changed: 18 ins; 8 del; 1 mod; 643 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/native/libjava/io_util_md.h 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
3 lines changed: 0 ins; 1 del; 2 mod; 104 unchg

------ ------ ------ ------ --- New ----- Raw test/java/io/FileDescriptor/RememberAppend.java 

rev 10764 : 8023173: FileDescriptor should remember its append mode [win]
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/igerasim/bin/webrev (vers 25.2-hg+openjdk.java.net).