Code Review for open

Prepared by:iignatyev on Wed Sep 26 16:33:19 PDT 2018
Workspace:/Users/iignatye/ws/jdk/jdk/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:8211171
Summary of changes: 476 lines changed: 239 ins; 203 del; 34 mod; 8328 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogFileInputTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 3 ins; 0 del; 0 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/FilePermission/ReadFileOnPath.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 2 ins; 0 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/Serializable/packageAccess/PackageAccessTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/Serializable/resolveClass/consTest/ConsTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/Serializable/resolveClass/consTest/SetupJar.java

rev 51882 : [mq]: 8211171-1
2 lines changed: 2 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/Serializable/resolveClass/deserializeButton/DeserializeButtonTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/Serializable/superclassDataLoss/SuperclassDataLossTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
4 lines changed: 3 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/ClassLoader/getResource/automaticmodules/Driver.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/ClassLoader/securityManager/ClassLoaderTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 1 ins; 0 del; 1 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Package/IsCompatibleWithDriver.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 1 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Package/PackageFromManifest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
1 line changed: 1 ins; 0 del; 0 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/instrument/executableJAR/ExecJarWithAgent.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/module/AutomaticModulesTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
4 lines changed: 3 ins; 0 del; 1 mod; 1117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/module/ModuleReader/ModuleReaderTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
4 lines changed: 3 ins; 0 del; 1 mod; 425 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/module/MultiReleaseJarTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 1 ins; 0 del; 1 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/module/customfs/ModulesInCustomFileSystem.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
4 lines changed: 3 ins; 0 del; 1 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/URLClassLoader/closetest/CloseTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/URLClassLoader/closetest/GetResourceAsStream.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 1 del; 0 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/AsynchronousChannelGroup/AsExecutor.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 1 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/AsynchronousChannelGroup/SetupJar.java

rev 51882 : [mq]: 8211171-1
2 lines changed: 2 ins; 0 del; 0 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/charset/spi/CharsetProviderBasicTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
1 line changed: 0 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/charset/spi/SetupJar.java

rev 51882 : [mq]: 8211171-1
2 lines changed: 2 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/rmi/module/ModuleTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
4 lines changed: 3 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/security/Provider/SecurityProviderModularTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 1 ins; 0 del; 1 mod; 384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/ServiceLoader/ModulesTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/ServiceLoader/basic/ServiceLoaderBasicTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/javax/security/auth/login/modules/JaasModularClientTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 0 ins; 0 del; 2 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/javax/security/auth/login/modules/JaasModularDefaultHandlerTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 1 ins; 0 del; 1 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
4 lines changed: 3 ins; 0 del; 1 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/net/www/protocol/jar/jarbug/TestDriver.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jlink/basic/BasicTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/launcher/modules/addreads/AddReadsTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 474 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/launcher/modules/patch/basic/PatchTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/launcher/modules/patch/basic/PatchTestWarningError.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
3 lines changed: 2 ins; 0 del; 1 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/launcher/modules/validate/ValidateModulesTest.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
2 lines changed: 1 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/util/JarUtils.java

rev 51882 : [mq]: 8211171-1
167 lines changed: 166 ins; 0 del; 1 mod; 174 unchg

------ ------ ------ ------ Old --- Patch --- test/lib/JarUtils.java

rev 51881 : [mq]: 8211171
rev 51882 : [mq]: 8211171-1
202 lines changed: 0 ins; 202 del; 0 mod; 0 unchg

This code review page was prepared using /Users/iignatye/ws/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).