Code Review for jaxp

Prepared by:joehw on Wed Jun 14 09:49:50 PDT 2017
Workspace:/scratch/w/huizwang/openjdk/jdk10/jaxp
Compare against: http://hg.openjdk.java.net/jdk10/jdk10/jaxp
Summary of changes: 2801 lines changed: 285 ins; 2311 del; 205 mod; 39814 unchg
Patch of changes: jaxp.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ReferenceType.java

3 lines changed: 1 ins; 1 del; 1 mod; 314 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltSets.java

6 lines changed: 0 ins; 0 del; 6 mod; 235 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources.java

25 lines changed: 0 ins; 24 del; 1 mod; 1424 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java

26 lines changed: 0 ins; 24 del; 2 mod; 1423 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java

26 lines changed: 0 ins; 25 del; 1 mod; 1423 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java

27 lines changed: 0 ins; 25 del; 2 mod; 1422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java

27 lines changed: 0 ins; 25 del; 2 mod; 1422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java

27 lines changed: 0 ins; 25 del; 2 mod; 1422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java

32 lines changed: 0 ins; 25 del; 7 mod; 1417 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java

27 lines changed: 0 ins; 25 del; 2 mod; 1422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java

27 lines changed: 0 ins; 24 del; 3 mod; 1422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java

27 lines changed: 0 ins; 25 del; 2 mod; 1422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java

27 lines changed: 0 ins; 25 del; 2 mod; 1422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ForwardPositionIterator.java

3 lines changed: 1 ins; 1 del; 1 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/KeyIndex.java

14 lines changed: 13 ins; 0 del; 1 mod; 899 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecord.java

5 lines changed: 3 ins; 1 del; 1 mod; 248 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecordFactory.java

3 lines changed: 1 ins; 1 del; 1 mod; 162 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java

2 lines changed: 1 ins; 0 del; 1 mod; 1690 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/AttrImpl.java

3 lines changed: 1 ins; 1 del; 1 mod; 1237 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDocumentImpl.java

7 lines changed: 6 ins; 0 del; 1 mod; 2831 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentImpl.java

4 lines changed: 3 ins; 0 del; 1 mod; 2156 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/NodeImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 2022 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xs/ItemPSVI.java

6 lines changed: 4 ins; 1 del; 1 mod; 224 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeDeclaration.java

6 lines changed: 4 ins; 1 del; 1 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeUse.java

6 lines changed: 4 ins; 1 del; 1 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xs/XSElementDeclaration.java

6 lines changed: 4 ins; 1 del; 1 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/CoroutineParser.java

3 lines changed: 1 ins; 1 del; 1 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java

2 lines changed: 1 ins; 0 del; 1 mod; 1946 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/DOMSerializer.java

3 lines changed: 1 ins; 1 del; 1 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/DOMSerializerImpl.java

3 lines changed: 1 ins; 1 del; 1 mod; 1070 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/ElementState.java

2 lines changed: 1 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/EncodingInfo.java

3 lines changed: 1 ins; 1 del; 1 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/Encodings.java

2 lines changed: 1 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLSerializer.java

2 lines changed: 1 ins; 0 del; 1 mod; 876 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLdtd.java

2 lines changed: 1 ins; 0 del; 1 mod; 559 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/IndentPrinter.java

3 lines changed: 1 ins; 1 del; 1 mod; 369 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/LineSeparator.java

3 lines changed: 1 ins; 1 del; 1 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/Method.java

3 lines changed: 1 ins; 1 del; 1 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/OutputFormat.java

3 lines changed: 1 ins; 1 del; 1 mod; 821 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/Printer.java

3 lines changed: 1 ins; 1 del; 1 mod; 368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/Serializer.java

3 lines changed: 1 ins; 1 del; 1 mod; 127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/SerializerFactory.java

2 lines changed: 1 ins; 0 del; 1 mod; 154 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/SerializerFactoryImpl.java

3 lines changed: 1 ins; 1 del; 1 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/TextSerializer.java

3 lines changed: 1 ins; 1 del; 1 mod; 394 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/XHTMLSerializer.java

3 lines changed: 1 ins; 1 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/XML11Serializer.java

3 lines changed: 1 ins; 1 del; 1 mod; 548 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/XMLSerializer.java

3 lines changed: 1 ins; 1 del; 1 mod; 1468 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/TreeWalker.java

27 lines changed: 1 ins; 12 del; 14 mod; 482 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/AttList.java

25 lines changed: 0 ins; 20 del; 5 mod; 230 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/DOM2Helper.java

487 lines changed: 209 ins; 181 del; 97 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/TreeWalker.java

53 lines changed: 4 ins; 30 del; 19 mod; 439 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/operations/Quo.java

3 lines changed: 1 ins; 1 del; 1 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/org/xml/sax/HandlerBase.java

2 lines changed: 1 ins; 0 del; 1 mod; 392 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/org/xml/sax/helpers/AttributeListImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 335 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/AttList.java

264 lines changed: 0 ins; 264 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/DOM2Helper.java

135 lines changed: 0 ins; 135 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/DOMHelper.java

1330 lines changed: 0 ins; 1330 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/DOMOrder.java

42 lines changed: 0 ins; 42 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/w/huizwang/openjdk/jdk10/make/scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).