Code Review for jaxp

Prepared by:joehw on Sun Jul 24 18:45:43 PDT 2016
Workspace:/scratch/w/huizwang/openjdk/9-dev/jaxp
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jaxp
Summary of changes: 5736 lines changed: 5064 ins; 305 del; 367 mod; 38688 unchg
Patch of changes: jaxp.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/XalanConstants.java

7 lines changed: 0 ins; 6 del; 1 mod; 232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java

4 lines changed: 1 ins; 1 del; 2 mod; 1145 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java

44 lines changed: 28 ins; 1 del; 15 mod; 1437 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java

40 lines changed: 17 ins; 5 del; 18 mod; 1014 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java

46 lines changed: 21 ins; 13 del; 12 mod; 327 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java

180 lines changed: 92 ins; 26 del; 62 mod; 1534 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java

65 lines changed: 54 ins; 0 del; 11 mod; 1401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java

55 lines changed: 32 ins; 15 del; 8 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java

20 lines changed: 13 ins; 0 del; 7 mod; 1092 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/PropertyManager.java

27 lines changed: 10 ins; 0 del; 17 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java

17 lines changed: 13 ins; 0 del; 4 mod; 3295 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java

119 lines changed: 110 ins; 1 del; 8 mod; 3072 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java

12 lines changed: 6 ins; 0 del; 6 mod; 1427 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java

16 lines changed: 11 ins; 0 del; 5 mod; 4599 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaParsingConfig.java

20 lines changed: 10 ins; 2 del; 8 mod; 1020 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java

32 lines changed: 30 ins; 0 del; 2 mod; 4334 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java

15 lines changed: 8 ins; 1 del; 6 mod; 190 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java

14 lines changed: 6 ins; 1 del; 7 mod; 1078 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorImpl.java

25 lines changed: 13 ins; 3 del; 9 mod; 268 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java

37 lines changed: 23 ins; 14 del; 0 mod; 595 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java

23 lines changed: 8 ins; 5 del; 10 mod; 596 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java

24 lines changed: 15 ins; 2 del; 7 mod; 873 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java

27 lines changed: 15 ins; 1 del; 11 mod; 793 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java

31 lines changed: 18 ins; 11 del; 2 mod; 1579 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/ParserConfigurationSettings.java

27 lines changed: 11 ins; 5 del; 11 mod; 315 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java

96 lines changed: 11 ins; 30 del; 55 mod; 229 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java

77 lines changed: 61 ins; 1 del; 15 mod; 3063 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLInputSource.java

19 lines changed: 18 ins; 1 del; 0 mod; 273 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java

51 lines changed: 32 ins; 5 del; 14 mod; 238 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPExtensionsProvider.java

35 lines changed: 11 ins; 17 del; 7 mod; 190 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathExpressionImpl.java

5 lines changed: 1 ins; 1 del; 3 mod; 165 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathFactoryImpl.java

18 lines changed: 2 ins; 7 del; 9 mod; 311 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathImpl.java

15 lines changed: 5 ins; 5 del; 5 mod; 229 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathImplUtil.java

4 lines changed: 1 ins; 1 del; 2 mod; 259 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/XMLConstants.java

39 lines changed: 38 ins; 0 del; 1 mod; 383 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java

162 lines changed: 155 ins; 0 del; 7 mod; 542 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/jdk/xml/internal/SecuritySupport.java

16 lines changed: 16 ins; 0 del; 0 mod; 153 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.xml/share/classes/jdk/xml/internal/JdkXmlFeatures.java

348 lines changed: 348 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/java.xml/share/classes/jdk/xml/internal/JdkXmlUtils.java

166 lines changed: 166 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport.java

325 lines changed: 325 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport.xml

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport1.java

263 lines changed: 263 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport2.java

262 lines changed: 262 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport3.java

273 lines changed: 273 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport4.java

260 lines changed: 260 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupportBase.java

934 lines changed: 934 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport_bogus.xml

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/DocFunc.xml

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/DocFunc.xsl

12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/DocFunc2.xml

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/DocFuncCatalog.xml

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XI_red.dtd

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XI_simple.xml

18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XI_simple4Catalog.xml

18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XI_test2.xml

10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XI_utf8.xml

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XI_utf8Catalog.xml

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XMLSchema.dtd

402 lines changed: 402 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XMLSchema.xsd

92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSDInclude_company.xsd

18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSDInclude_person.xsd

12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSDInclude_product.xsd

11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSLDTD.dtd

108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSLDTD.xml

7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSLImport_html.xsl

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSLInclude_footer.xsl

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/XSLInclude_header.xsl

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/datatypes.dtd

203 lines changed: 203 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/include.dtd

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/val_test.xml

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/val_test.xsd

16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/xml.xsd

287 lines changed: 287 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/FeatureManager.java

124 lines changed: 0 ins; 124 del; 0 mod; 0 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 25.1-hg+openjdk.java.net).