Code Review for jdk

Prepared by:Alexey Bakhtin on Wed May 27 12:21:15 MSK 2020
Workspace:/Users/alexey/Work/openjdk/jdk8u/jdk
Compare against: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk
Compare against version:13969
Summary of changes: 3996 lines changed: 3 ins; 3783 del; 210 mod; 19908 unchg
Patch of changes: jdk.patch
Bug id: JDK-8245469
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/Alert.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
3 lines changed: 0 ins; 0 del; 3 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/Authenticator.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
195 lines changed: 0 ins; 183 del; 12 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/CipherSuite.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
10 lines changed: 0 ins; 3 del; 7 mod; 1137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/CipherType.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/ClientHello.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
376 lines changed: 0 ins; 346 del; 30 mod; 1066 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/ConnectionContext.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/ContentType.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/Finished.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
25 lines changed: 0 ins; 19 del; 6 mod; 1144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/HandshakeHash.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
2 lines changed: 0 ins; 1 del; 1 mod; 633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/HelloCookieManager.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
137 lines changed: 2 ins; 127 del; 8 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/InputRecord.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
23 lines changed: 0 ins; 21 del; 2 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/MaxFragExtension.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
14 lines changed: 0 ins; 8 del; 6 mod; 603 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/OutputRecord.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
77 lines changed: 0 ins; 69 del; 8 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/ProtocolVersion.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
75 lines changed: 1 ins; 18 del; 56 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/RSAClientKeyExchange.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
2 lines changed: 0 ins; 0 del; 2 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/Record.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
1 line changed: 0 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLCipher.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
23 lines changed: 0 ins; 23 del; 0 mod; 2363 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLConfiguration.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
9 lines changed: 0 ins; 7 del; 2 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLContextImpl.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
255 lines changed: 0 ins; 252 del; 3 mod; 1617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLEngineImpl.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
106 lines changed: 0 ins; 93 del; 13 mod; 962 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLEngineInputRecord.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
2 lines changed: 0 ins; 0 del; 2 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLExtensions.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
1 line changed: 0 ins; 0 del; 1 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLHandshake.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
19 lines changed: 0 ins; 15 del; 4 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLKeyExchange.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
3 lines changed: 0 ins; 0 del; 3 mod; 593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLMasterKeyDerivation.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
24 lines changed: 0 ins; 19 del; 5 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLSessionImpl.java 

rev 13968 : 8245467: Remove 8u TLSv1.2 implementation files
rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
17 lines changed: 0 ins; 10 del; 7 mod; 1074 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLSocketInputRecord.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
2 lines changed: 0 ins; 0 del; 2 mod; 464 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
25 lines changed: 0 ins; 19 del; 6 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLTransport.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
22 lines changed: 0 ins; 15 del; 7 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/ServerHello.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
35 lines changed: 0 ins; 28 del; 7 mod; 1441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/StatusResponseManager.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
1 line changed: 0 ins; 0 del; 1 mod; 962 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/TransportContext.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
11 lines changed: 0 ins; 9 del; 2 mod; 662 unchg

------ ------ ------ ------ Old --- Patch --- src/share/classes/sun/security/ssl/DTLSInputRecord.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
1575 lines changed: 0 ins; 1575 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/share/classes/sun/security/ssl/DTLSOutputRecord.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
629 lines changed: 0 ins; 629 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/share/classes/sun/security/ssl/DTLSRecord.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
77 lines changed: 0 ins; 77 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/share/classes/sun/security/ssl/HelloVerifyRequest.java 

rev 13969 : 8245468: Add TLSv1.3 implementation classes from 11.0.7
rev 13970 : 8245469: Remove DTLS protocol implementation
217 lines changed: 0 ins; 217 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.18-hg+openjdk.java.net).