Code Review for jdk.pmem

Prepared by:adinn on Tue Aug 6 12:47:57 BST 2019
Workspace:/home/adinn/redhat/openjdk/jdkdev/jdk.pmem
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version:55910
Summary of changes: 1408 lines changed: 1339 ins; 12 del; 57 mod; 150763 unchg
Changeset: jdk.pmem.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/Modules.gmk

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
2 lines changed: 1 ins; 0 del; 1 mod; 471 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/aarch64.ad

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
52 lines changed: 45 ins; 0 del; 7 mod; 17850 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/assembler_aarch64.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
3 lines changed: 1 ins; 0 del; 2 mod; 2704 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/globals_aarch64.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
1 line changed: 0 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
22 lines changed: 22 ins; 0 del; 0 mod; 5835 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 3 ins; 0 del; 1 mod; 1377 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
42 lines changed: 42 ins; 0 del; 0 mod; 5789 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
19 lines changed: 16 ins; 0 del; 3 mod; 454 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/vm_version_aarch64.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
3 lines changed: 1 ins; 0 del; 2 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/assembler_x86.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
41 lines changed: 41 ins; 0 del; 0 mod; 9380 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/assembler_x86.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 3 ins; 0 del; 1 mod; 2344 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
42 lines changed: 41 ins; 0 del; 1 mod; 9979 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 4 ins; 0 del; 0 mod; 1813 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
43 lines changed: 43 ins; 0 del; 0 mod; 6096 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/vm_version_x86.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
11 lines changed: 11 ins; 0 del; 0 mod; 1725 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/vm_version_x86.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
61 lines changed: 59 ins; 0 del; 2 mod; 948 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/x86.ad

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
7 lines changed: 7 ins; 0 del; 0 mod; 9844 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/x86_64.ad

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
41 lines changed: 41 ins; 0 del; 0 mod; 13101 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/aix/os_aix.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 4 ins; 0 del; 0 mod; 4340 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/bsd/os_bsd.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
5 lines changed: 5 ins; 0 del; 0 mod; 3836 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/linux/os_linux.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 4 ins; 0 del; 0 mod; 6355 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/solaris/os_solaris.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 4 ins; 0 del; 0 mod; 5405 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/windows/os_windows.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 4 ins; 0 del; 0 mod; 5805 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/adlc/formssel.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
6 lines changed: 6 ins; 0 del; 0 mod; 4310 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
5 lines changed: 5 ins; 0 del; 0 mod; 4654 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/vmSymbols.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
8 lines changed: 8 ins; 0 del; 0 mod; 1672 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/c2compiler.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
9 lines changed: 9 ins; 0 del; 0 mod; 640 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/classes.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 3 ins; 0 del; 1 mod; 416 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/library_call.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
54 lines changed: 54 ins; 0 del; 0 mod; 6800 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/memnode.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
36 lines changed: 36 ins; 0 del; 0 mod; 1657 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/unsafe.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
44 lines changed: 44 ins; 0 del; 0 mod; 1112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/globals.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
3 lines changed: 3 ins; 0 del; 0 mod; 2500 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/os.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 4 ins; 0 del; 0 mod; 1005 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/stubRoutines.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
3 lines changed: 3 ins; 0 del; 0 mod; 622 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/stubRoutines.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
10 lines changed: 10 ins; 0 del; 0 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_version.cpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
1 line changed: 1 ins; 0 del; 0 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_version.hpp

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
13 lines changed: 13 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 1 ins; 0 del; 3 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/nio/MappedByteBuffer.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
61 lines changed: 57 ins; 1 del; 3 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/misc/Unsafe.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
114 lines changed: 114 ins; 0 del; 0 mod; 3830 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/misc/UnsafeConstants.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
19 lines changed: 19 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/module-info.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
1 line changed: 1 ins; 0 del; 0 mod; 374 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
128 lines changed: 99 ins; 11 del; 18 mod; 1187 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/Util.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
13 lines changed: 6 ins; 0 del; 7 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/native/libnio/ch/FileChannelImpl.c

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
37 lines changed: 36 ins; 0 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/native/libnio/ch/FileChannelImpl.c

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
7 lines changed: 5 ins; 0 del; 2 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.management/share/classes/sun/management/ManagementFactoryHelper.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
3 lines changed: 2 ins; 0 del; 1 mod; 585 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
4 lines changed: 4 ins; 0 del; 0 mod; 652 unchg

------ ------ ------ ------ --- New ----- Raw src/java.base/share/classes/jdk/internal/misc/ExtendedMapMode.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.nio.mapmode/share/classes/jdk/nio/mapmode/ExtendedMapMode.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.nio.mapmode/share/classes/module-info.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/java/nio/MappedByteBuffer/MapFail.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/java/nio/MappedByteBuffer/PmemTest.java

rev 55911 : 8224974: Implement JEP 352
Summary: Non-Volatile Mapped Byte Buffers
Reviewed-by: alanb, kvn, bpb, gromero, darcy, shade, bulasevich
154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/adinn/redhat/openjdk/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).