Code Review for JDK-8023003

Prepared by:adlertz on Wed Aug 14 13:14:23 CEST 2013
Workspace:/home/adlertz/repos/hotspot/JDK-8023003
Compare against: http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/
Compare against version:5041
Summary of changes: 1249 lines changed: 278 ins; 285 del; 686 mod; 27694 unchg
Patch of changes: JDK-8023003.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/block.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
191 lines changed: 18 ins; 57 del; 116 mod; 1330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/block.hpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
180 lines changed: 118 ins; 46 del; 16 mod; 700 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/buildOopMap.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
36 lines changed: 8 ins; 11 del; 17 mod; 664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/chaitin.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
106 lines changed: 9 ins; 36 del; 61 mod; 2276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/coalesce.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
29 lines changed: 0 ins; 18 del; 11 mod; 780 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/compile.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
52 lines changed: 16 ins; 8 del; 28 mod; 3740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/domgraph.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
42 lines changed: 0 ins; 21 del; 21 mod; 623 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/gcm.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
179 lines changed: 48 ins; 18 del; 113 mod; 1894 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/idealGraphPrinter.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
12 lines changed: 0 ins; 0 del; 12 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/ifg.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
105 lines changed: 12 ins; 24 del; 69 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/lcm.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
3 lines changed: 0 ins; 0 del; 3 mod; 1108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/live.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
65 lines changed: 5 ins; 18 del; 42 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/matcher.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
12 lines changed: 2 ins; 0 del; 10 mod; 2415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/matcher.hpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
23 lines changed: 20 ins; 0 del; 3 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/output.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
148 lines changed: 16 ins; 28 del; 104 mod; 2850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/phaseX.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 1792 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/postaloc.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
55 lines changed: 6 ins; 0 del; 49 mod; 659 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/reg_split.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
7 lines changed: 0 ins; 0 del; 7 mod; 1417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp

rev 5042 : 8023003: Cleanup the public interface to PhaseCFG
Summary: public methods that don't need to be public should be private.
Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 3215 unchg

This code review page was prepared using /bin/webrev.ksh (vers 23.18-hg-never-dev).