Code Review for client

Prepared by:AGHAISAS on Fri Jun 14 14:59:47 IST 2019
Workspace:/Users/AGHAISAS/jdk_workspace/openjdk_client/client
Compare against: http://hg.openjdk.java.net/jdk/client
Compare against version:55351
Summary of changes: 11505 lines changed: 11447 ins; 13 del; 45 mod; 16823 unchg
Changeset: client.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Awt2dLibraries.gmk

rev 55352 : JB_base_webrev
16 lines changed: 16 ins; 0 del; 0 mod; 983 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/module/jdk8_packages.dat

rev 55352 : JB_base_webrev
1 line changed: 1 ins; 0 del; 0 mod; 1340 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/awt/CGraphicsConfig.java

rev 55352 : JB_base_webrev
2 lines changed: 1 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/awt/CGraphicsDevice.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/java2d/MacosxSurfaceManagerFactory.java

rev 55352 : JB_base_webrev
4 lines changed: 3 ins; 0 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java

rev 55352 : JB_base_webrev
3 lines changed: 1 ins; 0 del; 2 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/java2d/opengl/CGLSurfaceData.java

rev 55352 : JB_base_webrev
1 line changed: 0 ins; 0 del; 1 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/lwawt/LWComponentPeer.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 1463 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformView.java

rev 55352 : JB_base_webrev
22 lines changed: 17 ins; 0 del; 5 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java

rev 55352 : JB_base_webrev
3 lines changed: 3 ins; 0 del; 0 mod; 1360 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java

rev 55352 : JB_base_webrev
18 lines changed: 18 ins; 0 del; 0 mod; 457 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java

rev 55352 : JB_base_webrev
7 lines changed: 6 ins; 0 del; 1 mod; 1006 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h

rev 55352 : JB_base_webrev
2 lines changed: 1 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m

rev 55352 : JB_base_webrev
20 lines changed: 20 ins; 0 del; 0 mod; 1479 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m

rev 55352 : JB_base_webrev
6 lines changed: 6 ins; 0 del; 0 mod; 1659 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m

rev 55352 : JB_base_webrev
2 lines changed: 2 ins; 0 del; 0 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/Blit.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/BlitBg.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListAA.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListLCD.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/DrawLine.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/FillParallelogram.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/FillRect.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/FillSpans.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitive.java

rev 55352 : JB_base_webrev
110 lines changed: 83 ins; 12 del; 15 mod; 600 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java

rev 55352 : JB_base_webrev
1 line changed: 1 ins; 0 del; 0 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/MaskBlit.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/MaskFill.java

rev 55352 : JB_base_webrev
15 lines changed: 12 ins; 0 del; 3 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/ScaledBlit.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/loops/TransformHelper.java

rev 55352 : JB_base_webrev
5 lines changed: 4 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/classes/sun/java2d/opengl/OGLTextRenderer.java

rev 55352 : JB_base_webrev
6 lines changed: 5 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/native/libawt/java2d/Trace.h

rev 55352 : JB_base_webrev
56 lines changed: 56 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/native/libawt/java2d/loops/FillParallelogram.c

rev 55352 : JB_base_webrev
1 line changed: 0 ins; 1 del; 0 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/native/libawt/java2d/loops/GraphicsPrimitiveMgr.c

rev 55352 : JB_base_webrev
8 lines changed: 8 ins; 0 del; 0 mod; 658 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/share/native/libawt/java2d/loops/GraphicsPrimitiveMgr.h

rev 55352 : JB_base_webrev
1 line changed: 1 ins; 0 del; 0 mod; 658 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/windows/native/libawt/windows/awt.h

rev 55352 : JB_base_webrev
1 line changed: 0 ins; 0 del; 1 mod; 387 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/macos/MacOSFlags.java

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLBlitLoops.java

rev 55352 : JB_base_webrev
945 lines changed: 945 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLBufImgOps.java

rev 55352 : JB_base_webrev
112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLContext.java

rev 55352 : JB_base_webrev
222 lines changed: 222 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLDrawImage.java

rev 55352 : JB_base_webrev
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java

rev 55352 : JB_base_webrev
439 lines changed: 439 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLLayer.java

rev 55352 : JB_base_webrev
124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLMaskBlit.java

rev 55352 : JB_base_webrev
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLMaskFill.java

rev 55352 : JB_base_webrev
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLPaints.java

rev 55352 : JB_base_webrev
208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderQueue.java

rev 55352 : JB_base_webrev
254 lines changed: 254 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderer.java

rev 55352 : JB_base_webrev
223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceData.java

rev 55352 : JB_base_webrev
885 lines changed: 885 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceDataProxy.java

rev 55352 : JB_base_webrev
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLTextRenderer.java

rev 55352 : JB_base_webrev
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLUtilities.java

rev 55352 : JB_base_webrev
326 lines changed: 326 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLVolatileSurfaceManager.java

146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/common.h

rev 55352 : JB_base_webrev
67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/shaders.metal

rev 55352 : JB_base_webrev
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.h

rev 55352 : JB_base_webrev
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m

rev 55352 : JB_base_webrev
482 lines changed: 482 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBufImgOps.h

rev 55352 : JB_base_webrev
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBufImgOps.m

rev 55352 : JB_base_webrev
378 lines changed: 378 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.h

rev 55352 : JB_base_webrev
240 lines changed: 240 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.m

448 lines changed: 448 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLFuncs.h

rev 55352 : JB_base_webrev
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLFuncs.m

rev 55352 : JB_base_webrev
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.h

rev 55352 : JB_base_webrev
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m

rev 55352 : JB_base_webrev
203 lines changed: 203 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.h

rev 55352 : JB_base_webrev
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m

180 lines changed: 180 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskBlit.h

rev 55352 : JB_base_webrev
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskBlit.m

rev 55352 : JB_base_webrev
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskFill.h

rev 55352 : JB_base_webrev
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskFill.m

rev 55352 : JB_base_webrev
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.h

rev 55352 : JB_base_webrev
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m

rev 55352 : JB_base_webrev
462 lines changed: 462 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.h

rev 55352 : JB_base_webrev
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.m

rev 55352 : JB_base_webrev
147 lines changed: 147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderQueue.h

rev 55352 : JB_base_webrev
134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderQueue.m

rev 55352 : JB_base_webrev
850 lines changed: 850 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.h

rev 55352 : JB_base_webrev
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m

654 lines changed: 654 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceData.h

rev 55352 : JB_base_webrev
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceData.m

rev 55352 : JB_base_webrev
458 lines changed: 458 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceDataBase.h

rev 55352 : JB_base_webrev
212 lines changed: 212 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTextRenderer.h

rev 55352 : JB_base_webrev
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTextRenderer.m

rev 55352 : JB_base_webrev
382 lines changed: 382 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexturePool.h

rev 55352 : JB_base_webrev
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexurePool.m

rev 55352 : JB_base_webrev
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLUtils.h

rev 55352 : JB_base_webrev
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLUtils.m

rev 55352 : JB_base_webrev
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.h

rev 55352 : JB_base_webrev
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.m

rev 55352 : JB_base_webrev
175 lines changed: 175 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/AGHAISAS/Downloads/webrev.ksh (vers 25.17-hg+openjdk.java.net).