Code Review for jdk

Prepared by:alanb on Mon Jun 10 10:38:27 IST 2013
Workspace:/u/alanb/ws/tl/jdk
Summary of changes: 630 lines changed: 19 ins; 13 del; 598 mod; 96465 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/BufferedInputStream.java

1 line changed: 0 ins; 0 del; 1 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/BufferedReader.java

2 lines changed: 0 ins; 0 del; 2 mod; 590 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/BufferedWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/Console.java

2 lines changed: 0 ins; 0 del; 2 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/PipedInputStream.java

2 lines changed: 0 ins; 0 del; 2 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/PipedReader.java

2 lines changed: 0 ins; 0 del; 2 mod; 361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/PrintStream.java

4 lines changed: 0 ins; 0 del; 4 mod; 1125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/PushbackInputStream.java

1 line changed: 0 ins; 0 del; 1 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/PushbackReader.java

1 line changed: 0 ins; 0 del; 1 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/StringReader.java

1 line changed: 0 ins; 0 del; 1 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Character.java

2 lines changed: 0 ins; 0 del; 2 mod; 7227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/ClassLoader.java

1 line changed: 0 ins; 0 del; 1 mod; 2184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Comparable.java

1 line changed: 0 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Double.java

5 lines changed: 0 ins; 0 del; 5 mod; 1063 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Float.java

5 lines changed: 0 ins; 0 del; 5 mod; 968 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/StackTraceElement.java

2 lines changed: 0 ins; 0 del; 2 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/instrument/Instrumentation.java

12 lines changed: 4 ins; 0 del; 8 mod; 649 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/invoke/MethodHandle.java

10 lines changed: 0 ins; 0 del; 10 mod; 1396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/invoke/MethodHandles.java

2 lines changed: 0 ins; 0 del; 2 mod; 2290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/management/MemoryUsage.java

2 lines changed: 0 ins; 0 del; 2 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/management/RuntimeMXBean.java

1 line changed: 0 ins; 0 del; 1 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/management/ThreadMXBean.java

6 lines changed: 0 ins; 0 del; 6 mod; 800 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/CookieManager.java

2 lines changed: 0 ins; 0 del; 2 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/CookiePolicy.java

1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/DatagramSocket.java

5 lines changed: 0 ins; 0 del; 5 mod; 1258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/HttpURLConnection.java

2 lines changed: 0 ins; 0 del; 2 mod; 815 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/InetSocketAddress.java

1 line changed: 0 ins; 0 del; 1 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/MulticastSocket.java

1 line changed: 0 ins; 0 del; 1 mod; 708 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/ServerSocket.java

3 lines changed: 0 ins; 0 del; 3 mod; 884 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/Socket.java

3 lines changed: 0 ins; 0 del; 3 mod; 1683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/StandardSocketOptions.java

2 lines changed: 0 ins; 0 del; 2 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/URI.java

1 line changed: 0 ins; 0 del; 1 mod; 3551 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/URLConnection.java

2 lines changed: 0 ins; 0 del; 2 mod; 1785 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/nio/X-Buffer.java.template

16 lines changed: 4 ins; 0 del; 12 mod; 1479 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/nio/channels/SelectableChannel.java

3 lines changed: 0 ins; 0 del; 3 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/nio/channels/SelectionKey.java

21 lines changed: 4 ins; 4 del; 13 mod; 384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/nio/charset/Charset-X-Coder.java.template

2 lines changed: 0 ins; 0 del; 2 mod; 979 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/nio/file/Path.java

2 lines changed: 0 ins; 0 del; 2 mod; 799 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/KeyStore.java

1 line changed: 0 ins; 0 del; 1 mod; 2132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/SecureRandom.java

1 line changed: 0 ins; 0 del; 1 mod; 683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/cert/CertPathValidatorException.java

4 lines changed: 0 ins; 0 del; 4 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/cert/CertificateFactory.java

2 lines changed: 0 ins; 0 del; 2 mod; 535 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/cert/X509Extension.java

3 lines changed: 0 ins; 0 del; 3 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/spec/EllipticCurve.java

2 lines changed: 0 ins; 0 del; 2 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/sql/DatabaseMetaData.java

257 lines changed: 0 ins; 0 del; 257 mod; 3431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/sql/DriverManager.java

1 line changed: 0 ins; 0 del; 1 mod; 724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/sql/ResultSet.java

1 line changed: 0 ins; 0 del; 1 mod; 4289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/sql/Statement.java

9 lines changed: 0 ins; 0 del; 9 mod; 1361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/text/CharacterIterator.java

6 lines changed: 0 ins; 0 del; 6 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/text/ChoiceFormat.java

1 line changed: 0 ins; 0 del; 1 mod; 620 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/text/Collator.java

2 lines changed: 0 ins; 0 del; 2 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Calendar.java

4 lines changed: 0 ins; 0 del; 4 mod; 3587 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Collections.java

4 lines changed: 0 ins; 0 del; 4 mod; 4718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Date.java

4 lines changed: 1 ins; 0 del; 3 mod; 1372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/LinkedHashMap.java

2 lines changed: 0 ins; 0 del; 2 mod; 471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Random.java

1 line changed: 0 ins; 0 del; 1 mod; 637 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/ResourceBundle.java

2 lines changed: 0 ins; 0 del; 2 mod; 2961 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Scanner.java

16 lines changed: 4 ins; 0 del; 12 mod; 2648 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/TimerTask.java

2 lines changed: 0 ins; 0 del; 2 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/jar/Pack200.java

2 lines changed: 0 ins; 0 del; 2 mod; 819 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/ConsoleHandler.java

1 line changed: 0 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/FileHandler.java

2 lines changed: 0 ins; 0 del; 2 mod; 666 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/MemoryHandler.java

2 lines changed: 0 ins; 0 del; 2 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/prefs/Preferences.java

42 lines changed: 0 ins; 0 del; 42 mod; 1216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/regex/MatchResult.java

1 line changed: 0 ins; 0 del; 1 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/regex/Pattern.java

1 line changed: 0 ins; 0 del; 1 mod; 5827 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/package-info.java

1 line changed: 0 ins; 0 del; 1 mod; 565 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/DeflaterInputStream.java

3 lines changed: 0 ins; 1 del; 2 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/DeflaterOutputStream.java

2 lines changed: 0 ins; 0 del; 2 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/GZIPInputStream.java

1 line changed: 0 ins; 0 del; 1 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/GZIPOutputStream.java

3 lines changed: 0 ins; 1 del; 2 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/InflaterInputStream.java

2 lines changed: 0 ins; 0 del; 2 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/InflaterOutputStream.java

3 lines changed: 0 ins; 0 del; 3 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/ZipInputStream.java

1 line changed: 0 ins; 0 del; 1 mod; 452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/crypto/spec/IvParameterSpec.java

1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/crypto/spec/RC5ParameterSpec.java

2 lines changed: 0 ins; 0 del; 2 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/crypto/spec/SecretKeySpec.java

1 line changed: 0 ins; 0 del; 1 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/BinaryRefAddr.java

2 lines changed: 0 ins; 0 del; 2 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/directory/Attribute.java

4 lines changed: 0 ins; 0 del; 4 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/LdapName.java

3 lines changed: 0 ins; 0 del; 3 mod; 784 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/PagedResultsControl.java

4 lines changed: 0 ins; 0 del; 4 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/SortControl.java

2 lines changed: 0 ins; 0 del; 2 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/net/ssl/SNIHostName.java

2 lines changed: 0 ins; 0 del; 2 mod; 393 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/net/ssl/SSLEngine.java

6 lines changed: 0 ins; 0 del; 6 mod; 1250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/net/ssl/SSLEngineResult.java

1 line changed: 0 ins; 0 del; 1 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/net/ssl/SSLSessionContext.java

2 lines changed: 0 ins; 0 del; 2 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/script/ScriptEngineFactory.java

8 lines changed: 0 ins; 2 del; 6 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/security/auth/callback/CallbackHandler.java

2 lines changed: 0 ins; 0 del; 2 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/security/sasl/Sasl.java

4 lines changed: 0 ins; 0 del; 4 mod; 617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/security/sasl/SaslClient.java

4 lines changed: 0 ins; 0 del; 4 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/security/sasl/SaslServer.java

2 lines changed: 0 ins; 0 del; 2 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/smartcardio/ResponseAPDU.java

1 line changed: 0 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/sql/DataSource.java

2 lines changed: 0 ins; 0 del; 2 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/sql/rowset/BaseRowSet.java

8 lines changed: 0 ins; 0 del; 8 mod; 4526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/sql/rowset/CachedRowSet.java

12 lines changed: 0 ins; 0 del; 12 mod; 1613 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/sql/rowset/Predicate.java

13 lines changed: 2 ins; 3 del; 8 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java

4 lines changed: 0 ins; 0 del; 4 mod; 1093 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/sql/rowset/spi/SyncFactory.java

2 lines changed: 0 ins; 2 del; 0 mod; 917 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/sql/rowset/spi/SyncResolver.java

4 lines changed: 0 ins; 0 del; 4 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/xml/crypto/dsig/Manifest.java

9 lines changed: 0 ins; 0 del; 9 mod; 82 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).