Code Review for nashorn

Prepared by: Jenkins user (jenkins) on Tue Mar 8 15:08:09 GMT 2016
Workspace:/scratch/jenkins/jobs/jake-webrevs/workspace/nashorn
Compare against: http://hg.openjdk.java.net/jigsaw/jake/nashorn
Compare against version:jdk-9+108
Summary of changes: 893 lines changed: 585 ins; 167 del; 141 mod; 14329 unchg
Patch of changes: nashorn.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/build.xml

2 lines changed: 0 ins; 1 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/project.properties

5 lines changed: 1 ins; 2 del; 2 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java

3 lines changed: 3 ins; 0 del; 0 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MemberInfo.java

51 lines changed: 37 ins; 11 del; 3 mod; 555 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java

3 lines changed: 1 ins; 1 del; 1 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfo.java

26 lines changed: 8 ins; 9 del; 9 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfoCollector.java

1 line changed: 0 ins; 1 del; 0 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java

1 line changed: 0 ins; 1 del; 0 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java

23 lines changed: 6 ins; 8 del; 9 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/BuildNashorn.gmk

28 lines changed: 16 ins; 6 del; 6 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/build-nasgen.xml

5 lines changed: 0 ins; 2 del; 3 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/build.xml

108 lines changed: 38 ins; 42 del; 28 mod; 794 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/nbproject/ide-targets.xml

1 line changed: 0 ins; 0 del; 1 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/project.properties

40 lines changed: 28 ins; 9 del; 3 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw samples/test.js

2 lines changed: 2 ins; 0 del; 0 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.dynalink/share/classes/jdk/dynalink/DynamicLinkerFactory.java

1 line changed: 0 ins; 1 del; 0 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.dynalink/share/classes/jdk/dynalink/beans/CallerSensitiveDynamicMethod.java

2 lines changed: 0 ins; 0 del; 2 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.dynalink/share/classes/jdk/dynalink/beans/CheckRestrictedPackage.java

18 lines changed: 12 ins; 5 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.dynalink/share/classes/jdk/dynalink/linker/support/Lookup.java

62 lines changed: 62 ins; 0 del; 0 mod; 401 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/CodeStore.java

26 lines changed: 0 ins; 25 del; 1 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Context.java

4 lines changed: 1 ins; 0 del; 3 mod; 1666 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/NashornLoader.java

36 lines changed: 31 ins; 0 del; 5 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptLoader.java

30 lines changed: 29 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Source.java

1 line changed: 0 ins; 0 del; 1 mod; 1037 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/StructureLoader.java

20 lines changed: 20 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java

62 lines changed: 29 ins; 9 del; 24 mod; 1161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java

40 lines changed: 39 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java

1 line changed: 0 ins; 0 del; 1 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java

7 lines changed: 5 ins; 0 del; 2 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/currently-failing/JDK-8055034.js

1 line changed: 0 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/nosecurity/JDK-8044798.js

12 lines changed: 7 ins; 1 del; 4 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/nosecurity/JDK-8044851.js

28 lines changed: 20 ins; 1 del; 7 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/nosecurity/JDK-8067215.js

25 lines changed: 18 ins; 0 del; 7 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/nosecurity/JDK-8078049.js

7 lines changed: 3 ins; 0 del; 4 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/trusted/classfilter_extends.js.EXPECTED

3 lines changed: 0 ins; 0 del; 3 mod; 13 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/trusted/classfilter_mozilla_compat.js.EXPECTED

3 lines changed: 0 ins; 0 del; 3 mod; 9 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/trusted/event_queue.js

1 line changed: 1 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/trusted/optimistic_recompilation.js

1 line changed: 1 ins; 0 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/doubleconv/test/BignumTest.java

1 line changed: 1 ins; 0 del; 0 mod; 1486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/doubleconv/test/DiyFpTest.java

1 line changed: 1 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/regexp/joni/test/JoniTest.java

1 line changed: 1 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/regexp/test/JdkRegExpTest.java

1 line changed: 1 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/CodeStoreAndPathTest.java

6 lines changed: 2 ins; 0 del; 4 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/ConsStringTest.java

1 line changed: 1 ins; 0 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/ContextTest.java

3 lines changed: 3 ins; 0 del; 0 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/ExceptionsNotSerializable.java

1 line changed: 1 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/JDK_8078414_Test.java

4 lines changed: 4 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/JSTypeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java

2 lines changed: 0 ins; 2 del; 0 mod; 245 unchg

------ ------ ------ ------ --- New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/Where.java

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.dynalink/share/classes/module-info.java

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.scripting.nashorn.shell/share/classes/module-info.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.scripting.nashorn/share/classes/module-info.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.scripting.nashorn/share/classes/META-INF/MANIFEST.MF

5 lines changed: 0 ins; 5 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.scripting.nashorn/share/classes/META-INF/services/javax.script.ScriptEngineFactory

25 lines changed: 0 ins; 25 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/jenkins/tools/webrev.ksh (vers 25.14-hg+openjdk.java.net).