Code Review for modulefinder-dev

Prepared by:alanb on Fri May 20 19:35:12 IST 2016
Workspace:/Users/albatem/ws/modulefinder-dev
Compare against: http://hg.openjdk.java.net/jdk9/dev
Summary of changes: 315 lines changed: 128 ins; 34 del; 153 mod; 15237 unchg
Patch of changes: modulefinder-dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/src/classes/build/tools/jigsaw/GenGraphs.java

2 lines changed: 0 ins; 0 del; 2 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/src/classes/build/tools/jigsaw/ModuleSummary.java

1 line changed: 0 ins; 0 del; 1 mod; 765 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/java/lang/module/Configuration.java

2 lines changed: 0 ins; 0 del; 2 mod; 455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/java/lang/module/ModuleFinder.java

119 lines changed: 43 ins; 28 del; 48 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/java/lang/reflect/Layer.java

2 lines changed: 0 ins; 0 del; 2 mod; 604 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java

1 line changed: 0 ins; 0 del; 1 mod; 555 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jartool/share/classes/sun/tools/jar/Main.java

1 line changed: 0 ins; 0 del; 1 mod; 1946 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java

2 lines changed: 0 ins; 0 del; 2 mod; 561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java

1 line changed: 0 ins; 0 del; 1 mod; 728 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/Class/forName/modules/TestLayer.java

1 line changed: 0 ins; 0 del; 1 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/Class/forName/modules/src/m3/p3/NoAccess.java

1 line changed: 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/module/AutomaticModulesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/module/ConfigurationTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 1545 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/module/ModuleFinderTest.java

106 lines changed: 85 ins; 3 del; 18 mod; 589 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/reflect/Layer/BasicLayerTest.java

9 lines changed: 0 ins; 1 del; 8 mod; 858 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/reflect/Layer/LayerAndLoadersTest.java

14 lines changed: 0 ins; 1 del; 13 mod; 660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/reflect/Proxy/ProxyClassAccessTest.java

1 line changed: 0 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/reflect/Proxy/ProxyLayerTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/util/ServiceLoader/modules/ServicesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/jdk/modules/scenarios/container/src/container/container/Main.java

1 line changed: 0 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/DiffCL_CheckRead.java

1 line changed: 0 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/DiffCL_ExpQualOther.java

1 line changed: 0 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/DiffCL_ExpQualToM1.java

1 line changed: 0 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/DiffCL_ExpUnqual.java

1 line changed: 0 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/DiffCL_PkgNotExp.java

1 line changed: 0 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/DiffCL_Umod.java

3 lines changed: 0 ins; 0 del; 3 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/DiffCL_UmodUpkg.java

2 lines changed: 0 ins; 0 del; 2 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/ExpQualOther.java

1 line changed: 0 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/ExpQualToM1.java

1 line changed: 0 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/ExpUnqual.java

1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/ExportAllUnnamed.java

1 line changed: 0 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/PkgNotExp.java

1 line changed: 0 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/Umod.java

3 lines changed: 0 ins; 0 del; 3 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodDiffCL_ExpQualOther.java

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodDiffCL_ExpUnqual.java

1 line changed: 0 ins; 0 del; 1 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodDiffCL_PkgNotExp.java

1 line changed: 0 ins; 0 del; 1 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodUPkg.java

2 lines changed: 0 ins; 0 del; 2 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodUpkgDiffCL_ExpQualOther.java

1 line changed: 0 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodUpkgDiffCL_NotExp.java

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodUpkg_ExpQualOther.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/UmodUpkg_NotExp.java

1 line changed: 0 ins; 0 del; 1 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/Umod_ExpQualOther.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/Umod_ExpUnqual.java

1 line changed: 0 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/modules/AccessCheck/Umod_PkgNotExp.java

1 line changed: 0 ins; 0 del; 1 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jaxp/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jaxp/test/javax/xml/jaxp/module/ServiceProviderTest/LayerModularXMLParserTest.java

6 lines changed: 0 ins; 1 del; 5 mod; 181 unchg

This code review page was prepared using /Users/albatem/bin/webrev.ksh (vers 25.14-hg+openjdk.java.net).