--- old/test/java/lang/module/ModuleReferenceTest.java 2016-12-15 09:19:24.690932994 +0000 +++ new/test/java/lang/module/ModuleReferenceTest.java 2016-12-15 09:19:24.562924237 +0000 @@ -31,7 +31,6 @@ import java.lang.module.ModuleReader; import java.lang.module.ModuleReference; import java.net.URI; -import java.util.function.Supplier; import org.testng.annotations.Test; import static org.testng.Assert.*; @@ -39,8 +38,13 @@ @Test public class ModuleReferenceTest { - private Supplier makeSupplier() { - return () -> { throw new UnsupportedOperationException(); }; + private ModuleReference newModuleReference(ModuleDescriptor descriptor, URI uri) { + return new ModuleReference(descriptor, uri) { + @Override + public ModuleReader open() { + throw new UnsupportedOperationException(); + } + }; } public void testBasic() throws Exception { @@ -53,25 +57,16 @@ URI uri = URI.create("module:/m"); - Supplier supplier = makeSupplier(); - - ModuleReference mref = new ModuleReference(descriptor, uri, supplier); + ModuleReference mref = newModuleReference(descriptor, uri); assertTrue(mref.descriptor().equals(descriptor)); assertTrue(mref.location().get().equals(uri)); - - // check that the supplier is called - try { - mref.open(); - assertTrue(false); - } catch (UnsupportedOperationException expected) { } } - @Test(expectedExceptions = { NullPointerException.class }) public void testNullDescriptor() throws Exception { URI location = URI.create("module:/m"); - new ModuleReference(null, location, makeSupplier()); + newModuleReference(null, location); } public void testNullLocation() { @@ -79,55 +74,8 @@ = ModuleDescriptor.module("m") .exports("p") .build(); - Supplier supplier = makeSupplier(); - ModuleReference mref = new ModuleReference(descriptor, null, supplier); + ModuleReference mref = newModuleReference(descriptor, null); assertTrue(!mref.location().isPresent()); } - @Test(expectedExceptions = { NullPointerException.class }) - public void testNullSupplier() throws Exception { - ModuleDescriptor descriptor = ModuleDescriptor.module("m").build(); - URI location = URI.create("module:/m"); - new ModuleReference(descriptor, location, null); - } - - - public void testEqualsAndHashCode() { - ModuleDescriptor descriptor1 - = ModuleDescriptor.module("m1") - .exports("p") - .build(); - ModuleDescriptor descriptor2 - = ModuleDescriptor.module("m1") - .exports("p") - .build(); - - URI uri = URI.create("module:/m1"); - Supplier supplier = makeSupplier(); - - ModuleReference mref1 = new ModuleReference(descriptor1, uri, supplier); - ModuleReference mref2 = new ModuleReference(descriptor2, uri, supplier); - ModuleReference mref3 = new ModuleReference(descriptor1, null, supplier); - - assertTrue(mref1.equals(mref1)); - assertTrue(mref1.equals(mref2)); - assertTrue(mref2.equals(mref1)); - assertTrue(mref1.hashCode() == mref2.hashCode()); - - assertTrue(mref3.equals(mref3)); - assertFalse(mref3.equals(mref1)); - assertFalse(mref1.equals(mref3)); - } - - - public void testToString() { - ModuleDescriptor descriptor = ModuleDescriptor.module("m1").build(); - URI uri = URI.create("module:/m1"); - Supplier supplier = makeSupplier(); - ModuleReference mref = new ModuleReference(descriptor, uri, supplier); - String s = mref.toString(); - assertTrue(s.contains("m1")); - assertTrue(s.contains(uri.toString())); - } - }