Code Review for open

Prepared by:alanb on Thu Mar 22 13:26:58 GMT 2018
Workspace:/Users/albatem/ws/jdk/open
Compare against version:f6ad4d73c834
Summary of changes: 1908 lines changed: 393 ins; 1155 del; 360 mod; 4967 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnio/mapfile-linux

rev 49271 : [mq]: selector-cleanup
16 lines changed: 1 ins; 11 del; 4 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnio/mapfile-macosx

rev 49271 : [mq]: selector-cleanup
101 lines changed: 2 ins; 4 del; 95 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnio/mapfile-solaris

rev 49271 : [mq]: selector-cleanup
3 lines changed: 1 ins; 1 del; 1 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/sun/nio/ch/EPoll.java

rev 49271 : [mq]: selector-cleanup
3 lines changed: 0 ins; 0 del; 3 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/sun/nio/ch/EPollPort.java

rev 49271 : [mq]: selector-cleanup
55 lines changed: 13 ins; 19 del; 23 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/sun/nio/ch/EPollSelectorImpl.java

rev 49271 : [mq]: selector-cleanup
178 lines changed: 118 ins; 10 del; 50 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/native/libnio/ch/EPoll.c

rev 49271 : [mq]: selector-cleanup
36 lines changed: 11 ins; 11 del; 14 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/macosx/classes/sun/nio/ch/KQueue.java

rev 49271 : [mq]: selector-cleanup
6 lines changed: 0 ins; 0 del; 6 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/macosx/classes/sun/nio/ch/KQueuePort.java

rev 49271 : [mq]: selector-cleanup
57 lines changed: 12 ins; 20 del; 25 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/macosx/classes/sun/nio/ch/KQueueSelectorImpl.java

rev 49271 : [mq]: selector-cleanup
242 lines changed: 140 ins; 31 del; 71 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/macosx/classes/sun/nio/ch/KQueueSelectorProvider.java

rev 49271 : [mq]: selector-cleanup
8 lines changed: 0 ins; 7 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/macosx/native/libnio/ch/KQueue.c

rev 49271 : [mq]: selector-cleanup
42 lines changed: 22 ins; 7 del; 13 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/IOUtil.java

rev 49271 : [mq]: selector-cleanup
3 lines changed: 2 ins; 0 del; 1 mod; 437 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SelectionKeyImpl.java

rev 49271 : [mq]: selector-cleanup
10 lines changed: 7 ins; 0 del; 3 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SelectorImpl.java

rev 49271 : [mq]: selector-cleanup
17 lines changed: 15 ins; 2 del; 0 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

rev 49271 : [mq]: selector-cleanup
19 lines changed: 0 ins; 5 del; 14 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java

rev 49271 : [mq]: selector-cleanup
13 lines changed: 4 ins; 1 del; 8 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java

rev 49271 : [mq]: selector-cleanup
1 line changed: 0 ins; 0 del; 1 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/solaris/classes/sun/nio/ch/EventPortWrapper.java

rev 49271 : [mq]: selector-cleanup
18 lines changed: 14 ins; 0 del; 4 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/solaris/classes/sun/nio/ch/SolarisEventPort.java

rev 49271 : [mq]: selector-cleanup
6 lines changed: 3 ins; 0 del; 3 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/solaris/native/libnio/ch/DevPollArrayWrapper.c

rev 49271 : [mq]: selector-cleanup
12 lines changed: 0 ins; 11 del; 1 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/solaris/native/libnio/ch/SolarisEventPort.c

rev 49271 : [mq]: selector-cleanup
32 lines changed: 18 ins; 5 del; 9 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/nio/ch/PipeImpl.java

rev 49271 : [mq]: selector-cleanup
2 lines changed: 0 ins; 0 del; 2 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/nio/ch/PollSelectorImpl.java

rev 49271 : [mq]: selector-cleanup
2 lines changed: 0 ins; 0 del; 2 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/nio/ch/SocketDispatcher.java

rev 49271 : [mq]: selector-cleanup
5 lines changed: 1 ins; 1 del; 3 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnio/ch/IOUtil.c

rev 49271 : [mq]: selector-cleanup
11 lines changed: 9 ins; 0 del; 2 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/Selector/CloseWhenKeyIdle.java

rev 49271 : [mq]: selector-cleanup
17 lines changed: 0 ins; 16 del; 1 mod; 129 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/linux/classes/sun/nio/ch/EPollArrayWrapper.java

309 lines changed: 0 ins; 309 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/linux/native/libnio/ch/EPollArrayWrapper.c

160 lines changed: 0 ins; 160 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/linux/native/libnio/ch/EPollPort.c

76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/macosx/classes/sun/nio/ch/KQueueArrayWrapper.java

197 lines changed: 0 ins; 197 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/macosx/native/libnio/ch/KQueueArrayWrapper.c

175 lines changed: 0 ins; 175 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/macosx/native/libnio/ch/KQueuePort.c

76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

This code review page was prepared using /Users/albatem/bin/webrev.ksh (vers 25.14-hg+openjdk.java.net).