Code Review for open

Prepared by:alanb on Mon Jan 21 17:09:20 GMT 2019
Workspace:/Users/albatem/ws/nio/open
Compare against version:qparent
Summary of changes: 106 lines changed: 41 ins; 28 del; 37 mod; 4423 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java

rev 53408 : [mq]: ext
39 lines changed: 32 ins; 0 del; 7 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java

rev 53408 : [mq]: ext
3 lines changed: 0 ins; 1 del; 2 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java

rev 53408 : [mq]: ext
3 lines changed: 0 ins; 1 del; 2 mod; 604 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java

rev 53408 : [mq]: ext
3 lines changed: 0 ins; 1 del; 2 mod; 1334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

rev 53408 : [mq]: ext
5 lines changed: 0 ins; 3 del; 2 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java

rev 53408 : [mq]: ext
3 lines changed: 0 ins; 1 del; 2 mod; 1128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java

rev 53408 : [mq]: ext
3 lines changed: 0 ins; 1 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainSocketImpl.java

rev 53408 : [mq]: ext
22 lines changed: 4 ins; 16 del; 2 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/SocketChannel/SocketOptionTests.java

rev 53408 : [mq]: ext
25 lines changed: 5 ins; 4 del; 16 mod; 144 unchg

This code review page was prepared using /Users/albatem/bin/webrev.ksh (vers 25.14-hg+openjdk.java.net).