Code Review for open

Prepared by:almatvee on Fri Feb 15 18:15:25 PST 2019
Workspace:/cygdrive/e/Repositories/sandbox-2/open
Compare against: http://hg.openjdk.java.net/jdk/sandbox/
Branch:JDK-8200758-branch
Summary of changes: 5478 lines changed: 2390 ins; 2764 del; 324 mod; 5418 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/native/libapplauncher/MacPlatform.mm

211 lines changed: 146 ins; 39 del; 26 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/FilePath.h

52 lines changed: 1 ins; 51 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Helpers.cpp

1 line changed: 0 ins; 0 del; 1 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/IniFile.cpp

1 line changed: 0 ins; 0 del; 1 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/JavaVirtualMachine.cpp

46 lines changed: 0 ins; 45 del; 1 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/JavaVirtualMachine.h

24 lines changed: 1 ins; 23 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Messages.cpp

3 lines changed: 0 ins; 3 del; 0 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/OrderedMap.h

14 lines changed: 0 ins; 11 del; 3 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Package.cpp

1 line changed: 0 ins; 1 del; 0 mod; 563 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Platform.cpp

163 lines changed: 54 ins; 60 del; 49 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Platform.h

297 lines changed: 13 ins; 264 del; 20 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/PlatformString.cpp

182 lines changed: 0 ins; 173 del; 9 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/PlatformString.h

84 lines changed: 0 ins; 84 del; 0 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/PropertyFile.cpp

1 line changed: 0 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/PropertyFile.h

4 lines changed: 0 ins; 3 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/native/libapplauncher/main.cpp

16 lines changed: 0 ins; 14 del; 2 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/native/libapplauncher/LinuxPlatform.cpp (was src/jdk.jpackage/share/native/libapplauncher/LinuxPlatform.cpp)

416 lines changed: 93 ins; 187 del; 136 mod; 858 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/native/libapplauncher/LinuxPlatform.h (was src/jdk.jpackage/share/native/libapplauncher/LinuxPlatform.h)

36 lines changed: 6 ins; 29 del; 1 mod; 67 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/linux/native/libapplauncher/PlatformDefs.h

67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/native/libapplauncher/MacPlatform.h (was src/jdk.jpackage/share/native/libapplauncher/MacPlatform.h)

18 lines changed: 4 ins; 12 del; 2 mod; 66 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/macosx/native/libapplauncher/PlatformDefs.h

112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/native/libapplauncher/FileAttributes.h

54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Library.cpp

188 lines changed: 188 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Library.h

100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/native/libapplauncher/Properties.h

184 lines changed: 184 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/unix/native/libapplauncher/FileAttribute.h

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/unix/native/libapplauncher/FileAttributes.cpp

331 lines changed: 331 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/unix/native/libapplauncher/FilePath.cpp

197 lines changed: 197 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/unix/native/libapplauncher/PosixPlatform.cpp (was src/jdk.jpackage/share/native/libapplauncher/PosixPlatform.cpp)

185 lines changed: 62 ins; 116 del; 7 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/unix/native/libapplauncher/PosixPlatform.h (was src/jdk.jpackage/share/native/libapplauncher/PosixPlatform.h)

15 lines changed: 4 ins; 11 del; 0 mod; 81 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/DllMain.cpp

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/FileAttribute.h

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/FilePath.cpp

473 lines changed: 473 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/PlatformDefs.h

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/WindowsPlatform.cpp (was src/jdk.jpackage/share/native/libapplauncher/WindowsPlatform.cpp)

192 lines changed: 91 ins; 40 del; 61 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/WindowsPlatform.h (was src/jdk.jpackage/share/native/libapplauncher/WindowsPlatform.h)

31 lines changed: 5 ins; 23 del; 3 mod; 164 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/FilePath.cpp

769 lines changed: 0 ins; 769 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/GenericPlatform.cpp

235 lines changed: 0 ins; 235 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/GenericPlatform.h

66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/JavaTypes.cpp

161 lines changed: 0 ins; 161 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/JavaTypes.h

57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/Lock.cpp

91 lines changed: 0 ins; 91 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/Lock.h

57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/PlatformThread.cpp

77 lines changed: 0 ins; 77 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/native/libapplauncher/PlatformThread.h

62 lines changed: 0 ins; 62 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).