Code Review for open

Prepared by:almatvee on Fri Feb 1 14:30:57 PST 2019
Workspace:/cygdrive/e/Repositories/sandbox-2/open
Compare against: http://hg.openjdk.java.net/jdk/sandbox/
Branch:JDK-8200758-branch
Summary of changes: 1426 lines changed: 382 ins; 774 del; 270 mod; 3606 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/launcher/Launcher-jdk.jpackage.gmk

24 lines changed: 0 ins; 21 del; 3 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.jpackage.gmk

17 lines changed: 17 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java

5 lines changed: 0 ins; 0 del; 5 mod; 941 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinExeBundler.java

7 lines changed: 5 ins; 0 del; 2 mod; 911 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsAppImageBuilder.java

33 lines changed: 13 ins; 15 del; 5 mod; 431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsDefender.java

7 lines changed: 0 ins; 3 del; 4 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsRegistry.java

123 lines changed: 36 ins; 50 del; 37 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/JPackageHelper.java

7 lines changed: 0 ins; 7 del; 0 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/ByteBuffer.cpp (was src/jdk.jpackage/windows/native/jpackage/ByteBuffer.cpp)

32 lines changed: 0 ins; 2 del; 30 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/ByteBuffer.h (was src/jdk.jpackage/windows/native/jpackage/ByteBuffer.h)

28 lines changed: 1 ins; 1 del; 26 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/IconSwap.cpp (was src/jdk.jpackage/windows/native/jpackage/IconSwap.cpp)

74 lines changed: 7 ins; 33 del; 34 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/IconSwap.h (was src/jdk.jpackage/windows/native/jpackage/IconSwap.h)

27 lines changed: 2 ins; 0 del; 25 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/native/libjpackage/Utils.cpp

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/native/libjpackage/Utils.h

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/VersionInfoSwap.cpp (was src/jdk.jpackage/windows/native/jpackage/VersionInfoSwap.cpp)

77 lines changed: 6 ins; 17 del; 54 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/VersionInfoSwap.h (was src/jdk.jpackage/windows/native/jpackage/VersionInfoSwap.h)

30 lines changed: 2 ins; 1 del; 27 mod; 22 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/native/libjpackage/WindowsRegistry.cpp

161 lines changed: 161 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/jpackage.cpp (was src/jdk.jpackage/windows/native/jpackage/jpackage.cpp)

539 lines changed: 13 ins; 508 del; 18 mod; 52 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/windows/native/jpackage/jpackage.manifest

34 lines changed: 0 ins; 34 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/windows/native/jpackage/jpackage.rc

82 lines changed: 0 ins; 82 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).