Code Review for open

Prepared by:almatvee on Thu Feb 28 20:51:04 PST 2019
Workspace:/cygdrive/e/Repositories/sandbox-2/open
Compare against: http://hg.openjdk.java.net/jdk/sandbox/
Branch:JDK-8200758-branch
Summary of changes: 424 lines changed: 96 ins; 299 del; 29 mod; 4550 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/JPackageInvalidArgTest.java

1 line changed: 0 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java

7 lines changed: 0 ins; 7 del; 0 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageArgumentsModuleTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageArgumentsTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageBuildRootTest.java

9 lines changed: 4 ins; 2 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageIconTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageInputFilesTest.java

8 lines changed: 4 ins; 2 del; 2 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageJVMArgsModuleTest.java

8 lines changed: 4 ins; 2 del; 2 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageJVMArgsTest.java

8 lines changed: 4 ins; 2 del; 2 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageMainClassAttributeTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageModularJarTest.java

8 lines changed: 4 ins; 2 del; 2 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageModuleTest.java

5 lines changed: 3 ins; 1 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageNoNameTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageRuntimeModuleTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageRuntimeTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherModuleTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageTest.java

5 lines changed: 3 ins; 1 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageVerboseTest.java

8 lines changed: 3 ins; 2 del; 3 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageVersionTest.java

8 lines changed: 4 ins; 2 del; 2 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerBase.java

1 line changed: 0 ins; 1 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerBundleNameBase.java

1 line changed: 0 ins; 1 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerFileAssociationsBase.java

1 line changed: 0 ins; 1 del; 0 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerInstallDirBase.java

1 line changed: 0 ins; 1 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerLicenseBase.java

1 line changed: 0 ins; 1 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerLicenseTypeBase.java

1 line changed: 0 ins; 1 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerMaintainerBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/linux/base/JPackageCreateInstallerPackageDepsBase.java

2 lines changed: 0 ins; 2 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerBase.java

1 line changed: 0 ins; 1 del; 0 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerFileAssociationsBase.java

1 line changed: 0 ins; 1 del; 0 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerInstallDirBase.java

1 line changed: 0 ins; 1 del; 0 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/macosx/base/JPackageCreateInstallerLicenseBase.java

1 line changed: 0 ins; 1 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerBase.java

1 line changed: 0 ins; 1 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerFileAssociationsBase.java

1 line changed: 0 ins; 1 del; 0 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerLicenseBase.java

1 line changed: 0 ins; 1 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinDirChooserBase.java

1 line changed: 0 ins; 1 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinMenuBase.java

1 line changed: 0 ins; 1 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinMenuGroupBase.java

1 line changed: 0 ins; 1 del; 0 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinPerUserInstallBase.java

1 line changed: 0 ins; 1 del; 0 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinRegistryNameBase.java

1 line changed: 0 ins; 1 del; 0 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinShortcutBase.java

1 line changed: 0 ins; 1 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerWinUpgradeUUIDBase.java

2 lines changed: 0 ins; 2 del; 0 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/JPackageHelper.java

45 lines changed: 45 ins; 0 del; 0 mod; 524 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/createimage/JPackageCreateImageOverwriteTest.java

153 lines changed: 0 ins; 153 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/createimage/JPackageCreateImageStripNativeCommandsTest.java

90 lines changed: 0 ins; 90 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).