Code Review for open

Prepared by:almatvee on Fri Jun 19 18:44:46 PDT 2020
Workspace:/Users/alexander/Repositories/jdk/jdk-jdk-2/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 432 lines changed: 243 ins; 80 del; 109 mod; 18594 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LibProvidersLookup.java

8 lines changed: 6 ins; 0 del; 2 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LinuxAppImageBuilder.java

2 lines changed: 1 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LinuxDebBundler.java

14 lines changed: 9 ins; 0 del; 5 mod; 489 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LinuxPackageBundler.java

14 lines changed: 10 ins; 0 del; 4 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LinuxRpmBundler.java

12 lines changed: 9 ins; 0 del; 3 mod; 325 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java

2 lines changed: 1 ins; 0 del; 1 mod; 828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppStoreBundler.java

14 lines changed: 7 ins; 1 del; 6 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacPkgBundler.java

17 lines changed: 13 ins; 0 del; 4 mod; 578 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/AddLauncherArguments.java

2 lines changed: 0 ins; 1 del; 1 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/AppImageBundler.java

4 lines changed: 2 ins; 0 del; 2 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/AppImageFile.java

6 lines changed: 3 ins; 1 del; 2 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Arguments.java

7 lines changed: 0 ins; 7 del; 0 mod; 829 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/BundleParams.java

9 lines changed: 2 ins; 6 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Bundler.java

2 lines changed: 0 ins; 1 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/CfgFile.java

6 lines changed: 3 ins; 0 del; 3 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/DeployParams.java

4 lines changed: 0 ins; 4 del; 0 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/FileAssociation.java

12 lines changed: 9 ins; 0 del; 3 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/IOUtils.java

11 lines changed: 9 ins; 0 del; 2 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/JLinkBundlerHelper.java

1 line changed: 0 ins; 1 del; 0 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/LauncherData.java

5 lines changed: 4 ins; 0 del; 1 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Log.java

4 lines changed: 0 ins; 3 del; 1 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/PathGroup.java

2 lines changed: 0 ins; 1 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/StandardBundlerParam.java

11 lines changed: 0 ins; 10 del; 1 mod; 542 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/ValidOptions.java

3 lines changed: 0 ins; 3 del; 0 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/main/CommandLine.java

2 lines changed: 0 ins; 1 del; 1 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/ExecutableRebrander.java

1 line changed: 0 ins; 1 del; 0 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinExeBundler.java

4 lines changed: 2 ins; 0 del; 2 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java

2 lines changed: 0 ins; 2 del; 0 mod; 559 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WindowsAppImageBuilder.java

11 lines changed: 2 ins; 7 del; 2 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WindowsRegistry.java

7 lines changed: 0 ins; 6 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WixPipeline.java

6 lines changed: 4 ins; 0 del; 2 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WixSourcesBuilder.java

19 lines changed: 15 ins; 0 del; 4 mod; 875 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WixTool.java

12 lines changed: 9 ins; 0 del; 3 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AdditionalLauncher.java

5 lines changed: 4 ins; 0 del; 1 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java

7 lines changed: 6 ins; 0 del; 1 mod; 414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java

6 lines changed: 4 ins; 0 del; 2 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java

7 lines changed: 6 ins; 0 del; 1 mod; 404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java

9 lines changed: 8 ins; 0 del; 1 mod; 926 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JarBuilder.java

3 lines changed: 0 ins; 2 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java

1 line changed: 0 ins; 1 del; 0 mod; 639 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java

17 lines changed: 15 ins; 0 del; 2 mod; 899 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestBuilder.java

9 lines changed: 7 ins; 0 del; 2 mod; 459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestInstance.java

8 lines changed: 6 ins; 0 del; 2 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java

5 lines changed: 4 ins; 0 del; 1 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/incubator/jpackage/internal/ApplicationLayoutTest.java

1 line changed: 0 ins; 0 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/incubator/jpackage/internal/CompareDottedVersionTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/incubator/jpackage/internal/DottedVersionTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/incubator/jpackage/internal/OverridableResourceTest.java

8 lines changed: 5 ins; 0 del; 3 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/incubator/jpackage/internal/PathGroupTest.java

12 lines changed: 8 ins; 1 del; 3 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/incubator/jpackage/internal/PlatformVersionTest.java

3 lines changed: 0 ins; 1 del; 2 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/incubator/jpackage/internal/ToolValidatorTest.java

3 lines changed: 2 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/ShortcutHintTest.java

5 lines changed: 2 ins; 2 del; 1 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/macosx/SigningPackageTest.java

6 lines changed: 3 ins; 0 del; 3 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AddLauncherTest.java

11 lines changed: 6 ins; 3 del; 2 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ArgumentsTest.java

5 lines changed: 2 ins; 1 del; 2 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/IconTest.java

17 lines changed: 13 ins; 1 del; 3 mod; 431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/InstallDirTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/LicenseTest.java

1 line changed: 0 ins; 1 del; 0 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/RuntimePackageTest.java

4 lines changed: 3 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/SimplePackageTest.java

2 lines changed: 0 ins; 1 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/BasicTest.java

10 lines changed: 6 ins; 1 del; 3 mod; 309 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/JLinkOptionsTest.java

1 line changed: 0 ins; 1 del; 0 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/JavaOptionsTest.java

1 line changed: 0 ins; 1 del; 0 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java

8 lines changed: 6 ins; 1 del; 1 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/ModulePathTest.java

9 lines changed: 6 ins; 1 del; 2 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/ModulePathTest2.java

3 lines changed: 0 ins; 2 del; 1 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinPerUserInstallTest.java

2 lines changed: 0 ins; 1 del; 1 mod; 61 unchg

This code review page was prepared using ../../../webrev.ksh (vers 25.18-hg+openjdk.java.net).