Code Review for hs24-b46-jdk7u40-b27

Prepared by:amurillo on Thu May 23 14:13:59 PDT 2013
Workspace:hs24-b46-jdk7u40-b27/hotspot
Compare against: jdk7u/jdk7u/hotspot
Compare against version:4512
Summary of changes: 360 lines changed: 257 ins; 37 del; 66 mod; 44859 unchg
Patch of changes: hotspot.patch
Author comments:
7066063: CMS: "Conservation Principle" assert failed
7176220: 'Full GC' events miss date stamp information occasionally
7197666: java -d64 -version core dumps in a box with lots of memory
8011891: The vm/gc/heap/heap_summary_after_gc event for CMS contains old data
8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
8013934: Garbage collection event for CMS has wrong cause for System.gc()
8014611: reserve_and_align() assumptions are invalid on windows
8014759: new hotspot build - hs24-b46
8014941: make jdk7u40 the default jprt release for hs24
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw .hgtags

rev 4527 : Added tag hs24-b46 for changeset e50c5a1869b1
2 lines changed: 2 ins; 0 del; 0 mod; 501 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot_version

rev 4514 : 8014759: new hotspot build - hs24-b46
Reviewed-by: jcoomes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/jprt.properties

rev 4519 : 8014941: make jdk7u40 the default jprt release for hs24
Reviewed-by: dholmes, collins
23 lines changed: 0 ins; 0 del; 23 mod; 521 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/posix/vm/os_posix.cpp

rev 4525 : 8014611: reserve_and_align() assumptions are invalid on windows
Summary: also reviewed by ron.durbin@oracle.com, thomas.schatzl@oracle.com
Reviewed-by: dcubed, brutisso
4 lines changed: 4 ins; 0 del; 0 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/windows/vm/os_windows.cpp

rev 4525 : 8014611: reserve_and_align() assumptions are invalid on windows
Summary: also reviewed by ron.durbin@oracle.com, thomas.schatzl@oracle.com
Reviewed-by: dcubed, brutisso
4 lines changed: 4 ins; 0 del; 0 mod; 5496 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp

rev 4520 : 7066063: CMS: "Conservation Principle" assert failed
Summary: Add call to coalBirth() in CompactibleFreeListSpace::reset()
Reviewed-by: ysr, jmasa
1 line changed: 1 ins; 0 del; 0 mod; 3033 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
rev 4516 : 8011891: The vm/gc/heap/heap_summary_after_gc event for CMS contains old data
Reviewed-by: brutisso, stefank
rev 4517 : Merge
rev 4518 : 8013934: Garbage collection event for CMS has wrong cause for System.gc()
Reviewed-by: brutisso, jwilhelm
rev 4521 : 8011891: The vm/gc/heap/heap_summary_after_gc event for CMS contains old data
Reviewed-by: brutisso, stefank
19 lines changed: 11 ins; 1 del; 7 mod; 9421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp

rev 4518 : 8013934: Garbage collection event for CMS has wrong cause for System.gc()
Reviewed-by: brutisso, jwilhelm
6 lines changed: 1 ins; 0 del; 5 mod; 1924 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp

rev 4518 : 8013934: Garbage collection event for CMS has wrong cause for System.gc()
Reviewed-by: brutisso, jwilhelm
3 lines changed: 2 ins; 0 del; 1 mod; 381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp

rev 4518 : 8013934: Garbage collection event for CMS has wrong cause for System.gc()
Reviewed-by: brutisso, jwilhelm
1 line changed: 0 ins; 0 del; 1 mod; 309 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
1 line changed: 0 ins; 1 del; 0 mod; 6561 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/vm_operations_g1.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
1 line changed: 0 ins; 1 del; 0 mod; 262 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
1 line changed: 0 ins; 1 del; 0 mod; 696 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
1 line changed: 0 ins; 1 del; 0 mod; 3518 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
1 line changed: 0 ins; 1 del; 0 mod; 861 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/gcTrace.cpp

rev 4524 : 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
Reviewed-by: brutisso, jwilhelm
37 lines changed: 20 ins; 9 del; 8 mod; 187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/gcTrace.hpp

rev 4524 : 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
Reviewed-by: brutisso, jwilhelm
28 lines changed: 28 ins; 0 del; 0 mod; 236 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/gcTraceTime.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
4 lines changed: 0 ins; 2 del; 2 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/allocation.hpp

rev 4523 : 7197666: java -d64 -version core dumps in a box with lots of memory
Summary: Allow task queues to be mmapped instead of malloced on Solaris
Reviewed-by: coleenp, jmasa, johnc, tschatzl
19 lines changed: 19 ins; 0 del; 0 mod; 558 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/allocation.inline.hpp

rev 4523 : 7197666: java -d64 -version core dumps in a box with lots of memory
Summary: Allow task queues to be mmapped instead of malloced on Solaris
Reviewed-by: coleenp, jmasa, johnc, tschatzl
44 lines changed: 44 ins; 0 del; 0 mod; 107 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/genCollectedHeap.cpp

rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa
1 line changed: 0 ins; 1 del; 0 mod; 1454 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/heapInspection.cpp

rev 4524 : 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
Reviewed-by: brutisso, jwilhelm
27 lines changed: 13 ins; 8 del; 6 mod; 345 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/heapInspection.hpp

rev 4524 : 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
Reviewed-by: brutisso, jwilhelm
13 lines changed: 3 ins; 7 del; 3 mod; 130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

rev 4523 : 7197666: java -d64 -version core dumps in a box with lots of memory
Summary: Allow task queues to be mmapped instead of malloced on Solaris
Reviewed-by: coleenp, jmasa, johnc, tschatzl
rev 4524 : 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
Reviewed-by: brutisso, jwilhelm
9 lines changed: 9 ins; 0 del; 0 mod; 3700 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/os.cpp

rev 4525 : 8014611: reserve_and_align() assumptions are invalid on windows
Summary: also reviewed by ron.durbin@oracle.com, thomas.schatzl@oracle.com
Reviewed-by: dcubed, brutisso
6 lines changed: 6 ins; 0 del; 0 mod; 1499 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/os.hpp

rev 4525 : 8014611: reserve_and_align() assumptions are invalid on windows
Summary: also reviewed by ron.durbin@oracle.com, thomas.schatzl@oracle.com
Reviewed-by: dcubed, brutisso
2 lines changed: 2 ins; 0 del; 0 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/virtualspace.cpp

rev 4525 : 8014611: reserve_and_align() assumptions are invalid on windows
Summary: also reviewed by ron.durbin@oracle.com, thomas.schatzl@oracle.com
Reviewed-by: dcubed, brutisso
48 lines changed: 36 ins; 4 del; 8 mod; 880 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/virtualspace.hpp

rev 4525 : 8014611: reserve_and_align() assumptions are invalid on windows
Summary: also reviewed by ron.durbin@oracle.com, thomas.schatzl@oracle.com
Reviewed-by: dcubed, brutisso
15 lines changed: 15 ins; 0 del; 0 mod; 232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/taskqueue.hpp

rev 4523 : 7197666: java -d64 -version core dumps in a box with lots of memory
Summary: Allow task queues to be mmapped instead of malloced on Solaris
Reviewed-by: coleenp, jmasa, johnc, tschatzl
2 lines changed: 1 ins; 0 del; 1 mod; 813 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/share/vm/memory/klassInfoClosure.hpp

rev 4524 : 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
Reviewed-by: brutisso, jwilhelm
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/jdk/bin/webrev (vers 23.18-hg).