Print this page
rev 4515 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa

Split Split Close
Expand all
Collapse all
          --- old/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
          +++ new/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
↓ open down ↓ 1302 lines elided ↑ open up ↑
1303 1303    const bool do_clear_all_soft_refs = clear_all_soft_refs ||
1304 1304                             collector_policy()->should_clear_all_soft_refs();
1305 1305  
1306 1306    ClearedAllSoftRefs casr(do_clear_all_soft_refs, collector_policy());
1307 1307  
1308 1308    {
1309 1309      IsGCActiveMark x;
1310 1310  
1311 1311      // Timing
1312 1312      assert(gc_cause() != GCCause::_java_lang_system_gc || explicit_gc, "invariant");
1313      -    gclog_or_tty->date_stamp(G1Log::fine() && PrintGCDateStamps);
1314 1313      TraceCPUTime tcpu(G1Log::finer(), true, gclog_or_tty);
1315 1314  
1316 1315      {
1317 1316        GCTraceTime t(GCCauseString("Full GC", gc_cause()), G1Log::fine(), true, NULL);
1318 1317        TraceCollectorStats tcs(g1mm()->full_collection_counters());
1319 1318        TraceMemoryManagerStats tms(true /* fullGC */, gc_cause());
1320 1319  
1321 1320        double start = os::elapsedTime();
1322 1321        g1_policy()->record_full_collection_start();
1323 1322  
↓ open down ↓ 5239 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX