Code Review for hs24-b54-jdk7u40-b35

Prepared by:amurillo on Fri Jul 19 06:06:13 PDT 2013
Workspace:hs24-b54-jdk7u40-b35/hotspot
Compare against: jdk7u/jdk7u40/hotspot
Compare against version:4636
Summary of changes: 1017 lines changed: 881 ins; 78 del; 58 mod; 44692 unchg
Patch of changes: hotspot.patch
Author comments:
7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
8007898: Incorrect optimization of Memory Barriers in Matcher::post_store_load_barrier()
8011569: ARM -- avoid native stack walking
8012241: NMT huge memory footprint, it usually leads to OOME
8015576: CMS: svc agent throws java.lang.RuntimeException: No type named "FreeList" in database
8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
8020155: PSR:PERF G1 not collecting old regions when humongous allocations interfer
8020215: Different execution plan when using JIT vs interpreter
8020381: new hotspot build - hs24-b54
8020425: Product options incorrectly removed in minor version
8020433: Crash when using -XX:+RestoreMXCSROnJNICalls
8020547: Event based tracing needs a UNICODE string type
8020701: Avoid crashes in WatcherThread
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw .hgtags

rev 4656 : Added tag hs24-b54 for changeset f969880098fd
2 lines changed: 2 ins; 0 del; 0 mod; 517 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java

rev 4653 : 8015576: CMS: svc agent throws java.lang.RuntimeException: No type named "FreeList" in database
Summary: Need to rename some variables in svc code after fix JDK-7131629.
Reviewed-by: poonam, dholmes
2 lines changed: 0 ins; 0 del; 2 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/memory/FreeList.java

rev 4653 : 8015576: CMS: svc agent throws java.lang.RuntimeException: No type named "FreeList" in database
Summary: Need to rename some variables in svc code after fix JDK-7131629.
Reviewed-by: poonam, dholmes
1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot_version

rev 4638 : 8020381: new hotspot build - hs24-b54
Reviewed-by: jcoomes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/linux/makefiles/vm.make

rev 4648 : 8011569: ARM -- avoid native stack walking
Summary: ARM compilers do not emit FramePointer on each native frame by default
Reviewed-by: dholmes, kvn
3 lines changed: 2 ins; 0 del; 1 mod; 390 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/frame_sparc.inline.hpp

rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
2 lines changed: 0 ins; 0 del; 2 mod; 302 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/frame_x86.inline.hpp

rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
3 lines changed: 0 ins; 1 del; 2 mod; 303 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/stubGenerator_x86_64.cpp

rev 4643 : 8020433: Crash when using -XX:+RestoreMXCSROnJNICalls
Summary: remove StubRoutines::x86::_mxcsr_std and use StubRoutines::_mxcsr_std
Reviewed-by: jrose
29 lines changed: 24 ins; 0 del; 5 mod; 3830 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/stubRoutines_x86_64.cpp

rev 4643 : 8020433: Crash when using -XX:+RestoreMXCSROnJNICalls
Summary: remove StubRoutines::x86::_mxcsr_std and use StubRoutines::_mxcsr_std
Reviewed-by: jrose
1 line changed: 0 ins; 1 del; 0 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/stubRoutines_x86_64.hpp

rev 4643 : 8020433: Crash when using -XX:+RestoreMXCSROnJNICalls
Summary: remove StubRoutines::x86::_mxcsr_std and use StubRoutines::_mxcsr_std
Reviewed-by: jrose
6 lines changed: 0 ins; 6 del; 0 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/bsd/vm/attachListener_bsd.cpp

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
25 lines changed: 24 ins; 0 del; 1 mod; 524 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/linux/vm/attachListener_linux.cpp

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
25 lines changed: 24 ins; 0 del; 1 mod; 510 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/posix/vm/os_posix.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
49 lines changed: 49 ins; 0 del; 0 mod; 195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/posix/vm/os_posix.hpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
19 lines changed: 19 ins; 0 del; 0 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/solaris/vm/attachListener_solaris.cpp

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
25 lines changed: 24 ins; 0 del; 1 mod; 704 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/windows/vm/attachListener_windows.cpp

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
5 lines changed: 4 ins; 0 del; 1 mod; 402 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/windows/vm/os_windows.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
28 lines changed: 28 ins; 0 del; 0 mod; 5558 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/windows/vm/os_windows.hpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
14 lines changed: 14 ins; 0 del; 0 mod; 256 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
4 lines changed: 4 ins; 0 del; 0 mod; 1133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
4 lines changed: 4 ins; 0 del; 0 mod; 761 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os_cpu/linux_x86/vm/os_linux_x86.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
4 lines changed: 4 ins; 0 del; 0 mod; 871 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
4 lines changed: 4 ins; 0 del; 0 mod; 808 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
4 lines changed: 4 ins; 0 del; 0 mod; 946 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/bcEscapeAnalyzer.cpp

rev 4641 : 8020215: Different execution plan when using JIT vs interpreter
Summary: fix bytecode analyzer
Reviewed-by: twisti
15 lines changed: 15 ins; 0 del; 0 mod; 1468 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/bcEscapeAnalyzer.hpp

rev 4641 : 8020215: Different execution plan when using JIT vs interpreter
Summary: fix bytecode analyzer
Reviewed-by: twisti
1 line changed: 1 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp

rev 4640 : 8020155: PSR:PERF G1 not collecting old regions when humongous allocations interfer
Summary: Take _last_young_gc into account when deciding on starting a concurrent mark. Also reviewed-by: per.liden@oracle.com.
Reviewed-by: tschatzl, johnc
2 lines changed: 0 ins; 0 del; 2 mod; 2234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/matcher.cpp

rev 4642 : 8007898: Incorrect optimization of Memory Barriers in Matcher::post_store_load_barrier()
Summary: generate one "fat" membar instead of set of barriers for volitile store
Reviewed-by: roland
46 lines changed: 11 ins; 12 del; 23 mod; 2389 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/parse3.cpp

rev 4642 : 8007898: Incorrect optimization of Memory Barriers in Matcher::post_store_load_barrier()
Summary: generate one "fat" membar instead of set of barriers for volitile store
Reviewed-by: roland
19 lines changed: 0 ins; 18 del; 1 mod; 516 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/forte.cpp

rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
7 lines changed: 5 ins; 0 del; 2 mod; 651 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

rev 4644 : 8020425: Product options incorrectly removed in minor version
Summary: give warning and ignore product flags which were removed in hs24
Reviewed-by: twisti
21 lines changed: 21 ins; 0 del; 0 mod; 3418 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/frame.cpp

rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
12 lines changed: 11 ins; 0 del; 1 mod; 1506 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/frame.hpp

rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
3 lines changed: 2 ins; 0 del; 1 mod; 562 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/javaCalls.hpp

rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
2 lines changed: 2 ins; 0 del; 0 mod; 229 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/mutex.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
4 lines changed: 4 ins; 0 del; 0 mod; 1387 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/os.cpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
16 lines changed: 16 ins; 0 del; 0 mod; 1527 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/os.hpp

rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
8 lines changed: 8 ins; 0 del; 0 mod; 933 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.cpp

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
rev 4647 : Merge
rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
10 lines changed: 9 ins; 0 del; 1 mod; 4633 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.hpp

rev 4646 : 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
rev 4652 : 8020701: Avoid crashes in WatcherThread
Reviewed-by: acorn, dcubed, dsimms
13 lines changed: 13 ins; 0 del; 0 mod; 1955 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/attachListener.hpp

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
1 line changed: 1 ins; 0 del; 0 mod; 147 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/memTracker.cpp

rev 4639 : 8012241: NMT huge memory footprint, it usually leads to OOME
Summary: Enforce memory limitation on NMT to prevent JVM OOM
Reviewed-by: acorn, dcubed, minqi
rev 4648 : 8011569: ARM -- avoid native stack walking
Summary: ARM compilers do not emit FramePointer on each native frame by default
Reviewed-by: dholmes, kvn
rev 4649 : Merge
10 lines changed: 7 ins; 0 del; 3 mod; 876 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/trace/traceDataTypes.hpp

rev 4651 : 8020547: Event based tracing needs a UNICODE string type
Reviewed-by: egahlin, rbackman, dcubed, brutisso, acorn
3 lines changed: 2 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/trace/tracetypes.xml

rev 4651 : 8020547: Event based tracing needs a UNICODE string type
Reviewed-by: egahlin, rbackman, dcubed, brutisso, acorn
21 lines changed: 4 ins; 16 del; 1 mod; 351 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/trace/xinclude.mod

rev 4651 : 8020547: Event based tracing needs a UNICODE string type
Reviewed-by: egahlin, rbackman, dcubed, brutisso, acorn
24 lines changed: 0 ins; 24 del; 0 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/globalDefinitions.hpp

rev 4648 : 8011569: ARM -- avoid native stack walking
Summary: ARM compilers do not emit FramePointer on each native frame by default
Reviewed-by: dholmes, kvn
4 lines changed: 0 ins; 0 del; 4 mod; 1243 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/compiler/EscapeAnalysis/Test8020215.java

rev 4641 : 8020215: Different execution plan when using JIT vs interpreter
Summary: fix bytecode analyzer
Reviewed-by: twisti
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/compiler/cpuflags/RestoreMXCSR.java

rev 4643 : 8020433: Crash when using -XX:+RestoreMXCSROnJNICalls
Summary: remove StubRoutines::x86::_mxcsr_std and use StubRoutines::_mxcsr_std
Reviewed-by: jrose
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/compiler/membars/DekkerTest.java

rev 4642 : 8007898: Incorrect optimization of Memory Barriers in Matcher::post_store_load_barrier()
Summary: generate one "fat" membar instead of set of barriers for volitile store
Reviewed-by: roland
163 lines changed: 163 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/serviceability/attach/AttachWithStalePidFile.java

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/serviceability/attach/AttachWithStalePidFileTarget.java

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary/com/oracle/java/testlibrary/Platform.java

rev 4645 : 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand
Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/jdk/bin/webrev (vers 23.18-hg).