Code Review for hs25.20-b02-jdk8u20-b01

Prepared by:amurillo on Thu Jan 30 14:15:33 PST 2014
Workspace:hs25.20-b02-jdk8u20-b01/hotspot
Compare against: jdk8u/jdk8u/hotspot
Compare against version:5790
Summary of changes: 705 lines changed: 462 ins; 163 del; 80 mod; 24831 unchg
Patch of changes: hotspot.patch
Author comments:
8027364: PSScavenge accounts too large code section to StringTable unlink
8027454: Do not traverse string table during G1 remark when treating them as strong roots during initial mark
8027455: Improve symbol table scan times during gc pauses
8027476: Improve performance of Stringtable unlink
8027746: Remove do_gen_barrier template parameter in G1ParCopyClosure
8028553: The JVM should not throw VerifyError when 'overriding' a static final method in a superclass.
8030027: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Linux-amd64: SIGSEGV in JavaThread::last_java_vframe(RegisterMap*)+0xfa
8030955: assert(_prologue != NULL) failed: prologue pointer must be initialized
8031045: Access checks should precede additional per-instruction checks
8032014: new hotspot build - hs25.20-b02
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw .hgtags

rev 5801 : Added tag hs25.20-b02 for changeset 4638c4d7ff10
1 line changed: 1 ins; 0 del; 0 mod; 413 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot_version

rev 5791 : 8032014: new hotspot build - hs25.20-b02
Reviewed-by: jcoomes
3 lines changed: 0 ins; 0 del; 3 mod; 42 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classFileParser.cpp

rev 5800 : 8028553: The JVM should not throw VerifyError when 'overriding' a static final method in a superclass.
Summary: Check if method is static before throwing exception.
Reviewed-by: kamg, coleenp, lfoltan, fparain
3 lines changed: 0 ins; 0 del; 3 mod; 5143 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/symbolTable.cpp

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
119 lines changed: 77 ins; 14 del; 28 mod; 962 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/symbolTable.hpp

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
41 lines changed: 33 ins; 1 del; 7 mod; 345 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/bufferingOopClosure.hpp

rev 5796 : 8027746: Remove do_gen_barrier template parameter in G1ParCopyClosure
Summary: Remove the above mentioned template parameter and related unused code. Also remove some classes that are never used.
Reviewed-by: stefank, mgerdin, jwilhelm
112 lines changed: 0 ins; 112 del; 0 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/concurrentMark.cpp

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
rev 5795 : 8027454: Do not traverse string table during G1 remark when treating them as strong roots during initial mark
Summary: Do not try to unlink string table entries unconditionally during remark. This is without side effects as the preceding initial mark always uses the string table as strong roots. Needs to be fixed with class unloading during concurrent mark.
Reviewed-by: brutisso, mgerdin
5 lines changed: 0 ins; 2 del; 3 mod; 4690 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
rev 5796 : 8027746: Remove do_gen_barrier template parameter in G1ParCopyClosure
Summary: Remove the above mentioned template parameter and related unused code. Also remove some classes that are never used.
Reviewed-by: stefank, mgerdin, jwilhelm
121 lines changed: 94 ins; 14 del; 13 mod; 6842 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
rev 5796 : 8027746: Remove do_gen_barrier template parameter in G1ParCopyClosure
Summary: Remove the above mentioned template parameter and related unused code. Also remove some classes that are never used.
Reviewed-by: stefank, mgerdin, jwilhelm
5 lines changed: 4 ins; 0 del; 1 mod; 2100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1MarkSweep.cpp

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
5 lines changed: 0 ins; 3 del; 2 mod; 365 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1OopClosures.hpp

rev 5796 : 8027746: Remove do_gen_barrier template parameter in G1ParCopyClosure
Summary: Remove the above mentioned template parameter and related unused code. Also remove some classes that are never used.
Reviewed-by: stefank, mgerdin, jwilhelm
14 lines changed: 0 ins; 6 del; 8 mod; 309 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1_globals.hpp

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
3 lines changed: 3 ins; 0 del; 0 mod; 329 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp

rev 5796 : 8027746: Remove do_gen_barrier template parameter in G1ParCopyClosure
Summary: Remove the above mentioned template parameter and related unused code. Also remove some classes that are never used.
Reviewed-by: stefank, mgerdin, jwilhelm
3 lines changed: 0 ins; 1 del; 2 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

rev 5793 : 8027364: PSScavenge accounts too large code section to StringTable unlink
Summary: Correct timing measurement by modifying the scope of the GCTraceTime instance.
Reviewed-by: ysr, tamao
Contributed-by: Jeremy Manson <jeremymanson@google.com>
7 lines changed: 2 ins; 0 del; 5 mod; 855 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.cpp

rev 5797 : 8031045: Access checks should precede additional per-instruction checks
Summary: Move access check above the check for non-static method
Reviewed-by: lfoltan, coleenp
20 lines changed: 9 ins; 10 del; 1 mod; 1659 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvmtiEnvThreadState.cpp

rev 5799 : 8030027: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Linux-amd64: SIGSEGV in JavaThread::last_java_vframe(RegisterMap*)+0xfa
Summary: Add a safe guard to VMOp_GetCurrentLocation against non-walkable stack of target thread exiting from Java execution
Reviewed-by: mgronlun, dholmes, sla, dcubed
Contributed-by: serguei.spitsyn@oracle.com
2 lines changed: 0 ins; 0 del; 2 mod; 333 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/perfMemory.cpp

rev 5792 : 8030955: assert(_prologue != NULL) failed: prologue pointer must be initialized
Summary: Return immediately if _prologue == NULL, instead of asserting
Reviewed-by: ccheung, coleenp
2 lines changed: 0 ins; 0 del; 2 mod; 263 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/gc/g1/TestStringSymbolTableStats.java

rev 5794 : 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses
Summary: Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.
Reviewed-by: mgerdin, coleenp, brutisso
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/runtime/PerfMemDestroy/PerfMemDestroy.java

rev 5792 : 8030955: assert(_prologue != NULL) failed: prologue pointer must be initialized
Summary: Return immediately if _prologue == NULL, instead of asserting
Reviewed-by: ccheung, coleenp
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/runtime/finalStatic/FinalStatic.java

rev 5800 : 8028553: The JVM should not throw VerifyError when 'overriding' a static final method in a superclass.
Summary: Check if method is static before throwing exception.
Reviewed-by: kamg, coleenp, lfoltan, fparain
142 lines changed: 142 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/jdk/bin/webrev (vers 23.18-hg).