Code Review for hs25.60-b02-jdk8u60-b01

Prepared by:amurillo on Fri Jan 23 15:32:08 PST 2015
Workspace:hs25.60-b02/hs25.60-b02-jdk8u60-b01
Compare against: jdk8u/jdk8u
Summary of changes: 1022 lines changed: 550 ins; 441 del; 31 mod; 55282 unchg
Patch of changes: hs25.60-b02-jdk8u60-b01.patch
Author comments:
8043340: [macosx] Fix hard-wired paths to JavaVM.framework
8048050: Agent NullPointerException when rmi.port in use
8062063: Usage of UseHugeTLBFS, UseLargePagesInMetaspace and huge SurvivorAlignmentInBytes cause crashes in CMBitMapClosure::do_bit
8066763: fatal error "assert(false) failed: unexpected yanked node" in postaloc.cpp:139
8068678: new hotspot build - hs25.60-b02
8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw jdk/make/lib/Awt2dLibraries.gmk

rev 10447 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
18 lines changed: 0 ins; 15 del; 3 mod; 1493 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw jdk/make/lib/PlatformLibraries.gmk

rev 10447 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
12 lines changed: 0 ins; 9 del; 3 mod; 222 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw jdk/src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java

rev 10448 : 8048050: Agent NullPointerException when rmi.port in use
Reviewed-by: jbachorik, dfuchs
1 line changed: 0 ins; 0 del; 1 mod; 815 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw ./common/autoconf/basics.m4

rev 1274 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
11 lines changed: 6 ins; 4 del; 1 mod; 744 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw ./common/autoconf/generated-configure.sh

rev 1274 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
rev 1275 : Merge
561 lines changed: 185 ins; 370 del; 6 mod; 37404 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw ./common/autoconf/hotspot-spec.gmk.in

rev 1274 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
3 lines changed: 3 ins; 0 del; 0 mod; 137 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw ./common/autoconf/jdk-options.m4

rev 1274 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
rev 1275 : Merge
1 line changed: 0 ins; 0 del; 1 mod; 609 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw ./common/autoconf/libraries.m4

rev 1274 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
15 lines changed: 0 ins; 13 del; 2 mod; 874 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw ./common/autoconf/spec.gmk.in

rev 1274 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
10 lines changed: 7 ins; 2 del; 1 mod; 674 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw ./common/autoconf/toolchain.m4

rev 1274 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj
90 lines changed: 84 ins; 5 del; 1 mod; 1228 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/.hgtags

rev 7085 : Added tag hs25.60-b02 for changeset 5fa73007ceb9
1 line changed: 1 ins; 0 del; 0 mod; 589 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m

rev 7080 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj, dholmes
2 lines changed: 0 ins; 0 del; 2 mod; 842 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/agent/src/os/bsd/Makefile

rev 7080 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj, dholmes
3 lines changed: 0 ins; 0 del; 3 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/make/bsd/makefiles/saproc.make

rev 7080 : 8043340: [macosx] Fix hard-wired paths to JavaVM.framework
Summary: Build system tweaks to allow building on OS X 10.9 and later
Reviewed-by: erikj, dholmes
24 lines changed: 14 ins; 6 del; 4 mod; 156 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/make/hotspot_version

rev 7076 : 8068678: new hotspot build - hs25.60-b02
Reviewed-by: jcoomes
rev 7084 : Merge
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/chaitin.cpp

rev 7082 : 8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
Summary: Use MachMerge to hook together defs of the same multidef value in a block
Reviewed-by: kvn, vlivanov
3 lines changed: 3 ins; 0 del; 0 mod; 2347 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/chaitin.hpp

rev 7082 : 8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
Summary: Use MachMerge to hook together defs of the same multidef value in a block
Reviewed-by: kvn, vlivanov
26 lines changed: 26 ins; 0 del; 0 mod; 625 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/lcm.cpp

rev 7077 : 8066763: fatal error "assert(false) failed: unexpected yanked node" in postaloc.cpp:139
Summary: Check for dead input nodes after replacing compare node with implicit null check.
Reviewed-by: kvn
8 lines changed: 7 ins; 0 del; 1 mod; 1160 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/machnode.hpp

rev 7082 : 8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
Summary: Use MachMerge to hook together defs of the same multidef value in a block
Reviewed-by: kvn, vlivanov
23 lines changed: 23 ins; 0 del; 0 mod; 973 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/node.hpp

rev 7082 : 8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
Summary: Use MachMerge to hook together defs of the same multidef value in a block
Reviewed-by: kvn, vlivanov
3 lines changed: 3 ins; 0 del; 0 mod; 1596 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/phase.cpp

rev 7082 : 8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
Summary: Use MachMerge to hook together defs of the same multidef value in a block
Reviewed-by: kvn, vlivanov
3 lines changed: 2 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/phase.hpp

rev 7082 : 8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
Summary: Use MachMerge to hook together defs of the same multidef value in a block
Reviewed-by: kvn, vlivanov
1 line changed: 1 ins; 0 del; 0 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/postaloc.cpp

rev 7082 : 8068881: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions.<init>
Summary: Use MachMerge to hook together defs of the same multidef value in a block
Reviewed-by: kvn, vlivanov
102 lines changed: 88 ins; 14 del; 0 mod; 701 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/stringopts.cpp

rev 7079 : 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
Reviewed-by: kvn
11 lines changed: 8 ins; 3 del; 0 mod; 1644 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/stringopts/TestOptimizeStringConcat.java

rev 7079 : 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
Reviewed-by: kvn
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/pub/bin/webrev (vers 25.6-hg+openjdk.java.net).