Print this page
rev 7125 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: brutisso, tschatzl

Split Split Close
Expand all
Collapse all
          --- old/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
          +++ new/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
↓ open down ↓ 1289 lines elided ↑ open up ↑
1290 1290    const bool do_clear_all_soft_refs = clear_all_soft_refs ||
1291 1291                             collector_policy()->should_clear_all_soft_refs();
1292 1292  
1293 1293    ClearedAllSoftRefs casr(do_clear_all_soft_refs, collector_policy());
1294 1294  
1295 1295    {
1296 1296      IsGCActiveMark x;
1297 1297  
1298 1298      // Timing
1299 1299      assert(gc_cause() != GCCause::_java_lang_system_gc || explicit_gc, "invariant");
1300      -    gclog_or_tty->date_stamp(G1Log::fine() && PrintGCDateStamps);
1301 1300      TraceCPUTime tcpu(G1Log::finer(), true, gclog_or_tty);
1302 1301  
1303 1302      {
1304 1303        GCTraceTime t(GCCauseString("Full GC", gc_cause()), G1Log::fine(), true, NULL, gc_tracer->gc_id());
1305 1304        TraceCollectorStats tcs(g1mm()->full_collection_counters());
1306 1305        TraceMemoryManagerStats tms(true /* fullGC */, gc_cause());
1307 1306  
1308 1307        double start = os::elapsedTime();
1309 1308        g1_policy()->record_full_collection_start();
1310 1309  
↓ open down ↓ 5728 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX