rev 7125 : 7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: brutisso, tschatzl

          --- old/hotspot/src/share/vm/gc_implementation/shared/gcTraceTime.cpp
          +++ new/hotspot/src/share/vm/gc_implementation/shared/gcTraceTime.cpp

   1    1  /*
   2    2   * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
   3    3   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   4    4   *
   5    5   * This code is free software; you can redistribute it and/or modify it
   6    6   * under the terms of the GNU General Public License version 2 only, as
   7    7   * published by the Free Software Foundation.
   8    8   *
   9    9   * This code is distributed in the hope that it will be useful, but WITHOUT
  10   10   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  11   11   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
  12   12   * version 2 for more details (a copy is included in the LICENSE file that
  13   13   * accompanied this code).
  14   14   *
  15   15   * You should have received a copy of the GNU General Public License version
  16   16   * 2 along with this work; if not, write to the Free Software Foundation,
  17   17   * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  18   18   *
  19   19   * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
  20   20   * or visit www.oracle.com if you need additional information or have any
  21   21   * questions.
  22   22   *
  23   23   */
  24   24  
  25   25  #include "precompiled.hpp"
  26   26  #include "gc_implementation/shared/gcTimer.hpp"
  27   27  #include "gc_implementation/shared/gcTrace.hpp"
  28   28  #include "gc_implementation/shared/gcTraceTime.hpp"
  29   29  #include "runtime/globals.hpp"
  30   30  #include "runtime/os.hpp"
  31   31  #include "runtime/safepoint.hpp"
  32   32  #include "runtime/thread.inline.hpp"
  33   33  #include "runtime/timer.hpp"
  34   34  #include "utilities/ostream.hpp"
  35   35  #include "utilities/ticks.inline.hpp"
  36   36  
  37   37  
  38   38  GCTraceTime::GCTraceTime(const char* title, bool doit, bool print_cr, GCTimer* timer, GCId gc_id) :
  39   39      _title(title), _doit(doit), _print_cr(print_cr), _timer(timer), _start_counter() {
  40   40    if (_doit || _timer != NULL) {
  41   41      _start_counter.stamp();

  42   42    }
  43   43  
  44   44    if (_timer != NULL) {
  45   45      assert(SafepointSynchronize::is_at_safepoint(), "Tracing currently only supported at safepoints");
  46   46      assert(Thread::current()->is_VM_thread(), "Tracing currently only supported from the VM thread");
  47   47  
  48   48      _timer->register_gc_phase_start(title, _start_counter);
  49   49    }
  50   50  
  51   51    if (_doit) {
  52      -    if (PrintGCTimeStamps) {
  53      -      gclog_or_tty->stamp();
  54      -      gclog_or_tty->print(": ");
  55      -    }
       52 +    gclog_or_tty->date_stamp(PrintGCDateStamps);
       53 +    gclog_or_tty->stamp(PrintGCTimeStamps);
  56   54      if (PrintGCID) {
  57   55        gclog_or_tty->print("#%u: ", gc_id.id());
  58   56      }
  59   57      gclog_or_tty->print("[%s", title);
  60   58      gclog_or_tty->flush();
  61   59    }
  62   60  }
  63   61  
  64   62  GCTraceTime::~GCTraceTime() {
  65   63    Ticks stop_counter;

  66   64  
  67   65    if (_doit || _timer != NULL) {
  68   66      stop_counter.stamp();
  69   67    }
  70   68  
  71   69    if (_timer != NULL) {
  72   70      _timer->register_gc_phase_end(stop_counter);
  73   71    }
  74   72  
  75   73    if (_doit) {
  76   74      const Tickspan duration = stop_counter - _start_counter;
  77   75      double duration_in_seconds = TicksToTimeHelper::seconds(duration);
  78   76      if (_print_cr) {
  79   77        gclog_or_tty->print_cr(", %3.7f secs]", duration_in_seconds);
  80   78      } else {
  81   79        gclog_or_tty->print(", %3.7f secs]", duration_in_seconds);
  82   80      }
  83   81      gclog_or_tty->flush();
  84   82    }
  85   83  }

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX