Code Review for jdk

Prepared by:andrew on Wed Sep 17 18:06:29 BST 2014
Workspace:/home/andrew/projects/openjdk/upstream/jdk7/jdk
Compare against: ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/
Compare against version:7430
Summary of changes: 1000 lines changed: 365 ins; 463 del; 172 mod; 12135 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/HmacCore.java

138 lines changed: 17 ins; 100 del; 21 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/HmacMD5.java

89 lines changed: 0 ins; 86 del; 3 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java

75 lines changed: 0 ins; 69 del; 6 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/HmacSHA1.java

89 lines changed: 0 ins; 86 del; 3 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java

46 lines changed: 1 ins; 22 del; 23 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/OAEPParameters.java

3 lines changed: 2 ins; 0 del; 1 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/SunJCE.java

31 lines changed: 26 ins; 0 del; 5 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/security/spec/MGF1ParameterSpec.java

2 lines changed: 1 ins; 0 del; 1 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/security/spec/PSSParameterSpec.java

2 lines changed: 1 ins; 0 del; 1 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/ec/ECDSASignature.java

9 lines changed: 8 ins; 0 del; 1 mod; 421 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/ec/SunECEntries.java

16 lines changed: 15 ins; 0 del; 1 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/P11Digest.java

4 lines changed: 3 ins; 0 del; 1 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/P11Mac.java

6 lines changed: 3 ins; 0 del; 3 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/P11Signature.java

10 lines changed: 10 ins; 0 del; 0 mod; 735 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/SunPKCS11.java

27 lines changed: 26 ins; 0 del; 1 mod; 1401 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/Functions.java

6 lines changed: 5 ins; 0 del; 1 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/DigestBase.java

21 lines changed: 0 ins; 15 del; 6 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/MD2.java

12 lines changed: 0 ins; 3 del; 9 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/MD4.java

14 lines changed: 3 ins; 7 del; 4 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/MD5.java

14 lines changed: 3 ins; 7 del; 4 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/SHA.java

15 lines changed: 3 ins; 8 del; 4 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/SHA2.java

65 lines changed: 38 ins; 20 del; 7 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/SHA5.java

36 lines changed: 7 ins; 27 del; 2 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/SunEntries.java

16 lines changed: 14 ins; 0 del; 2 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/rsa/RSASignature.java

10 lines changed: 7 ins; 0 del; 3 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/rsa/SunRsaSignEntries.java

7 lines changed: 6 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/AlgorithmId.java

25 lines changed: 20 ins; 0 del; 5 mod; 955 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/windows/classes/sun/security/mscapi/RSASignature.java

11 lines changed: 9 ins; 0 del; 2 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/windows/classes/sun/security/mscapi/SunMSCAPI.java

17 lines changed: 14 ins; 0 del; 3 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/com/sun/crypto/provider/Cipher/RSA/TestOAEP.java

15 lines changed: 14 ins; 0 del; 1 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/com/sun/crypto/provider/Cipher/RSA/TestOAEPParameterSpec.java

2 lines changed: 1 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/com/sun/crypto/provider/Cipher/RSA/TestOAEPWithParams.java

3 lines changed: 0 ins; 0 del; 3 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/com/sun/crypto/provider/KeyGenerator/Test4628062.java

52 lines changed: 27 ins; 9 del; 16 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/com/sun/crypto/provider/Mac/MacClone.java

40 lines changed: 31 ins; 3 del; 6 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/com/sun/crypto/provider/Mac/MacKAT.java

26 lines changed: 22 ins; 1 del; 3 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/mscapi/SignUsingNONEwithRSA.java

7 lines changed: 6 ins; 0 del; 1 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/mscapi/SignUsingSHA2withRSA.java

5 lines changed: 4 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/MessageDigest/DigestKAT.java

7 lines changed: 6 ins; 0 del; 1 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/Signature/TestRSAKeyLength.java

2 lines changed: 0 ins; 0 del; 2 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/ec/TestCurves.java

2 lines changed: 1 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/rsa/TestKeyPairGenerator.java

2 lines changed: 1 ins; 0 del; 1 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/rsa/TestSignatures.java

2 lines changed: 1 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/provider/MessageDigest/DigestKAT.java

8 lines changed: 6 ins; 0 del; 2 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/provider/MessageDigest/Offsets.java

2 lines changed: 1 ins; 0 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/provider/MessageDigest/TestSHAClone.java

3 lines changed: 0 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/rsa/TestKeyPairGenerator.java

3 lines changed: 1 ins; 0 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/rsa/TestSignatures.java

3 lines changed: 1 ins; 0 del; 2 mod; 111 unchg

This code review page was prepared using /home/andrew/bin/webrev.jdk8 (vers 25.1-hg+openjdk.java.net).