Code Review for jdk

Prepared by:andrew on Tue Oct 14 21:31:49 BST 2014
Workspace:/home/andrew/projects/openjdk/upstream/jdk6/jdk
Compare against: ssh://hg.openjdk.java.net/jdk6/jdk6/jdk
Compare against version:925
Summary of changes: 1949 lines changed: 1469 ins; 233 del; 247 mod; 35402 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .hgtags

1 line changed: 1 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/java/net/FILES_c.gmk

1 line changed: 1 ins; 0 del; 0 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/java/net/mapfile-vers

2 lines changed: 2 ins; 0 del; 0 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/crypto/provider/RSACipher.java

49 lines changed: 34 ins; 3 del; 12 mod; 430 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/crypto/provider/TlsRsaPremasterSecretGenerator.java

16 lines changed: 5 ins; 6 del; 5 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/Init.java

47 lines changed: 10 ins; 0 del; 37 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/JCEMapper.java

7 lines changed: 7 ins; 0 del; 0 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java

10 lines changed: 7 ins; 0 del; 3 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/c14n/Canonicalizer.java

8 lines changed: 7 ins; 0 del; 1 mod; 384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java

13 lines changed: 13 ins; 0 del; 0 mod; 403 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transform.java

7 lines changed: 7 ins; 0 del; 0 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java

3 lines changed: 3 ins; 0 del; 0 mod; 518 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/utils/JavaUtils.java

22 lines changed: 22 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java

6 lines changed: 6 ins; 0 del; 0 mod; 841 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java

13 lines changed: 13 ins; 0 del; 0 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/ObjectOutputStream.java

2 lines changed: 0 ins; 0 del; 2 mod; 2471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Class.java

14 lines changed: 5 ins; 0 del; 9 mod; 3202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java

4 lines changed: 4 ins; 0 del; 0 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/DatagramSocket.java

47 lines changed: 44 ins; 0 del; 3 mod; 1194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/net/DatagramSocketImpl.java

6 lines changed: 6 ins; 0 del; 0 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/DigestOutputStream.java

5 lines changed: 2 ins; 2 del; 1 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/security/Signature.java

24 lines changed: 20 ins; 0 del; 4 mod; 1275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/ResourceBundle.java

17 lines changed: 15 ins; 0 del; 2 mod; 2734 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/LogRecord.java

7 lines changed: 6 ins; 0 del; 1 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/Logger.java

7 lines changed: 5 ins; 0 del; 2 mod; 1658 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/crypto/CipherInputStream.java

36 lines changed: 31 ins; 2 del; 3 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/crypto/CipherOutputStream.java

9 lines changed: 8 ins; 0 del; 1 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/awt/image/ByteBandedRaster.java

16 lines changed: 12 ins; 0 del; 4 mod; 818 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/awt/image/ByteComponentRaster.java

19 lines changed: 17 ins; 1 del; 1 mod; 965 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/awt/image/BytePackedRaster.java

22 lines changed: 16 ins; 1 del; 5 mod; 1415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/awt/image/IntegerComponentRaster.java

19 lines changed: 17 ins; 1 del; 1 mod; 730 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/awt/image/ShortBandedRaster.java

15 lines changed: 11 ins; 0 del; 4 mod; 803 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/awt/image/ShortComponentRaster.java

19 lines changed: 17 ins; 1 del; 1 mod; 874 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/nio/ch/DatagramChannelImpl.java

20 lines changed: 20 ins; 0 del; 0 mod; 720 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java

105 lines changed: 96 ins; 3 del; 6 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/internal/spec/TlsRsaPremasterSecretParameterSpec.java

111 lines changed: 47 ins; 26 del; 38 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/pkcs11/P11RSACipher.java

137 lines changed: 121 ins; 0 del; 16 mod; 510 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java

26 lines changed: 1 ins; 7 del; 18 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/pkcs11/Token.java

34 lines changed: 34 ins; 0 del; 0 mod; 415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/ClientHandshaker.java

186 lines changed: 179 ins; 1 del; 6 mod; 1165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/RSAClientKeyExchange.java

163 lines changed: 2 ins; 153 del; 8 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/ssl/SSLSessionImpl.java

25 lines changed: 24 ins; 0 del; 1 mod; 781 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/util/KeyUtil.java

74 lines changed: 74 ins; 0 del; 0 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/javavm/export/jvm.h

14 lines changed: 13 ins; 0 del; 1 mod; 1500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/native/java/lang/Class.c

4 lines changed: 0 ins; 1 del; 3 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/native/sun/font/layout/ContextualSubstSubtables.cpp

48 lines changed: 42 ins; 2 del; 4 mod; 652 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/native/sun/font/layout/LEScripts.h

6 lines changed: 0 ins; 6 del; 0 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/print/CUPSPrinter.java

4 lines changed: 0 ins; 0 del; 4 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/print/IPPPrintService.java

6 lines changed: 4 ins; 0 del; 2 mod; 1872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/security/mscapi/RSACipher.java

74 lines changed: 51 ins; 13 del; 10 mod; 398 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/native/sun/awt/splashscreen/splashscreen_sys.c

12 lines changed: 8 ins; 3 del; 1 mod; 567 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/com/sun/crypto/provider/TLS/TestPremaster.java

41 lines changed: 28 ins; 1 del; 12 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java

1 line changed: 0 ins; 0 del; 1 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/java2d/cmm/ColorConvertOp/MTColConvTest.java

1 line changed: 0 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/tls/TestPremaster.java

40 lines changed: 27 ins; 0 del; 13 mod; 69 unchg

------ ------ ------ ------ --- New Patch Raw src/solaris/native/java/net/AbstractPlainDatagramSocketImpl.c

89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/windows/native/java/net/AbstractPlainDatagramSocketImpl.c

111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/security/Signature/VerifyRangeCheckOverflow.java

56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/andrew/bin/webrev (vers 23.18-hg).