Code Review for jdk

Prepared by:andrew on Wed Jan 27 22:50:46 GMT 2016
Workspace:/home/andrew/projects/openjdk/upstream/jdk6/jdk
Compare against: ssh://hg.openjdk.java.net/jdk6/jdk6/jdk
Compare against version:1262
Summary of changes: 9687 lines changed: 6987 ins; 1466 del; 1234 mod; 99768 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw .hgtags

rev 1290 : Added tag jdk6-b38 for changeset eeda5684e9d8
1 line changed: 1 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/shared/Platform.gmk

rev 1263 : OPENJDK6-70: Allow versions of ALSA >= 1.1.0
Summary: Change the regular expression to match 1.x.y where x != 0.
Reviewed-by: omajid
1 line changed: 0 ins; 0 del; 1 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/font/Makefile

rev 1282 : 7171223: Building ExtensionSubtables.cpp should use -fno-strict-aliasing
Summary: GCC 4.4+ have stricter aliasing requirements which produces a new warning from this code
Reviewed-by: prr, ohair
rev 1283 : 8147466: Add -fno-strict-overflow to IndicRearrangementProcessor{,2}.cpp
Summary: Avoid optimisation of possible overflow comparisons in these files
Reviewed-by: omajid
9 lines changed: 9 ins; 0 del; 0 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/javazic/tzdata/VERSION

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/javazic/tzdata/asia

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
9 lines changed: 3 ins; 1 del; 5 mod; 2895 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/javazic/tzdata/australasia

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
29 lines changed: 24 ins; 0 del; 5 mod; 1759 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/javazic/tzdata/europe

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
7 lines changed: 7 ins; 0 del; 0 mod; 3433 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/javazic/tzdata/northamerica

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
22 lines changed: 22 ins; 0 del; 0 mod; 3292 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/javazic/tzdata/zone.tab

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 463 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/crypto/provider/TlsRsaPremasterSecretGenerator.java

rev 1269 : 8081297: SSL Problem with Tomcat
Reviewed-by: xuelei, jnimeh, ahgross
9 lines changed: 5 ins; 2 del; 2 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/net/URL.java

rev 1264 : 8059054: Better URL processing
Reviewed-by: chegar, rriggs, ahgross, coffeys, igerasim
232 lines changed: 223 ins; 0 del; 9 mod; 1321 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java

rev 1270 : 8130710: Better attributes processing
Reviewed-by: jbachorik, dfuchs, ahgross
5 lines changed: 0 ins; 3 del; 2 mod; 1824 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/javax/management/remote/rmi/RMIConnector.java

rev 1270 : 8130710: Better attributes processing
Reviewed-by: jbachorik, dfuchs, ahgross
28 lines changed: 17 ins; 4 del; 7 mod; 2562 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/MemoryImpl.java

rev 1272 : 8137060: JMX memory management improvements
Reviewed-by: dfuchs, ahgross
10 lines changed: 0 ins; 7 del; 3 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java

rev 1286 : 8143185: Cleanup for handling proxies
Reviewed-by: chegar
46 lines changed: 39 ins; 1 del; 6 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/internal/spec/TlsRsaPremasterSecretParameterSpec.java

rev 1269 : 8081297: SSL Problem with Tomcat
Reviewed-by: xuelei, jnimeh, ahgross
38 lines changed: 38 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/jca/JCAUtil.java

rev 1271 : 8134605: Partial rework of the fix for 8081297
Reviewed-by: xuelei, coffeys, valeriep
26 lines changed: 5 ins; 18 del; 3 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/krb5/Credentials.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
2 lines changed: 1 ins; 0 del; 1 mod; 507 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs/PKCS9Attribute.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
3 lines changed: 1 ins; 0 del; 2 mod; 838 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/P11Cipher.java

rev 1266 : 4898461: Support for ECB and CBC/PKCS5Padding
Summary: Add support for ECB mode and PKCS5Padding
Reviewed-by: andreas
rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
rev 1271 : 8134605: Partial rework of the fix for 8081297
Reviewed-by: xuelei, coffeys, valeriep
412 lines changed: 246 ins; 45 del; 121 mod; 490 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/P11RSACipher.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
rev 1271 : 8134605: Partial rework of the fix for 8081297
Reviewed-by: xuelei, coffeys, valeriep
83 lines changed: 21 ins; 28 del; 34 mod; 585 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/SunPKCS11.java

rev 1266 : 4898461: Support for ECB and CBC/PKCS5Padding
Summary: Add support for ECB mode and PKCS5Padding
Reviewed-by: andreas
15 lines changed: 13 ins; 1 del; 1 mod; 1323 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
10 lines changed: 10 ins; 0 del; 0 mod; 595 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java

rev 1284 : 7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one trust anchor is specified
Reviewed-by: mullan
3 lines changed: 2 ins; 0 del; 1 mod; 882 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/provider/certpath/URICertStore.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
3 lines changed: 1 ins; 0 del; 2 mod; 474 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/ssl/RSAClientKeyExchange.java

rev 1269 : 8081297: SSL Problem with Tomcat
Reviewed-by: xuelei, jnimeh, ahgross
rev 1271 : 8134605: Partial rework of the fix for 8081297
Reviewed-by: xuelei, coffeys, valeriep
61 lines changed: 54 ins; 0 del; 7 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/util/Debug.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
3 lines changed: 1 ins; 0 del; 2 mod; 289 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/util/KeyUtil.java

rev 1269 : 8081297: SSL Problem with Tomcat
Reviewed-by: xuelei, jnimeh, ahgross
rev 1271 : 8134605: Partial rework of the fix for 8081297
Reviewed-by: xuelei, coffeys, valeriep
11 lines changed: 5 ins; 2 del; 4 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/validator/SimpleValidator.java

rev 1278 : 7166570: JSSE certificate validation has started to fail for certificate chains
Reviewed-by: wetmore
1 line changed: 0 ins; 0 del; 1 mod; 430 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/AVA.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
2 lines changed: 0 ins; 0 del; 2 mod; 1368 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/AlgorithmId.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
15 lines changed: 8 ins; 0 del; 7 mod; 867 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/CRLDistributionPointsExtension.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
5 lines changed: 2 ins; 0 del; 3 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/CRLNumberExtension.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
4 lines changed: 0 ins; 1 del; 3 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/DNSName.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
11 lines changed: 2 ins; 0 del; 9 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/EDIPartyName.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
1 line changed: 0 ins; 0 del; 1 mod; 256 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/GeneralSubtrees.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
1 line changed: 0 ins; 0 del; 1 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/IPAddressName.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
13 lines changed: 4 ins; 2 del; 7 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/IssuingDistributionPointExtension.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
2 lines changed: 1 ins; 1 del; 0 mod; 476 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/KeyIdentifier.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
2 lines changed: 0 ins; 0 del; 2 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/PolicyMappingsExtension.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
1 line changed: 0 ins; 0 del; 1 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/PrivateKeyUsageExtension.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
4 lines changed: 2 ins; 0 del; 2 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/RDN.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
28 lines changed: 5 ins; 11 del; 12 mod; 489 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/RFC822Name.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
5 lines changed: 2 ins; 0 del; 3 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/URIName.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
1 line changed: 0 ins; 0 del; 1 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/X500Name.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
5 lines changed: 2 ins; 3 del; 0 mod; 1439 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/X509AttributeName.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
1 line changed: 0 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/X509CRLImpl.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
6 lines changed: 0 ins; 4 del; 2 mod; 1291 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/x509/X509CertImpl.java

rev 1268 : 8074068: Cleanup in src/share/classes/sun/security/x509/
Reviewed-by: mullan, ahgross, coffeys
3 lines changed: 0 ins; 2 del; 1 mod; 1873 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_de.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_es.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_fr.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_it.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_ja.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_ko.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_sv.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java

rev 1273 : 8138716: (tz) Support tzdata2015g
Reviewed-by: peytoia
1 line changed: 1 ins; 0 del; 0 mod; 882 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/lib/security/java.security-linux

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
1 line changed: 0 ins; 0 del; 1 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/lib/security/java.security-solaris

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
1 line changed: 0 ins; 0 del; 1 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/lib/security/java.security-windows

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
1 line changed: 0 ins; 0 del; 1 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/image/jpeg/jpegdecoder.c

rev 1275 : 8139017: More stable image decoding
Reviewed-by: prr, serb, mschoene
rev 1277 : 8141213: [Parfait]Potentially blocking function GetArrayLength called in JNI critical region at line 239 of jdk/src/share/native/sun/awt/image/jpeg/jpegdecoder.c in function GET_ARRAYS
Reviewed-by: prr, serb
6 lines changed: 2 ins; 0 del; 4 mod; 764 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/CHANGES

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
368 lines changed: 324 ins; 1 del; 43 mod; 5114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/LICENSE

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
34 lines changed: 7 ins; 6 del; 21 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/README

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
2 lines changed: 0 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/png.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
210 lines changed: 40 ins; 35 del; 135 mod; 4351 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/png.h

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
440 lines changed: 113 ins; 265 del; 62 mod; 2983 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngconf.h

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
37 lines changed: 1 ins; 23 del; 13 mod; 636 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngdebug.h

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
3 lines changed: 1 ins; 2 del; 0 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngerror.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
0 lines changed: 0 ins; 0 del; 0 mod; 991 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngget.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
22 lines changed: 7 ins; 1 del; 14 mod; 1226 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pnginfo.h

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
3 lines changed: 1 ins; 2 del; 0 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pnglibconf.h

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
11 lines changed: 5 ins; 5 del; 1 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngmem.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
4 lines changed: 3 ins; 0 del; 1 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngpread.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
111 lines changed: 7 ins; 90 del; 14 mod; 1092 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngpriv.h

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
89 lines changed: 18 ins; 33 del; 38 mod; 1901 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngread.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
47 lines changed: 25 ins; 10 del; 12 mod; 4127 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngrio.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
3 lines changed: 0 ins; 0 del; 3 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngrtran.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
51 lines changed: 10 ins; 7 del; 34 mod; 4981 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngrutil.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
279 lines changed: 92 ins; 37 del; 150 mod; 4315 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngset.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
71 lines changed: 39 ins; 3 del; 29 mod; 1607 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngstruct.h

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
30 lines changed: 8 ins; 14 del; 8 mod; 495 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngtest.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
161 lines changed: 94 ins; 32 del; 35 mod; 1972 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngtrans.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
5 lines changed: 0 ins; 0 del; 5 mod; 872 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngwio.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
1 line changed: 0 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngwrite.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
442 lines changed: 20 ins; 245 del; 177 mod; 2061 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngwtran.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
9 lines changed: 2 ins; 0 del; 7 mod; 595 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/libpng/pngwutil.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
rev 1288 : 8144955: Wrong changes were pushed with 8143942
Reviewed-by: prr, serb
795 lines changed: 193 ins; 513 del; 89 mod; 2455 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/awt/splashscreen/splashscreen_png.c

rev 1287 : 8143941: Update splashscreen displays
Reviewed-by: ahgross, prr, serb
1 line changed: 1 ins; 0 del; 0 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/ContextualSubstSubtables.cpp

rev 1274 : 8139012: Better font substitutions
Reviewed-by: prr, srl, mschoene
48 lines changed: 10 ins; 6 del; 32 mod; 660 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/CursiveAttachmentSubtables.cpp

rev 1274 : 8139012: Better font substitutions
Reviewed-by: prr, srl, mschoene
1 line changed: 0 ins; 0 del; 1 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/Features.cpp

rev 1274 : 8139012: Better font substitutions
Reviewed-by: prr, srl, mschoene
rev 1289 : 8145551: Test failed with Crash for Improved font lookups
Reviewed-by: prr, vadim
5 lines changed: 1 ins; 0 del; 4 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/IndicRearrangementProcessor.cpp

rev 1276 : 8140543: Arrange font actions
Reviewed-by: prr, srl, mschoene
3 lines changed: 0 ins; 0 del; 3 mod; 501 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/IndicRearrangementProcessor.h

rev 1276 : 8140543: Arrange font actions
Reviewed-by: prr, srl, mschoene
2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/Lookups.cpp

rev 1289 : 8145551: Test failed with Crash for Improved font lookups
Reviewed-by: prr, vadim
2 lines changed: 2 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/MarkToBasePosnSubtables.cpp

rev 1274 : 8139012: Better font substitutions
Reviewed-by: prr, srl, mschoene
1 line changed: 0 ins; 0 del; 1 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/font/layout/MarkToLigaturePosnSubtables.cpp

rev 1274 : 8139012: Better font substitutions
Reviewed-by: prr, srl, mschoene
5 lines changed: 4 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/nio/channels/ServerSocketChannel/AdaptServerSocket.java

rev 1265 : 8068761: [TEST_BUG] java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed with SocketTimeoutException
Reviewed-by: rriggs
1 line changed: 0 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/security/cert/CertPathValidator/OCSP/AIACheck.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
12 lines changed: 11 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
4 lines changed: 4 ins; 0 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509KeyManager/PreferredKey.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
12 lines changed: 11 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/SelfIssuedCert.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
6 lines changed: 5 ins; 0 del; 1 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
9 lines changed: 7 ins; 0 del; 2 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/javax/net/ssl/TLSv11/EmptyCertificateAuthorities.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
5 lines changed: 4 ins; 0 del; 1 mod; 370 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
6 lines changed: 5 ins; 0 del; 1 mod; 888 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
6 lines changed: 5 ins; 0 del; 1 mod; 889 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
6 lines changed: 5 ins; 0 del; 1 mod; 889 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Identities.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
6 lines changed: 5 ins; 0 del; 1 mod; 888 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathBuilder/selfIssued/DisableRevocation.java

rev 1280 : 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected [Tests only]
Summary: make the builder aware of SKID/AKID, break the internal circular dependences
Reviewed-by: mullan
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
270 lines changed: 270 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java

rev 1280 : 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected [Tests only]
Summary: make the builder aware of SKID/AKID, break the internal circular dependences
Reviewed-by: mullan
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
313 lines changed: 313 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathBuilder/selfIssued/README

rev 1280 : 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected [Tests only]
Summary: make the builder aware of SKID/AKID, break the internal circular dependences
Reviewed-by: mullan
382 lines changed: 382 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java

rev 1280 : 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected [Tests only]
Summary: make the builder aware of SKID/AKID, break the internal circular dependences
Reviewed-by: mullan
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
319 lines changed: 319 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathBuilder/selfIssued/generate.sh

rev 1280 : 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected [Tests only]
Summary: make the builder aware of SKID/AKID, break the internal circular dependences
Reviewed-by: mullan
221 lines changed: 221 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathBuilder/selfIssued/openssl.cnf

rev 1280 : 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected [Tests only]
Summary: make the builder aware of SKID/AKID, break the internal circular dependences
Reviewed-by: mullan
205 lines changed: 205 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevel.java

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
204 lines changed: 204 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevelRevoked.java

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
207 lines changed: 207 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevel.java

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
256 lines changed: 256 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevelRevoked.java

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
258 lines changed: 258 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathValidator/indirectCRL/README

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
373 lines changed: 373 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathValidator/indirectCRL/generate.sh

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
221 lines changed: 221 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/security/cert/CertPathValidator/indirectCRL/openssl.cnf

rev 1279 : 6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun
206 lines changed: 206 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Cipher/TestSymmCiphers.java

rev 1266 : 4898461: Support for ECB and CBC/PKCS5Padding
Summary: Add support for ECB mode and PKCS5Padding
Reviewed-by: andreas
272 lines changed: 272 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/provider/certpath/DisabledAlgorithms/CPBuilderWithMD5.java

rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
449 lines changed: 449 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/provider/certpath/ReverseBuilder/ReverseBuild.java

rev 1284 : 7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one trust anchor is specified
Reviewed-by: mullan
rev 1285 : 8142928: [TEST_BUG] sun/security/provider/certpath/ReverseBuilder/ReverseBuild.java 8u71 failure
Reviewed-by: coffeys
349 lines changed: 349 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java

rev 1278 : 7166570: JSSE certificate validation has started to fail for certificate chains
Reviewed-by: wetmore
rev 1281 : 8141287: Add MD5 to jdk.certpath.disabledAlgorithms - Take 2
Reviewed-by: xuelei
562 lines changed: 562 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/x509/AlgorithmId/TurkishRegion.java

rev 1267 : 6867345: Turkish regional options cause NPE in sun.security.x509.AlgorithmId.algOID
Reviewed-by: mullan, weijun
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/andrew/bin/webrev (vers 25.14-hg+openjdk.java.net).