< prev index next >
src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java
Print this page
rev 1571 : 8010297: Missing isLoggable() checks in logging code
Summary: Add isLoggable() checks
Reviewed-by: anthony, mchung, serb
Contributed-by: Laurent Bourges <bourges.laurent@gmail.com>
*** 49,59 ****
}
void install(XEmbeddedFramePeer embedded) {
this.embedded = embedded;
! if (xembedLog.isLoggable(Level.FINE)) xembedLog.fine("Installing xembedder on " + embedded);
XToolkit.addEventDispatcher(embedded.getWindow(), this);
long[] info = new long[] { XEMBED_VERSION, XEMBED_MAPPED };
long data = Native.card32ToData(info);
try {
XEmbedInfo.setAtomData(embedded.getWindow(), data, 2);
--- 49,61 ----
}
void install(XEmbeddedFramePeer embedded) {
this.embedded = embedded;
! if (xembedLog.isLoggable(Level.FINE)) {
! xembedLog.fine("Installing xembedder on " + embedded);
! }
XToolkit.addEventDispatcher(embedded.getWindow(), this);
long[] info = new long[] { XEMBED_VERSION, XEMBED_MAPPED };
long data = Native.card32ToData(info);
try {
XEmbedInfo.setAtomData(embedded.getWindow(), data, 2);
*** 77,89 ****
notifyReady();
}
void handleClientMessage(XEvent xev) {
XClientMessageEvent msg = xev.get_xclient();
! if (xembedLog.isLoggable(Level.FINE)) xembedLog.fine(msg.toString());
if (msg.get_message_type() == XEmbed.getAtom()) {
! if (xembedLog.isLoggable(Level.FINE)) xembedLog.fine("Embedded message: " + msgidToString((int)msg.get_data(1)));
switch ((int)msg.get_data(1)) {
case XEMBED_EMBEDDED_NOTIFY: // Notification about embedding protocol start
// NOTE: May be called two times because we send _SUN_XEMBED_START
active = true;
server = getEmbedder(embedded, msg);
--- 79,95 ----
notifyReady();
}
void handleClientMessage(XEvent xev) {
XClientMessageEvent msg = xev.get_xclient();
! if (xembedLog.isLoggable(Level.FINE)) {
! xembedLog.fine(msg.toString());
! }
if (msg.get_message_type() == XEmbed.getAtom()) {
! if (xembedLog.isLoggable(Level.FINE)) {
! xembedLog.fine("Embedded message: " + msgidToString((int)msg.get_data(1)));
! }
switch ((int)msg.get_data(1)) {
case XEMBED_EMBEDDED_NOTIFY: // Notification about embedding protocol start
// NOTE: May be called two times because we send _SUN_XEMBED_START
active = true;
server = getEmbedder(embedded, msg);
< prev index next >