Code Review for open

Prepared by:apetcher on Thu Aug 30 11:10:06 EDT 2018
Workspace:/home/jdk/jdktasks/XDH_TLS/open
Compare against: ssh://hg.openjdk.java.net/jdk/sandbox
Compare against version:default
Branch:JDK-8171279-XDH-TLS-branch-2
Summary of changes: 1718 lines changed: 1022 ins; 613 del; 83 mod; 5158 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/DHKeyExchange.java

rev 52531 : Code cleanup
96 lines changed: 5 ins; 85 del; 6 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java

rev 52527 : Factoring out some duplicate code.
95 lines changed: 5 ins; 86 del; 4 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java

rev 52524 : minor code cleanup
92 lines changed: 10 ins; 48 del; 34 mod; 872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLCredentials.java

rev 52524 : minor code cleanup
0 lines changed: 0 ins; 0 del; 0 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java

rev 52524 : minor code cleanup
21 lines changed: 5 ins; 9 del; 7 mod; 580 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java

rev 52683 : Code style improvements
395 lines changed: 281 ins; 89 del; 25 mod; 923 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/X509Authentication.java

rev 52711 : mrege
0 lines changed: 0 ins; 0 del; 0 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/ArrayUtil.java

rev 52526 : Moving some code around
19 lines changed: 18 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/ECUtil.java

rev 52683 : Code style improvements
45 lines changed: 44 ins; 0 del; 1 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyAgreement.java

rev 52711 : mrege
11 lines changed: 10 ins; 0 del; 1 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyFactory.java

rev 52521 : Patching in old branch
2 lines changed: 2 ins; 0 del; 0 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyPairGenerator.java

rev 52521 : Patching in old branch
1 line changed: 1 ins; 0 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPrivateKeyImpl.java

rev 52521 : Patching in old branch
2 lines changed: 1 ins; 1 del; 0 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPublicKeyImpl.java

rev 52521 : Patching in old branch
36 lines changed: 2 ins; 32 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XECOperations.java

rev 52521 : Patching in old branch
1 line changed: 1 ins; 0 del; 0 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/TestXECOps.java

rev 52530 : giving up on signature problem
2 lines changed: 1 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/XECIterative.java

rev 52530 : giving up on signature problem
2 lines changed: 1 ins; 0 del; 1 mod; 136 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/security/ssl/KAKeyDerivation.java

rev 52683 : Code style improvements
127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLKeyAgreementCredentials.java

rev 52683 : Code style improvements
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/security/ssl/XDHKeyExchange.java

rev 52683 : Code style improvements
161 lines changed: 161 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/security/util/XECParameters.java

rev 52521 : Patching in old branch
263 lines changed: 263 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/sun/security/ssl/CipherSuite/SupportedGroups.java

rev 52684 : Fixing a test bug.
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.crypto.ec/share/classes/sun/security/ec/XECParameters.java

rev 52521 : Patching in old branch
263 lines changed: 0 ins; 263 del; 0 mod; 0 unchg

This code review page was prepared using ../../scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).