Code Review for open

Prepared by:apetcher on Wed Sep 5 15:39:07 EDT 2018
Workspace:/home/jdk/jdktasks/XDH_TLS/open
Compare against: ssh://hg.openjdk.java.net/jdk/sandbox
Compare against version:default
Branch:JDK-8171279-XDH-TLS-branch-2
Summary of changes: 1753 lines changed: 1052 ins; 635 del; 66 mod; 5153 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/DHKeyExchange.java

rev 52713 : Code review fixes
94 lines changed: 4 ins; 85 del; 5 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java

rev 52713 : Code review fixes
93 lines changed: 4 ins; 86 del; 3 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java

rev 52712 : Code review fixes
rev 52713 : Code review fixes
94 lines changed: 10 ins; 65 del; 19 mod; 870 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLCredentials.java

0 lines changed: 0 ins; 0 del; 0 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java

rev 52712 : Code review fixes
18 lines changed: 1 ins; 13 del; 4 mod; 579 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java

rev 52712 : Code review fixes
rev 52713 : Code review fixes
rev 52714 : Code review fixes
469 lines changed: 351 ins; 90 del; 28 mod; 919 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/X509Authentication.java

0 lines changed: 0 ins; 0 del; 0 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/ArrayUtil.java

19 lines changed: 18 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/ECUtil.java

45 lines changed: 44 ins; 0 del; 1 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyAgreement.java

11 lines changed: 10 ins; 0 del; 1 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyFactory.java

2 lines changed: 2 ins; 0 del; 0 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyPairGenerator.java

1 line changed: 1 ins; 0 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPrivateKeyImpl.java

2 lines changed: 1 ins; 1 del; 0 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPublicKeyImpl.java

36 lines changed: 2 ins; 32 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/XECOperations.java

1 line changed: 1 ins; 0 del; 0 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/TestXECOps.java

2 lines changed: 1 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/XECIterative.java

2 lines changed: 1 ins; 0 del; 1 mod; 136 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/security/ssl/KAKeyDerivation.java

127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/security/ssl/XDHKeyExchange.java

rev 52713 : Code review fixes
160 lines changed: 160 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/security/util/XECParameters.java

263 lines changed: 263 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/sun/security/ssl/CipherSuite/SupportedGroups.java

51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.crypto.ec/share/classes/sun/security/ec/XECParameters.java

263 lines changed: 0 ins; 263 del; 0 mod; 0 unchg

This code review page was prepared using ../../scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).