Code Review for hotspot

Prepared by:katya on Mon Sep 2 18:10:48 MSK 2019
Workspace:/cygdrive/c/work/jdk8u-jfr-incubator/hotspot
Compare against version:9050
Summary of changes: 1947 lines changed: 1500 ins; 371 del; 76 mod; 30387 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/vm_version_ppc.cpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
rev 9055 : 8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin
67 lines changed: 65 ins; 0 del; 2 mod; 665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/vm_version_ppc.hpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
rev 9055 : 8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin
6 lines changed: 4 ins; 0 del; 2 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/vm_version_x86.cpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
111 lines changed: 110 ins; 0 del; 1 mod; 1129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/vm_version_x86.hpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
8 lines changed: 8 ins; 0 del; 0 mod; 756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os/linux/vm/os_linux.cpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
3 lines changed: 3 ins; 0 del; 0 mod; 6697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os/windows/vm/os_windows.cpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
4 lines changed: 4 ins; 0 del; 0 mod; 5975 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/dictionary.hpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
1 line changed: 1 ins; 0 del; 0 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/symbolTable.cpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
7 lines changed: 7 ins; 0 del; 0 mod; 1123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/symbolTable.hpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
3 lines changed: 3 ins; 0 del; 0 mod; 392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
rev 9058 : 8225310: JFR crashed in JfrPeriodicEventSet::requestProtectionDomainCacheTableStatistics()
Summary: Added lock around table usage
Reviewed-by: coleenp, hseigel
15 lines changed: 15 ins; 0 del; 0 mod; 2910 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
5 lines changed: 5 ins; 0 del; 0 mod; 714 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/metadata/metadata.xml

rev 9055 : 8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin
rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
65 lines changed: 64 ins; 0 del; 1 mod; 1142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/periodic/jfrOSInterface.cpp

rev 9055 : 8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin
21 lines changed: 21 ins; 0 del; 0 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/periodic/jfrOSInterface.hpp

rev 9055 : 8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin
1 line changed: 1 ins; 0 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/periodic/jfrPeriodic.cpp

rev 9055 : 8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin
rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
48 lines changed: 48 ins; 0 del; 0 mod; 560 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/periodic/sampling/jfrCallTrace.cpp

rev 9052 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun
3 lines changed: 1 ins; 0 del; 2 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/periodic/sampling/jfrThreadSampler.cpp

rev 9062 : 8215727: Restore JFR thread sampler loop to old / previous behavior
Reviewed-by: egahlin, mgronlun
Contributed-by: milan.mimica@gmail.com
rev 9063 : 8216283: Allow shorter method sampling interval than 10 ms
Reviewed-by: mgronlun
10 lines changed: 1 ins; 0 del; 9 mod; 665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/checkpoint/jfrCheckpointManager.cpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
3 lines changed: 2 ins; 0 del; 1 mod; 378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/repository/jfrChunkWriter.cpp

rev 9051 : 8217362: Emergency dump does not work when disk=false is set
Reviewed-by: egahlin, ysuenaga
Contributed-by: yasuenag@gmail.com
6 lines changed: 0 ins; 4 del; 2 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/repository/jfrEmergencyDump.cpp

rev 9051 : 8217362: Emergency dump does not work when disk=false is set
Reviewed-by: egahlin, ysuenaga
Contributed-by: yasuenag@gmail.com
293 lines changed: 292 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/repository/jfrEmergencyDump.hpp

rev 9051 : 8217362: Emergency dump does not work when disk=false is set
Reviewed-by: egahlin, ysuenaga
Contributed-by: yasuenag@gmail.com
2 lines changed: 2 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/repository/jfrRepository.cpp

rev 9051 : 8217362: Emergency dump does not work when disk=false is set
Reviewed-by: egahlin, ysuenaga
Contributed-by: yasuenag@gmail.com
309 lines changed: 1 ins; 305 del; 3 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/service/jfrOptionSet.cpp

rev 9052 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun
6 lines changed: 1 ins; 4 del; 1 mod; 724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp

rev 9052 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun
2 lines changed: 0 ins; 0 del; 2 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/storage/jfrBuffer.cpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
14 lines changed: 8 ins; 5 del; 1 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/storage/jfrBuffer.hpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
5 lines changed: 2 ins; 3 del; 0 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/storage/jfrMemorySpace.inline.hpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
15 lines changed: 4 ins; 4 del; 7 mod; 374 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/storage/jfrStorage.cpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
9 lines changed: 5 ins; 4 del; 0 mod; 757 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/storage/jfrStorageUtils.hpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
10 lines changed: 9 ins; 1 del; 0 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/storage/jfrStorageUtils.inline.hpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
23 lines changed: 23 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/stringpool/jfrStringPool.cpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
64 lines changed: 11 ins; 28 del; 25 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/stringpool/jfrStringPoolBuffer.cpp

rev 9053 : 8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
5 lines changed: 0 ins; 2 del; 3 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/utilities/jfrTypes.hpp

rev 9052 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun
3 lines changed: 3 ins; 0 del; 0 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/allocation.hpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
3 lines changed: 1 ins; 0 del; 2 mod; 743 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vm_version.cpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
26 lines changed: 24 ins; 1 del; 1 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vm_version.hpp

rev 9054 : 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, mdoerr
rev 9055 : 8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin
24 lines changed: 23 ins; 0 del; 1 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/nmtCommon.cpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
1 line changed: 1 ins; 0 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/hashtable.cpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
31 lines changed: 27 ins; 0 del; 4 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/hashtable.hpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
15 lines changed: 5 ins; 10 del; 0 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/hashtable.inline.hpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
9 lines changed: 9 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/testlibrary/com/oracle/java/testlibrary/DockerRunOptions.java

rev 9059 : 8219997: [TESTBUG] Create test for JFR events in Docker container: CPU, Memory and Process Info
Summary: Start docker with limits on CPU/Mem, verify JFR reports correct data
Reviewed-by: egahlin
4 lines changed: 4 ins; 0 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/testlibrary/com/oracle/java/testlibrary/DockerTestUtils.java

rev 9061 : 8222888: [TESTBUG] docker/TestJFREvents.java fails due to "RuntimeException: JAVA_MAIN_CLASS_ is not defined"
Summary: Introduced unique environment variable
Reviewed-by: egahlin, lmesnik, sgehwolf
16 lines changed: 11 ins; 0 del; 5 mod; 277 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/utilities/tableStatistics.cpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
rev 9057 : 8223599: minimal build fails after JDK-8185525
Reviewed-by: shade, gziemski, dholmes
Contributed-by: Wang Haomin <wanghaomin@loongson.cn>
150 lines changed: 150 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/utilities/tableStatistics.hpp

rev 9056 : 8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/containers/docker/JfrNetwork.java

rev 9060 : 8221711: [TESTBUG] create more tests for JFR in container environment
Summary: Added test cases for environment and network events
Reviewed-by: egahlin
163 lines changed: 163 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/containers/docker/JfrReporter.java

rev 9059 : 8219997: [TESTBUG] Create test for JFR events in Docker container: CPU, Memory and Process Info
Summary: Start docker with limits on CPU/Mem, verify JFR reports correct data
Reviewed-by: egahlin
rev 9060 : 8221711: [TESTBUG] create more tests for JFR in container environment
Summary: Added test cases for environment and network events
Reviewed-by: egahlin
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/containers/docker/TestJFREvents.java

rev 9059 : 8219997: [TESTBUG] Create test for JFR events in Docker container: CPU, Memory and Process Info
Summary: Start docker with limits on CPU/Mem, verify JFR reports correct data
Reviewed-by: egahlin
rev 9060 : 8221711: [TESTBUG] create more tests for JFR in container environment
Summary: Added test cases for environment and network events
Reviewed-by: egahlin
rev 9061 : 8222888: [TESTBUG] docker/TestJFREvents.java fails due to "RuntimeException: JAVA_MAIN_CLASS_ is not defined"
Summary: Introduced unique environment variable
Reviewed-by: egahlin, lmesnik, sgehwolf
147 lines changed: 147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/containers/docker/TestJFRNetworkEvents.java

rev 9060 : 8221711: [TESTBUG] create more tests for JFR in container environment
Summary: Added test cases for environment and network events
Reviewed-by: egahlin
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/work/openjdk-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).