Code Review for jmc

Prepared by:aptmac on Wed Apr 17 12:21:15 EDT 2019
Workspace:/home/almac/workspace/jmc
Summary of changes: 492 lines changed: 476 ins; 0 del; 16 mod; 5467 unchg
Patch of changes: jmc.patch
Bug id: JMC-4466 : Hide thread directly from Thread graph context menu
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ChartToolTipProvider.java

5 lines changed: 5 ins; 0 del; 0 mod; 265 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ThreadGraphLanes.java

1 line changed: 0 ins; 0 del; 1 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java

2 lines changed: 2 ins; 0 del; 0 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java

110 lines changed: 104 ins; 0 del; 6 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties

2 lines changed: 2 ins; 0 del; 0 mod; 594 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/IChartInfoVisitor.java

15 lines changed: 14 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/Messages.java

1 line changed: 1 ins; 0 del; 0 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/QuantitySpanRenderer.java

13 lines changed: 9 ins; 0 del; 4 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/RendererToolkit.java

7 lines changed: 3 ins; 0 del; 4 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java

21 lines changed: 21 ins; 0 del; 0 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/resources/org/openjdk/jmc/ui/charts/messages.properties

1 line changed: 1 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/base/wrappers/MCJemmyBase.java

43 lines changed: 43 ins; 0 del; 0 mod; 1110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrUi.java

4 lines changed: 4 ins; 0 del; 0 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCTable.java

17 lines changed: 17 ins; 0 del; 0 mod; 864 unchg

------ ------ ------ ------ --- New Patch Raw application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/JfrThreadsPageTest.java

116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCChartCanvas.java

134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.17-hg+openjdk.java.net).