Code Review for jmc

Prepared by:aptmac on Tue Oct 22 09:27:36 EDT 2019
Workspace:/home/almac/workspace/jmc
Summary of changes: 3355 lines changed: 3204 ins; 21 del; 130 mod; 9002 unchg
Patch of changes: jmc.patch
Bug id: jfr-threads-page
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java

44 lines changed: 38 ins; 0 del; 6 mod; 1158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/FlavorSelector.java

16 lines changed: 9 ins; 1 del; 6 mod; 633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/LaneEditor.java

11 lines changed: 5 ins; 0 del; 6 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ThreadGraphLanes.java

67 lines changed: 56 ins; 2 del; 9 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java

13 lines changed: 7 ins; 0 del; 6 mod; 554 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ChartAndTableUI.java

24 lines changed: 8 ins; 0 del; 16 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java

110 lines changed: 96 ins; 4 del; 10 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties

9 lines changed: 8 ins; 0 del; 1 mod; 612 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/UIPlugin.java

21 lines changed: 15 ins; 0 del; 6 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/AWTChartToolkit.java

17 lines changed: 7 ins; 0 del; 10 mod; 492 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYChart.java

347 lines changed: 308 ins; 7 del; 32 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java

179 lines changed: 158 ins; 5 del; 16 mod; 546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/Messages.java

10 lines changed: 10 ins; 0 del; 0 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/wizards/OnePageWizardDialog.java

15 lines changed: 9 ins; 0 del; 6 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/resources/org/openjdk/jmc/ui/misc/messages.properties

10 lines changed: 10 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/JfrThreadsPageTest.java

88 lines changed: 86 ins; 2 del; 0 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/base/wrappers/MCJemmyBase.java

11 lines changed: 11 ins; 0 del; 0 mod; 1153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCButton.java

53 lines changed: 53 ins; 0 del; 0 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCTable.java

31 lines changed: 31 ins; 0 del; 0 mod; 882 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DropdownLaneFilter.java

151 lines changed: 151 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ChartAndPopupTableUI.java

333 lines changed: 333 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-scale-to-fit-16.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.ui/icons/fa-scale-to-fit-16.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-scale-to-fit.svg

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-select.svg

14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-selection-16.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.ui/icons/fa-selection-16.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-zoom-in-16.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.ui/icons/fa-zoom-in-16.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-zoom-in.svg

19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-zoom-out-16.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.ui/icons/fa-zoom-out-16.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-zoom-out.svg

18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-zoom-pan-16.png

Unexpected Error occurred reading `diff -e /dev/null new/application/org.openjdk.jmc.ui/icons/fa-zoom-pan-16.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/icons/fa-zoom-pan.svg

18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/ChartFilterControlBar.java

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartDisplayControlBar.java

527 lines changed: 527 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartTextCanvas.java

412 lines changed: 412 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/PatternFly.java

195 lines changed: 195 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/TimeDisplay.java

181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/TimeFilter.java

127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/TimelineCanvas.java

197 lines changed: 197 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.17-hg+openjdk.java.net).