src/java.base/share/classes/com/sun/crypto/provider/GHASH.java

@@ -1,7 +1,7 @@
 /*
- * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2015, Oracle and/or its affiliates. All rights reserved.
  * Copyright (c) 2015 Red Hat, Inc.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License version 2 only, as

@@ -60,18 +60,20 @@
         }
     }
 
     private static final int AES_BLOCK_SIZE = 16;
 
-    // Multiplies state0, state1 by V0, V1.
-    private void blockMult(long V0, long V1) {
+    // Multiplies state[0], state[1] by subkeyH[0], subkeyH[1].
+    private void blockMult(long[] subH) {
         long Z0 = 0;
         long Z1 = 0;
+        long V0 = subH[0];
+        long V1 = subH[1];
         long X;
 
-        // Separate loops for processing state0 and state1.
-        X = state0;
+        // Separate loops for processing state[0] and state[1].
+        X = state[0];
         for (int i = 0; i < 64; i++) {
             // Zi+1 = Zi if bit i of x is 0
             long mask = X >> 63;
             Z0 ^= V0 & mask;
             Z1 ^= V1 & mask;

@@ -87,11 +89,11 @@
             // Conditional reduction modulo P128.
             V0 ^= 0xe100000000000000L & mask;
             X <<= 1;
         }
 
-        X = state1;
+        X = state[1];
         for (int i = 64; i < 127; i++) {
             // Zi+1 = Zi if bit i of x is 0
             long mask = X >> 63;
             Z0 ^= V0 & mask;
             Z1 ^= V1 & mask;

@@ -113,19 +115,22 @@
         long mask = X >> 63;
         Z0 ^= V0 & mask;
         Z1 ^= V1 & mask;
 
         // Save result.
-        state0 = Z0;
-        state1 = Z1;
+        state[0] = Z0;
+        state[1] = Z1;
+        
     }
 
+    /* subkeyH and state are stored in long[] for GHASH intrinsic use */
+
     // hash subkey H; should not change after the object has been constructed
-    private final long subkeyH0, subkeyH1;
+    private final long[] subkeyH;
 
     // buffer for storing hash
-    private long state0, state1;
+    private long[] state;
 
     // variables for save/restore calls
     private long stateSave0, stateSave1;
 
     /**

@@ -139,69 +144,83 @@
      */
     GHASH(byte[] subkeyH) throws ProviderException {
         if ((subkeyH == null) || subkeyH.length != AES_BLOCK_SIZE) {
             throw new ProviderException("Internal error");
         }
-        this.subkeyH0 = getLong(subkeyH, 0);
-        this.subkeyH1 = getLong(subkeyH, 8);
+        state = new long[2];
+        this.subkeyH = new long[2];
+        this.subkeyH[0] = getLong(subkeyH, 0);
+        this.subkeyH[1] = getLong(subkeyH, 8);
     }
 
     /**
      * Resets the GHASH object to its original state, i.e. blank w/
      * the same subkey H. Used after digest() is called and to re-use
      * this object for different data w/ the same H.
      */
     void reset() {
-        state0 = 0;
-        state1 = 0;
+        state[0] = 0;
+        state[1] = 0;
     }
 
     /**
      * Save the current snapshot of this GHASH object.
      */
     void save() {
-        stateSave0 = state0;
-        stateSave1 = state1;
+        stateSave0 = state[0];
+        stateSave1 = state[1];
     }
 
     /**
      * Restores this object using the saved snapshot.
      */
     void restore() {
-        state0 = stateSave0;
-        state1 = stateSave1;
+        state[0] = stateSave0;
+        state[1] = stateSave1;
     }
 
     private void processBlock(byte[] data, int ofs) {
-        if (data.length - ofs < AES_BLOCK_SIZE) {
-            throw new RuntimeException("need complete block");
-        }
-        state0 ^= getLong(data, ofs);
-        state1 ^= getLong(data, ofs + 8);
-        blockMult(subkeyH0, subkeyH1);
+        state[0] ^= getLong(data, ofs);
+        state[1] ^= getLong(data, ofs + 8);
+        blockMult(subkeyH);
     }
 
     void update(byte[] in) {
         update(in, 0, in.length);
     }
 
     void update(byte[] in, int inOfs, int inLen) {
+        if (inLen == 0) {
+            return;
+        }
         if (inLen - inOfs > in.length) {
             throw new RuntimeException("input length out of bound");
         }
         if (inLen % AES_BLOCK_SIZE != 0) {
             throw new RuntimeException("input length unsupported");
         }
 
-        for (int i = inOfs; i < (inOfs + inLen); i += AES_BLOCK_SIZE) {
-            processBlock(in, i);
+        processBlocks(in, inOfs, inLen/AES_BLOCK_SIZE);
+    }
+
+    /*
+     * No changes to this method's argument list; exceptions thrown or array
+     * allocation by methods called by this method, can be performed without
+     * breaking intrinsics
+     */
+    private void processBlocks(byte[] data, int inOfs, int blocks) {
+        int offset = inOfs;
+        while (blocks > 0) {
+            processBlock(data, offset);
+            blocks--;
+            offset += AES_BLOCK_SIZE;
         }
     }
 
     byte[] digest() {
         byte[] result = new byte[AES_BLOCK_SIZE];
-        putLong(result, 0, state0);
-        putLong(result, 8, state1);
+        putLong(result, 0, state[0]);
+        putLong(result, 8, state[1]);
         reset();
         return result;
     }
 }