Code Review for open

Prepared by: U-ASEMENYU-LAPsemenyu (ASEMENYU-LAP+asemenyu) on Fri Dec 13 13:40:05 EST 2019
Workspace:/cygdrive/c/ade/work/as/jds/work/10new/jdk10/open
Summary of changes: 3732 lines changed: 2123 ins; 1155 del; 454 mod; 10292 unchg
Patch of changes: open.patch
Bug id: JDK-8233270 : Add support to jtreg helpers to unpack packages
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/DesktopIntegration.java

55 lines changed: 39 ins; 9 del; 7 mod; 487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LinuxAppImageBuilder.java

39 lines changed: 1 ins; 25 del; 13 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LinuxPackageBundler.java

5 lines changed: 0 ins; 4 del; 1 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppBundler.java

15 lines changed: 0 ins; 15 del; 0 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacDmgBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 479 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/AbstractAppImageBuilder.java

59 lines changed: 54 ins; 3 del; 2 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/AddLauncherArguments.java

4 lines changed: 3 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/OverridableResource.java

134 lines changed: 99 ins; 20 del; 15 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinAppBundler.java

15 lines changed: 0 ins; 15 del; 0 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WindowsAppImageBuilder.java

26 lines changed: 3 ins; 10 del; 13 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/JPackageHelper.java

4 lines changed: 0 ins; 4 del; 0 mod; 679 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java

27 lines changed: 19 ins; 0 del; 8 mod; 356 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java

23 lines changed: 19 ins; 3 del; 1 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java

115 lines changed: 88 ins; 3 del; 24 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java

151 lines changed: 116 ins; 11 del; 24 mod; 697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JarBuilder.java

2 lines changed: 0 ins; 0 del; 2 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LinuxHelper.java

111 lines changed: 69 ins; 22 del; 20 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacHelper.java

68 lines changed: 59 ins; 4 del; 5 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java

338 lines changed: 200 ins; 63 del; 75 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java

1 line changed: 0 ins; 0 del; 1 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java

47 lines changed: 15 ins; 10 del; 22 mod; 820 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestBuilder.java

7 lines changed: 0 ins; 1 del; 6 mod; 455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestInstance.java

7 lines changed: 6 ins; 0 del; 1 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java

79 lines changed: 66 ins; 4 del; 9 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/MaintainerTest.java

5 lines changed: 0 ins; 2 del; 3 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/PackageDepsTest.java

50 lines changed: 20 ins; 22 del; 8 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/ReleaseTest.java

5 lines changed: 0 ins; 2 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/ShortcutHintTest.java

45 lines changed: 1 ins; 7 del; 37 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/macosx/base/SigningBase.java

2 lines changed: 0 ins; 1 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/resources/icon.png

Unexpected Error occurred reading `diff -e old/test/jdk/tools/jpackage/resources/icon.png new/test/jdk/tools/jpackage/resources/icon.png`: $?=0, err= 1

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/run_tests.sh

19 lines changed: 7 ins; 8 del; 4 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AdditionalLaunchersTest.java

165 lines changed: 89 ins; 44 del; 32 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AppImagePackageTest.java

32 lines changed: 4 ins; 14 del; 14 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ArgumentsTest.java

3 lines changed: 2 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/IconTest.java

385 lines changed: 348 ins; 6 del; 31 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/InstallDirTest.java

6 lines changed: 0 ins; 4 del; 2 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/LicenseTest.java

13 lines changed: 10 ins; 0 del; 3 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/BasicTest.java

115 lines changed: 42 ins; 38 del; 35 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java

4 lines changed: 0 ins; 1 del; 3 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/ModulePathTest.java

66 lines changed: 29 ins; 31 del; 6 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/test_jpackage.sh

19 lines changed: 14 ins; 4 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinConsoleTest.java

5 lines changed: 5 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinScriptTest.java

25 lines changed: 11 ins; 8 del; 6 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinUpgradeUUIDTest.java

153 lines changed: 134 ins; 6 del; 13 mod; 55 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AdditionalLauncher.java

239 lines changed: 239 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LauncherIconVerifier.java

93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/RunnablePackageTest.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/icon2.icns

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/resources/icon2.icns`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/icon2.ico

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/resources/icon2.ico`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/icon2.png

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/resources/icon2.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/icon3.ico

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/resources/icon3.ico`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/icon3.png

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/resources/icon3.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/icon4.ico

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/resources/icon4.ico`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/icon4.png

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/resources/icon4.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/resources/query-msi-property.js

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/apps/com.other/com/other/Other.java

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/apps/com.other/module-info.java

26 lines changed: 0 ins; 26 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/manage_packages.sh

231 lines changed: 0 ins; 231 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/AddLauncherBase.java

193 lines changed: 0 ins; 193 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/AddLauncherModuleTest.java

51 lines changed: 0 ins; 51 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/AddLauncherTest.java

83 lines changed: 0 ins; 83 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/AddLaunchersTest.java

83 lines changed: 0 ins; 83 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/ade/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).