Code Review for jdk

Prepared by:bobv on Thu Oct 15 12:39:42 EDT 2015
Workspace:/export/users/bobv/jdk9-dev/jdk
Summary of changes: 710 lines changed: 495 ins; 36 del; 179 mod; 38873 unchg
Patch of changes: jdk.patch
Bug id: <title>[JDK-8136556] Add the ability to perform static builds of MacOSX x64 binaries - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Import.gmk

35 lines changed: 10 ins; 0 del; 25 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/launcher/LauncherCommon.gmk

24 lines changed: 20 ins; 0 del; 4 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/CoreLibraries.gmk

6 lines changed: 4 ins; 0 del; 2 mod; 457 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-java.base.gmk

26 lines changed: 25 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.jdwp.agent.gmk

20 lines changed: 20 ins; 0 del; 0 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/SecurityLibraries.gmk

30 lines changed: 4 ins; 0 del; 26 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libnio/mapfile-macosx

1 line changed: 1 ins; 0 del; 0 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/agent_util/agent_util.h

46 lines changed: 45 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/compiledMethodLoad/compiledMethodLoad.c

3 lines changed: 0 ins; 0 del; 3 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/gctest/gctest.c

3 lines changed: 0 ins; 0 del; 3 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/heapTracker/heapTracker.c

3 lines changed: 0 ins; 0 del; 3 mod; 1013 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/heapTracker/heapTracker.h

6 lines changed: 0 ins; 5 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/heapViewer/heapViewer.c

3 lines changed: 0 ins; 0 del; 3 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/minst/minst.c

3 lines changed: 0 ins; 0 del; 3 mod; 478 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/minst/minst.h

6 lines changed: 0 ins; 5 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/mtrace/mtrace.c

3 lines changed: 0 ins; 0 del; 3 mod; 830 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/mtrace/mtrace.h

6 lines changed: 0 ins; 5 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/versionCheck/versionCheck.c

3 lines changed: 0 ins; 0 del; 3 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/waiters/Monitor.hpp

5 lines changed: 4 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/waiters/Thread.cpp

4 lines changed: 3 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/demo/share/jvmti/waiters/waiters.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/macosx/native/libjava/java_props_macosx.c

5 lines changed: 3 ins; 1 del; 1 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/macosx/native/libjli/java_md_macosx.c

49 lines changed: 48 ins; 1 del; 0 mod; 1088 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/check_version.c

3 lines changed: 1 ins; 0 del; 2 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/jio.c

5 lines changed: 4 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/jni_util.h

112 lines changed: 111 ins; 0 del; 1 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjimage/ImageNativeSubstrate.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 597 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnet/net_util.c

2 lines changed: 0 ins; 0 del; 2 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnio/nio_util.c

1 line changed: 0 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libverify/check_code.c

6 lines changed: 6 ins; 0 del; 0 mod; 4353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libzip/ZipFile.c

7 lines changed: 6 ins; 0 del; 1 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libjava/jlong_md.h

13 lines changed: 8 ins; 0 del; 5 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/awt/LWCToolkit.m

1 line changed: 0 ins; 0 del; 1 mod; 763 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libjawt/jawt.m

6 lines changed: 5 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.h

6 lines changed: 6 ins; 0 del; 0 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m

6 lines changed: 4 ins; 0 del; 2 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libosxui/AquaLookAndFeel.m

7 lines changed: 5 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/include/jawt.h

2 lines changed: 1 ins; 0 del; 1 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/sunFont.c

5 lines changed: 4 ins; 0 del; 1 mod; 361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libjavajpeg/jpegdecoder.c

2 lines changed: 0 ins; 0 del; 2 mod; 772 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libjsound/Platform.c

4 lines changed: 4 ins; 0 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libjsound/Utilities.h

2 lines changed: 1 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/liblcms/LCMS.c

2 lines changed: 0 ins; 0 del; 2 mod; 892 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libmlib_image/mlib_ImageUtils.c

9 lines changed: 8 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libsplashscreen/java_awt_SplashScreen.c

2 lines changed: 0 ins; 0 del; 2 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c

2 lines changed: 0 ins; 0 del; 2 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/native/libawt_headless/awt/HeadlessToolkit.c

5 lines changed: 3 ins; 0 del; 2 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c

1 line changed: 0 ins; 0 del; 1 mod; 1103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/native/libjawt/jawt.c

6 lines changed: 5 ins; 0 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/native/libjsound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c

6 lines changed: 5 ins; 0 del; 1 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 2730 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/native/libjawt/jawt.cpp

6 lines changed: 5 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/native/libinstrument/InstrumentationImplNativeMethods.c

6 lines changed: 5 ins; 0 del; 1 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/native/libinstrument/InvocationAdapter.c

4 lines changed: 0 ins; 0 del; 4 mod; 834 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/native/libinstrument/JarFacade.h

5 lines changed: 4 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/native/libinstrument/Utilities.h

8 lines changed: 7 ins; 0 del; 1 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.management/share/native/libmanagement/management.c

3 lines changed: 1 ins; 0 del; 2 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.prefs/macosx/native/libprefs/MacOSXPreferencesFile.m

6 lines changed: 5 ins; 0 del; 1 mod; 1058 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.prefs/unix/native/libprefs/FileSystemPreferences.c

6 lines changed: 5 ins; 0 del; 1 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.prefs/windows/native/libprefs/WindowsPreferences.c

7 lines changed: 6 ins; 0 del; 1 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/macosx/native/libosxkrb5/nativeccache.c

5 lines changed: 2 ins; 0 del; 3 mod; 594 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/native/libj2gss/NativeUtil.c

4 lines changed: 1 ins; 0 del; 3 mod; 813 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/native/libj2gss/NativeUtil.h

4 lines changed: 0 ins; 3 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/windows/native/libw2k_lsa_auth/NativeCreds.c

4 lines changed: 1 ins; 0 del; 3 mod; 1087 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.smartcardio/share/native/libj2pcsc/pcsc.c

4 lines changed: 2 ins; 0 del; 2 mod; 488 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c

6 lines changed: 5 ins; 0 del; 1 mod; 478 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c

6 lines changed: 5 ins; 0 del; 1 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c

6 lines changed: 5 ins; 0 del; 1 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c

5 lines changed: 4 ins; 0 del; 1 mod; 631 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/native/libsunec/ECC_JNI.cpp

7 lines changed: 6 ins; 0 del; 1 mod; 473 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp

7 lines changed: 6 ins; 0 del; 1 mod; 2103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.pkcs11/share/native/libj2pkcs11/p11_general.c

2 lines changed: 0 ins; 0 del; 2 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ucrypto/solaris/native/libj2ucrypto/nativeCrypto.c

2 lines changed: 1 ins; 0 del; 1 mod; 1338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.deploy.osx/macosx/native/libapplescriptengine/AppleScriptEngine.m

9 lines changed: 8 ins; 0 del; 1 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.deploy.osx/macosx/native/libosx/Dispatch.m

11 lines changed: 10 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c

3 lines changed: 0 ins; 0 del; 3 mod; 1326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/debugInit.h

4 lines changed: 0 ins; 3 del; 1 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/transport.c

7 lines changed: 5 ins; 1 del; 1 mod; 629 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/util.h

13 lines changed: 0 ins; 12 del; 1 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/vm_interface.h

2 lines changed: 1 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.management/share/native/libmanagement_ext/management_ext.c

2 lines changed: 1 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.pack200/share/native/common-unpack/utils.cpp

4 lines changed: 3 ins; 0 del; 1 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.pack200/share/native/libunpack/jni.cpp

6 lines changed: 5 ins; 0 del; 1 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.sctp/unix/native/libsctp/SctpNet.c

2 lines changed: 0 ins; 0 del; 2 mod; 756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.security.auth/unix/native/libjaas/Unix.c

7 lines changed: 6 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.security.auth/windows/native/libjaas/nt.c

7 lines changed: 6 ins; 0 del; 1 mod; 804 unchg

This code review page was prepared using /home/bvandett/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).