Code Review for jdk

Prepared by:bpb on Fri Dec 5 13:55:47 PST 2014
Workspace:/Users/bpb/Work/CoreLibs/jdk/jdk9/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:11065
Summary of changes: 145 lines changed: 112 ins; 17 del; 16 mod; 3301 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/FileInputStream.java

rev 11066 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
rev 11067 : 8025619.01
16 lines changed: 9 ins; 3 del; 4 mod; 393 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/FileOutputStream.java

rev 11067 : 8025619.01
15 lines changed: 8 ins; 3 del; 4 mod; 429 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/RandomAccessFile.java

rev 11067 : 8025619.01
16 lines changed: 9 ins; 3 del; 4 mod; 1146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java

rev 11066 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
3 lines changed: 3 ins; 0 del; 0 mod; 1191 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/sun/nio/ch/FileKey.java

rev 11066 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
6 lines changed: 0 ins; 4 del; 2 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/classes/sun/nio/ch/FileKey.java

rev 11066 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
6 lines changed: 0 ins; 4 del; 2 mod; 73 unchg

------ ------ ------ ------ --- New ----- Raw test/java/nio/channels/FileChannel/InvalidFileChannel.java

rev 11066 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 25.2-hg+openjdk.java.net).