Code Review for jdk

Prepared by:bpb on Tue Dec 9 12:06:38 PST 2014
Workspace:/Users/bpb/Work/CoreLibs/jdk/jdk9/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:11077
Summary of changes: 214 lines changed: 159 ins; 20 del; 35 mod; 3312 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/FileInputStream.java

rev 11078 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: If the stream is closed ensure getChannel() returns a closed channel. Also, FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
rev 11079 : 8025619.01
rev 11080 : 8025619.02
rev 11081 : 8025619.03
29 lines changed: 15 ins; 4 del; 10 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/FileOutputStream.java

rev 11079 : 8025619.01
rev 11080 : 8025619.02
rev 11081 : 8025619.03
28 lines changed: 14 ins; 4 del; 10 mod; 422 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/io/RandomAccessFile.java

rev 11079 : 8025619.01
rev 11080 : 8025619.02
rev 11081 : 8025619.03
30 lines changed: 15 ins; 4 del; 11 mod; 1138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java

rev 11078 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: If the stream is closed ensure getChannel() returns a closed channel. Also, FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
3 lines changed: 3 ins; 0 del; 0 mod; 1224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/sun/nio/ch/FileKey.java

rev 11078 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: If the stream is closed ensure getChannel() returns a closed channel. Also, FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
6 lines changed: 0 ins; 4 del; 2 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/windows/classes/sun/nio/ch/FileKey.java

rev 11078 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: If the stream is closed ensure getChannel() returns a closed channel. Also, FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
6 lines changed: 0 ins; 4 del; 2 mod; 73 unchg

------ ------ ------ ------ --- New ----- Raw test/java/nio/channels/FileChannel/GetClosedChannel.java

rev 11078 : 8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed
Summary: If the stream is closed ensure getChannel() returns a closed channel. Also, FileKey.create() should throw an IOException directly instead of wrapping it in an Error.
Reviewed-by: TBD
rev 11080 : 8025619.02
rev 11081 : 8025619.03
112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 25.2-hg+openjdk.java.net).