Code Review for submit

Prepared by:bsrbnd on Wed Mar 6 22:35:27 CET 2019
Workspace:/home/devel/contrib/repo/submit13a/submit
Compare against version:03924ad3f4d0
Branch:JDK-8217561
Summary of changes: 724 lines changed: 685 ins; 5 del; 34 mod; 46612 unchg
Patch of changes: submit.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/assembler_x86.cpp

rev 53928 : 8217561: X86: Add floating-point Math.min/max intrinsics
Summary: Implementation taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
39 lines changed: 34 ins; 0 del; 5 mod; 9229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/assembler_x86.hpp

rev 53928 : 8217561: X86: Add floating-point Math.min/max intrinsics
Summary: Implementation taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
5 lines changed: 5 ins; 0 del; 0 mod; 2313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

rev 53930 : 8217561: X86: Add floating-point Math.min/max intrinsics (reduction pattern)
Summary: Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
2 lines changed: 2 ins; 0 del; 0 mod; 1782 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/x86.ad

rev 53928 : 8217561: X86: Add floating-point Math.min/max intrinsics
Summary: Implementation taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
10 lines changed: 9 ins; 0 del; 1 mod; 10020 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/x86_64.ad

rev 53928 : 8217561: X86: Add floating-point Math.min/max intrinsics
Summary: Implementation taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
rev 53930 : 8217561: X86: Add floating-point Math.min/max intrinsics (reduction pattern)
Summary: Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
290 lines changed: 290 ins; 0 del; 0 mod; 12751 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

rev 53928 : 8217561: X86: Add floating-point Math.min/max intrinsics
Summary: Implementation taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
rev 53929 : 8217561: X86: Add floating-point Math.min/max intrinsics (callsite-sensitive heuristic)
Summary: Implementation using a callsite-sensitive heuristic and taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
rev 53930 : 8217561: X86: Add floating-point Math.min/max intrinsics (reduction pattern)
Summary: Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
35 lines changed: 34 ins; 0 del; 1 mod; 6725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/loopTransform.cpp

rev 53930 : 8217561: X86: Add floating-point Math.min/max intrinsics (reduction pattern)
Summary: Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
3 lines changed: 1 ins; 0 del; 2 mod; 3697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxIntrinsics.java

rev 53928 : 8217561: X86: Add floating-point Math.min/max intrinsics
Summary: Implementation taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
rev 53929 : 8217561: X86: Add floating-point Math.min/max intrinsics (callsite-sensitive heuristic)
Summary: Implementation using a callsite-sensitive heuristic and taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
rev 53930 : 8217561: X86: Add floating-point Math.min/max intrinsics (reduction pattern)
Summary: Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
213 lines changed: 183 ins; 5 del; 25 mod; 95 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/compiler/FpMinMaxIntrinsics.java

rev 53928 : 8217561: X86: Add floating-point Math.min/max intrinsics
Summary: Implementation taking care of the non-conformance with the Java doc of x86 min/max for +/-0.0 and NaN
Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
Contributed-by: Jatin Bhateja <jatin.bhateja@intel.com>
127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev.ksh (vers 25.17-hg+openjdk.java.net).