Code Review for open

Prepared by:chegar on Tue Aug 7 15:14:53 IST 2018
Workspace:/Users/chris/repos/jdk/sandbox/open
Compare against: ssh://hg.openjdk.java.net/jdk/sandbox
Branch:http-client-branch
Summary of changes: 1294 lines changed: 1238 ins; 17 del; 39 mod; 8377 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/java/net/http/HttpClient.java

34 lines changed: 33 ins; 0 del; 1 mod; 603 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/AbstractAsyncSSLConnection.java

2 lines changed: 0 ins; 2 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/AsyncSSLConnection.java

24 lines changed: 17 ins; 5 del; 2 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/AsyncSSLTunnelConnection.java

24 lines changed: 17 ins; 5 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java

31 lines changed: 31 ins; 0 del; 0 mod; 581 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/Http1Exchange.java

2 lines changed: 1 ins; 0 del; 1 mod; 710 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java

3 lines changed: 1 ins; 0 del; 2 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java

8 lines changed: 6 ins; 0 del; 2 mod; 1457 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/HttpClientBuilderImpl.java

10 lines changed: 10 ins; 0 del; 0 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/HttpClientFacade.java

6 lines changed: 6 ins; 0 del; 0 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java

13 lines changed: 13 ins; 0 del; 0 mod; 1343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java

8 lines changed: 6 ins; 0 del; 2 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java

28 lines changed: 10 ins; 1 del; 17 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/PlainHttpConnection.java

69 lines changed: 65 ins; 2 del; 2 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/PlainTunnelingConnection.java

33 lines changed: 27 ins; 2 del; 4 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/TimeoutEvent.java

4 lines changed: 3 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/httpclient/HttpClientBuilderTest.java

24 lines changed: 24 ins; 0 del; 0 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/httpclient/TimeoutBasic.java

1 line changed: 1 ins; 0 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/httpclient/examples/JavadocExamples.java

2 lines changed: 1 ins; 0 del; 1 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/httpclient/offline/DelegatingHttpClient.java

6 lines changed: 6 ins; 0 del; 0 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/ConnectionPoolTest.java

4 lines changed: 3 ins; 0 del; 1 mod; 324 unchg

------ ------ ------ ------ --- New Patch Raw src/java.net.http/share/classes/java/net/http/HttpConnectTimeoutException.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/ResponseTimerEvent.java

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/AbstractConnectTimeout.java

257 lines changed: 257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/AbstractConnectTimeoutHandshake.java

288 lines changed: 288 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/ConnectTimeoutHandshakeAsync.java

46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/ConnectTimeoutHandshakeSync.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/ConnectTimeoutNoProxyAsync.java

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/ConnectTimeoutNoProxySync.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/ConnectTimeoutWithProxyAsync.java

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/httpclient/ConnectTimeoutWithProxySync.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/chris/tools/webrev (vers 25.16-hg+openjdk.java.net).