Code Review for open

Prepared by:chegar on Mon May 27 11:34:03 IST 2019
Workspace:/home/chhegar/repos/jdk/jdk/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Summary of changes: 1506 lines changed: 1208 ins; 275 del; 23 mod; 8791 unchg
Patch of changes: open.patch
Bug id: <title>OpenJDK Log In</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java

142 lines changed: 121 ins; 20 del; 1 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java

141 lines changed: 120 ins; 20 del; 1 mod; 732 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/DatagramSocket.java

8 lines changed: 7 ins; 0 del; 1 mod; 1405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/DatagramSocketImpl.java

98 lines changed: 16 ins; 74 del; 8 mod; 305 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/ServerSocket.java

6 lines changed: 6 ins; 0 del; 0 mod; 1109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/Socket.java

7 lines changed: 7 ins; 0 del; 0 mod; 1848 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketImpl.java

101 lines changed: 16 ins; 76 del; 9 mod; 415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

3 lines changed: 3 ins; 0 del; 0 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java

2 lines changed: 2 ins; 0 del; 0 mod; 1348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java

40 lines changed: 0 ins; 40 del; 0 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainSocketImpl.java

45 lines changed: 0 ins; 45 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/SocketOption/OptionsTest.java

11 lines changed: 8 ins; 0 del; 3 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/SocketOption/UnsupportedOptionsTest.java

7 lines changed: 7 ins; 0 del; 0 mod; 164 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/DatagramSocketImpl/TestImplSpec.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/SocketImpl/TestImplSpec.java

111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/SocketOption/AfterClose.java

384 lines changed: 384 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/SocketOption/NullsAndBadValues.java

287 lines changed: 287 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/chhegar/tools/webrev (vers 25.16-hg+openjdk.java.net).