Code Review for jdk

Prepared by:chegar on Thu Oct 11 17:33:05 BST 2012
Workspace:/export2/Users/chris/repos/jigsaw/constraints/jdk
Compare against: /export2/Users/chris/repos/jigsaw/master/jdk
Summary of changes: 958 lines changed: 626 ins; 48 del; 284 mod; 9708 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

------ ------ ------ ------ --- New Patch Raw src/share/classes/org/openjdk/jigsaw/ModuleArchitecture.java

119 lines changed: 119 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/Library.java

5 lines changed: 5 ins; 0 del; 0 mod; 424 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/ModuleFile.java

104 lines changed: 80 ins; 2 del; 22 mod; 874 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/ModuleFileParserDelegate.java

2 lines changed: 0 ins; 0 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/ModuleFileWriter.java

123 lines changed: 42 ins; 46 del; 35 mod; 453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/PublishedRepository.java

45 lines changed: 2 ins; 0 del; 43 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/RemoteRepository.java

39 lines changed: 23 ins; 0 del; 16 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/Repository.java

38 lines changed: 13 ins; 0 del; 25 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/RepositoryCatalog.java

35 lines changed: 23 ins; 0 del; 12 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/Resolver.java

51 lines changed: 1 ins; 0 del; 50 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java

73 lines changed: 52 ins; 0 del; 21 mod; 2249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/cli/Librarian.java

40 lines changed: 19 ins; 0 del; 21 mod; 700 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/cli/Packager.java

30 lines changed: 15 ins; 0 del; 15 mod; 883 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/org/openjdk/jigsaw/cli/Signer.java

5 lines changed: 4 ins; 0 del; 1 mod; 457 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/BuildNativePackages.gmk

8 lines changed: 7 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/Defs-modules.gmk

8 lines changed: 7 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/java/java/FILES_java.gmk

1 line changed: 1 ins; 0 del; 0 mod; 579 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/org/openjdk/jigsaw/MockLibrary.java

4 lines changed: 4 ins; 0 del; 0 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/org/openjdk/jigsaw/_PublishedRepository.java

9 lines changed: 0 ins; 0 del; 9 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/org/openjdk/jigsaw/_RepositoryCatalog.java

3 lines changed: 1 ins; 0 del; 2 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/org/openjdk/jigsaw/cli/ModuleFormatHeaderHashTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/org/openjdk/jigsaw/cli/signed-module.sh

17 lines changed: 16 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/org/openjdk/jigsaw/hello-repo.sh

63 lines changed: 57 ins; 0 del; 6 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/org/openjdk/jigsaw/install-files.sh

25 lines changed: 25 ins; 0 del; 0 mod; 48 unchg

------ ------ ------ ------ --- New Patch Raw test/org/openjdk/jigsaw/ModuleArchitectureTest.java

109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/jdk/bin/webrev (vers 23.17-hg).