Code Review for rt

Prepared by:Chien Yang on Fri Jun 3 22:22:35 PDT 2016
Workspace:/media/ckyang/5a62c0ca-7b99-47b4-a57e-80018a24ef60/ckyang/java/javafx/900/jfx/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/9-dev/rt
Compare against version:9830
Summary of changes: 338 lines changed: 202 ins; 73 del; 63 mod; 35047 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java

2 lines changed: 1 ins; 0 del; 1 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/com/sun/javafx/scene/control/ControlHelper.java

6 lines changed: 6 ins; 0 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/Control.java

10 lines changed: 4 ins; 4 del; 2 mod; 941 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/DatePicker.java

1 line changed: 1 ins; 0 del; 0 mod; 509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/Separator.java

4 lines changed: 0 ins; 3 del; 1 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/Slider.java

5 lines changed: 0 ins; 3 del; 2 mod; 837 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/Tab.java

10 lines changed: 0 ins; 7 del; 3 mod; 888 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/TableColumnBase.java

22 lines changed: 12 ins; 5 del; 5 mod; 800 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/TableUtil.java

4 lines changed: 0 ins; 0 del; 4 mod; 460 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/TextArea.java

6 lines changed: 0 ins; 4 del; 2 mod; 689 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/TreeTableView.java

1 line changed: 1 ins; 0 del; 0 mod; 3596 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java

2 lines changed: 1 ins; 0 del; 1 mod; 1060 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/TableSkinUtils.java

3 lines changed: 1 ins; 0 del; 2 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/module-info/module-info.java

2 lines changed: 2 ins; 0 del; 0 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/TableViewTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 5375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/TextAreaTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 488 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 6184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxml/src/main/java/com/sun/javafx/fxml/ParseTraceElement.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxml/src/main/java/javafx/fxml/FXMLLoader.java

33 lines changed: 8 ins; 15 del; 10 mod; 3499 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxml/src/test/addExports

1 line changed: 1 ins; 0 del; 0 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxml/src/test/java/test/javafx/fxml/FXMLLoader_ScriptTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxml/src/test/java/test/javafx/fxml/RT_18218Test.java

2 lines changed: 1 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/media/src/main/java/javafx/scene/media/MediaPlayer.java

5 lines changed: 0 ins; 3 del; 2 mod; 2852 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/media/src/main/java/javafx/scene/media/MediaView.java

14 lines changed: 0 ins; 11 del; 3 mod; 1055 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/media/src/main/java/javafx/scene/media/NGMediaView.java

2 lines changed: 0 ins; 0 del; 2 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/android/java/javafx/scene/web/WebEngine.java

6 lines changed: 0 ins; 5 del; 1 mod; 1342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/ios/java/javafx/scene/web/WebEngine.java

2 lines changed: 0 ins; 1 del; 1 mod; 983 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/javafx/scene/web/HTMLEditor.java

3 lines changed: 1 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/javafx/scene/web/WebEngine.java

14 lines changed: 0 ins; 12 del; 2 mod; 1595 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/test/java/javafx/scene/web/WebEngineShim.java

5 lines changed: 4 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/test/java/test/javafx/scene/web/DebuggerTest.java

9 lines changed: 1 ins; 0 del; 8 mod; 157 unchg

------ ------ ------ ------ --- New Patch Raw modules/controls/src/main/java/com/sun/javafx/scene/control/TableColumnBaseHelper.java

62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/controls/src/test/java/javafx/scene/control/TextAreaShim.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxml/src/main/java/com/sun/javafx/fxml/FXMLLoaderHelper.java

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ckyang/bin/webrev (vers 25.16-hg+openjdk.java.net).