Code Review for rt

Prepared by:Chien Yang on Wed May 18 21:44:55 PDT 2016
Workspace:/media/ckyang/5a62c0ca-7b99-47b4-a57e-80018a24ef60/ckyang/java/javafx/900/jfx/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/9-dev/rt
Summary of changes: 1070 lines changed: 246 ins; 75 del; 749 mod; 40365 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/addExports

1 line changed: 1 ins; 0 del; 0 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/MenuBarTest.java

14 lines changed: 1 ins; 0 del; 13 mod; 414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/PaginationTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 315 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/TabPaneTest.java

5 lines changed: 1 ins; 0 del; 4 mod; 1028 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/TitledPaneTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/test/java/test/javafx/scene/control/skin/ColorPickerSkinTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxml/src/test/addExports

1 line changed: 1 ins; 0 del; 0 mod; 13 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/font/PrismFontLoader.java

1 line changed: 0 ins; 0 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/SceneHelper.java

76 lines changed: 66 ins; 8 del; 2 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/FontMetrics.java

2 lines changed: 0 ins; 0 del; 2 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/Toolkit.java

2 lines changed: 0 ins; 0 del; 2 mod; 973 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/animation/shared/InterpolationInterval.java

4 lines changed: 1 ins; 0 del; 3 mod; 550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/KeyValue.java

25 lines changed: 2 ins; 7 del; 16 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/Node.java

4 lines changed: 0 ins; 0 del; 4 mod; 9799 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/Scene.java

133 lines changed: 50 ins; 59 del; 24 mod; 6411 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/stage/Window.java

10 lines changed: 1 ins; 0 del; 9 mod; 1559 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/addExports

2 lines changed: 1 ins; 1 del; 0 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/pgstub/StubToolkit.java

2 lines changed: 1 ins; 0 del; 1 mod; 926 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/sg/prism/ContentBoundsTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/sg/prism/EffectDirtyRegionTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/test/objects/TestScene.java

3 lines changed: 1 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/KeyValueTest.java

19 lines changed: 2 ins; 0 del; 17 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/AcceleratorsTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/FocusTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 733 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/Mouse3DTest.java

164 lines changed: 1 ins; 0 del; 163 mod; 2618 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/MouseTest.java

6 lines changed: 1 ins; 0 del; 5 mod; 1815 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/SceneTest.java

8 lines changed: 1 ins; 0 del; 7 mod; 966 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/ContextMenuEventTest.java

6 lines changed: 1 ins; 0 del; 5 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/DragAndDropTest.java

68 lines changed: 1 ins; 0 del; 67 mod; 1698 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/MouseDragEventTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 977 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/RotateEventTest.java

35 lines changed: 1 ins; 0 del; 34 mod; 625 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/ScrollEventTest.java

48 lines changed: 1 ins; 0 del; 47 mod; 789 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/SwipeEventTest.java

18 lines changed: 1 ins; 0 del; 17 mod; 411 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/TouchEventTest.java

235 lines changed: 1 ins; 0 del; 234 mod; 1523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/input/ZoomEventTest.java

35 lines changed: 1 ins; 0 del; 34 mod; 626 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/stage/PopupTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 741 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jmx/src/main/java/com/oracle/javafx/jmx/SGMXBeanImpl.java

6 lines changed: 1 ins; 0 del; 5 mod; 531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/com/sun/javafx/webkit/InputMethodClientImpl.java

3 lines changed: 1 ins; 0 del; 2 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/com/sun/javafx/webkit/prism/theme/PrismRenderer.java

4 lines changed: 1 ins; 0 del; 3 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/javafx/scene/web/WebView.java

3 lines changed: 1 ins; 0 del; 2 mod; 1323 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/animation/KeyValueHelper.java

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/animation/KeyValueType.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ckyang/bin/webrev (vers 23.18-hg).