Code Review for rt

Prepared by:ckyang on Mon Aug 8 12:11:16 PDT 2016
Workspace:/Users/ckyang/java/javafx/900/jfx/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/9-dev/rt
Summary of changes: 283 lines changed: 103 ins; 8 del; 172 mod; 62703 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/DefaultProperty.java

1 line changed: 1 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java

20 lines changed: 4 ins; 0 del; 16 mod; 7985 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/DoubleBinding.java

1 line changed: 0 ins; 0 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/DoubleExpression.java

1 line changed: 1 ins; 0 del; 0 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/FloatExpression.java

1 line changed: 1 ins; 0 del; 0 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/IntegerExpression.java

1 line changed: 1 ins; 0 del; 0 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/ListExpression.java

4 lines changed: 4 ins; 0 del; 0 mod; 393 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/LongExpression.java

1 line changed: 1 ins; 0 del; 0 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/MapExpression.java

4 lines changed: 4 ins; 0 del; 0 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/NumberExpression.java

1 line changed: 1 ins; 0 del; 0 mod; 871 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/NumberExpressionBase.java

1 line changed: 1 ins; 0 del; 0 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/ObjectExpression.java

2 lines changed: 2 ins; 0 del; 0 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/SetExpression.java

3 lines changed: 3 ins; 0 del; 0 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/binding/When.java

2 lines changed: 2 ins; 0 del; 0 mod; 887 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/DoubleProperty.java

1 line changed: 0 ins; 0 del; 1 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/FloatProperty.java

1 line changed: 0 ins; 0 del; 1 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/IntegerProperty.java

1 line changed: 0 ins; 0 del; 1 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/LongProperty.java

1 line changed: 0 ins; 0 del; 1 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/ObjectProperty.java

3 lines changed: 3 ins; 0 del; 0 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyDoubleProperty.java

1 line changed: 1 ins; 0 del; 0 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyFloatProperty.java

1 line changed: 1 ins; 0 del; 0 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyIntegerProperty.java

1 line changed: 1 ins; 0 del; 0 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyLongProperty.java

1 line changed: 1 ins; 0 del; 0 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/StringProperty.java

1 line changed: 1 ins; 0 del; 0 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanObjectPropertyBuilder.java

1 line changed: 1 ins; 0 del; 0 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/beans/value/ObservableNumberValue.java

3 lines changed: 0 ins; 3 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/ArrayChangeListener.java

1 line changed: 1 ins; 0 del; 0 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/FXCollections.java

38 lines changed: 34 ins; 0 del; 4 mod; 2792 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/ListChangeListener.java

4 lines changed: 0 ins; 0 del; 4 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/ModifiableObservableListBase.java

12 lines changed: 6 ins; 0 del; 6 mod; 404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/ObservableArray.java

1 line changed: 0 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/ObservableArrayBase.java

3 lines changed: 2 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/ObservableIntegerArray.java

1 line changed: 0 ins; 0 del; 1 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/ObservableListBase.java

2 lines changed: 1 ins; 0 del; 1 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/collections/transformation/TransformationList.java

1 line changed: 0 ins; 0 del; 1 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/Builder.java

2 lines changed: 2 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/BuilderFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/Duration.java

4 lines changed: 0 ins; 0 del; 4 mod; 433 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/StringConverter.java

2 lines changed: 2 ins; 0 del; 0 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java

3 lines changed: 3 ins; 0 del; 0 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/converter/FormatStringConverter.java

2 lines changed: 2 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/converter/LocalDateStringConverter.java

1 line changed: 0 ins; 0 del; 1 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/converter/LocalDateTimeStringConverter.java

1 line changed: 0 ins; 0 del; 1 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/converter/LocalTimeStringConverter.java

1 line changed: 0 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/javafx/util/converter/NumberStringConverter.java

3 lines changed: 3 ins; 0 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/chart/ValueAxis.java

1 line changed: 0 ins; 0 del; 1 mod; 596 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/Cell.java

1 line changed: 0 ins; 0 del; 1 mod; 771 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/DialogEvent.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/FocusModel.java

1 line changed: 0 ins; 0 del; 1 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModel.java

1 line changed: 0 ins; 0 del; 1 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java

1 line changed: 0 ins; 0 del; 1 mod; 3330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TreeItem.java

2 lines changed: 0 ins; 0 del; 2 mod; 1187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java

1 line changed: 0 ins; 0 del; 1 mod; 3603 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/cell/TextFieldTreeTableCell.java

2 lines changed: 0 ins; 0 del; 2 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java

2 lines changed: 0 ins; 0 del; 2 mod; 3515 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.fxml/src/main/java/javafx/fxml/LoadListener.java

1 line changed: 0 ins; 1 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/application/Application.java

1 line changed: 0 ins; 0 del; 1 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/concurrent/Service.java

5 lines changed: 1 ins; 1 del; 3 mod; 917 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/concurrent/Task.java

11 lines changed: 2 ins; 0 del; 9 mod; 1461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/Match.java

1 line changed: 0 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/StyleConverter.java

6 lines changed: 4 ins; 0 del; 2 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/Styleable.java

1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/converter/InsetsConverter.java

4 lines changed: 2 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/converter/PaintConverter.java

1 line changed: 0 ins; 0 del; 1 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/converter/URLConverter.java

3 lines changed: 2 ins; 0 del; 1 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/geometry/Orientation.java

2 lines changed: 0 ins; 0 del; 2 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/Node.java

3 lines changed: 0 ins; 0 del; 3 mod; 9907 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/effect/DisplacementMap.java

4 lines changed: 1 ins; 0 del; 3 mod; 514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java

1 line changed: 0 ins; 0 del; 1 mod; 1240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/image/PixelFormat.java

33 lines changed: 0 ins; 0 del; 33 mod; 404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/image/PixelWriter.java

2 lines changed: 0 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/input/DragEvent.java

3 lines changed: 0 ins; 0 del; 3 mod; 778 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java

2 lines changed: 0 ins; 0 del; 2 mod; 945 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/input/RotateEvent.java

3 lines changed: 0 ins; 0 del; 3 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/input/ScrollEvent.java

3 lines changed: 0 ins; 0 del; 3 mod; 599 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/input/SwipeEvent.java

3 lines changed: 0 ins; 0 del; 3 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/input/TouchEvent.java

4 lines changed: 0 ins; 1 del; 3 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/input/ZoomEvent.java

5 lines changed: 0 ins; 2 del; 3 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/layout/ColumnConstraints.java

1 line changed: 0 ins; 0 del; 1 mod; 416 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/layout/FlowPane.java

6 lines changed: 0 ins; 0 del; 6 mod; 958 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/layout/RowConstraints.java

1 line changed: 0 ins; 0 del; 1 mod; 412 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/layout/TilePane.java

7 lines changed: 0 ins; 0 del; 7 mod; 1243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/paint/Color.java

7 lines changed: 0 ins; 0 del; 7 mod; 1972 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/paint/ImagePattern.java

3 lines changed: 0 ins; 0 del; 3 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/java/javafx/scene/media/MediaPlayer.java

1 line changed: 0 ins; 0 del; 1 mod; 2853 unchg

This code review page was prepared using /Users/ckyang/bin/webrev (vers 25.16-hg+openjdk.java.net).