--- old/modules/javafx.controls/src/main/java/javafx/scene/control/Dialog.java 2017-03-09 14:44:19.054173581 -0800 +++ new/modules/javafx.controls/src/main/java/javafx/scene/control/Dialog.java 2017-03-09 14:44:18.950173579 -0800 @@ -521,6 +521,7 @@ WeakReference dialogPaneRef = new WeakReference<>(null); + @Override protected void invalidated() { DialogPane oldDialogPane = dialogPaneRef.get(); if (oldDialogPane != null) { @@ -574,6 +575,7 @@ * is lower precedence than the {@link DialogPane#contentProperty() content node}, meaning * that if both the content node and the contentText properties are set, the * content text will not be displayed in a default DialogPane instance. + * @return the property representing the content text for the dialog pane */ public final StringProperty contentTextProperty() { return getDialogPane().contentTextProperty(); @@ -581,6 +583,7 @@ /** * Returns the currently-set content text for this DialogPane. + * @return the currently-set content text for this DialogPane */ public final String getContentText() { return getDialogPane().getContentText(); @@ -591,6 +594,7 @@ * is lower precedence than the {@link DialogPane#contentProperty() content node}, meaning * that if both the content node and the contentText properties are set, the * content text will not be displayed in a default DialogPane instance. + * @param contentText the string to show in the dialog content area */ public final void setContentText(String contentText) { getDialogPane().setContentText(contentText); @@ -603,6 +607,7 @@ * is lower precedence than the {@link DialogPane#headerProperty() header node}, meaning * that if both the header node and the headerText properties are set, the * header text will not be displayed in a default DialogPane instance. + * @return a property representing the header text for the dialog pane */ public final StringProperty headerTextProperty() { return getDialogPane().headerTextProperty(); @@ -610,6 +615,7 @@ /** * Returns the currently-set header text for this DialogPane. + * @return the currently-set header text for this DialogPane */ public final String getHeaderText() { return getDialogPane().getHeaderText(); @@ -620,6 +626,7 @@ * is lower precedence than the {@link DialogPane#headerProperty() header node}, meaning * that if both the header node and the headerText properties are set, the * header text will not be displayed in a default DialogPane instance. + * @param headerText the string to show in the dialog header area */ public final void setHeaderText(String headerText) { getDialogPane().setHeaderText(headerText); @@ -666,6 +673,7 @@ * which is intended to convert from the {@link ButtonType} that the user * clicked on into a value of type R. Refer to the {@link Dialog} class * JavaDoc for more details. + * @return a property representing what has been returned from the dialog */ public final ObjectProperty resultProperty() { return resultProperty; @@ -694,6 +702,7 @@ * subclass is ButtonType (which means that the result converter can be null), * but in some cases (where the result type, R, is not ButtonType or Void), * this callback must be specified. + * @return the API to convert the {@link ButtonType} that the user clicked on */ public final ObjectProperty> resultConverterProperty() { return resultConverterProperty; @@ -711,6 +720,7 @@ // --- showing /** * Represents whether the dialog is currently showing. + * @return the property representing whether the dialog is currently showing */ public final ReadOnlyBooleanProperty showingProperty() { return dialog.showingProperty(); @@ -729,6 +739,7 @@ // --- resizable /** * Represents whether the dialog is resizable. + * @return the property representing whether the dialog is resizable */ public final BooleanProperty resizableProperty() { return dialog.resizableProperty(); @@ -758,6 +769,7 @@ // --- width /** * Property representing the width of the dialog. + * @return the property representing the width of the dialog */ public final ReadOnlyDoubleProperty widthProperty() { return dialog.widthProperty(); @@ -765,6 +777,7 @@ /** * Returns the width of the dialog. + * @return the width of the dialog */ public final double getWidth() { return widthProperty().get(); @@ -772,6 +785,7 @@ /** * Sets the width of the dialog. + * @param width the width of the dialog */ public final void setWidth(double width) { dialog.setWidth(width); @@ -781,6 +795,7 @@ // --- height /** * Property representing the height of the dialog. + * @return the property representing the height of the dialog */ public final ReadOnlyDoubleProperty heightProperty() { return dialog.heightProperty(); @@ -788,6 +803,7 @@ /** * Returns the height of the dialog. + * @return the height of the dialog */ public final double getHeight() { return heightProperty().get(); @@ -795,6 +811,7 @@ /** * Sets the height of the dialog. + * @param height the height of the dialog */ public final void setHeight(double height) { dialog.setHeight(height); @@ -804,6 +821,7 @@ // --- title /** * Return the titleProperty of the dialog. + * @return the titleProperty of the dialog */ public final StringProperty titleProperty(){ return this.dialog.titleProperty(); @@ -811,13 +829,14 @@ /** * Return the title of the dialog. + * @return the title of the dialog */ public final String getTitle(){ return this.dialog.titleProperty().get(); } /** * Change the Title of the dialog. - * @param title + * @param title the Title of the dialog */ public final void setTitle(String title){ this.dialog.titleProperty().set(title); @@ -836,6 +855,7 @@ /** * The horizontal location of this {@code Dialog}. Changing this attribute * will move the {@code Dialog} horizontally. + * @return the horizontal location of this {@code Dialog} */ public final ReadOnlyDoubleProperty xProperty() { return dialog.xProperty(); @@ -853,6 +873,7 @@ /** * The vertical location of this {@code Dialog}. Changing this attribute * will move the {@code Dialog} vertically. + * @return the vertical location of this {@code Dialog} */ public final ReadOnlyDoubleProperty yProperty() { return dialog.yProperty();