# HG changeset patch # User mbaesken # Date 1538480888 -7200 # Tue Oct 02 13:48:08 2018 +0200 # Node ID fafafca11a333d2f02c4971270186b65022bc3cd # Parent dea84489c35ef79790e95e1e8dec907166276194 8211106: [windows] Update OS detection code to recognize Windows Server 2019 Reviewed-by: alanb, clanger, bobv diff --git a/src/windows/native/java/lang/java_props_md.c b/src/windows/native/java/lang/java_props_md.c --- a/src/windows/native/java/lang/java_props_md.c +++ b/src/windows/native/java/lang/java_props_md.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -351,6 +351,7 @@ static java_props_t sprops = {0}; int majorVersion; int minorVersion; + int buildNumber = 0; if (sprops.line_separator) { return &sprops; @@ -390,6 +391,8 @@ GetVersionEx((OSVERSIONINFO *) &ver); majorVersion = ver.dwMajorVersion; minorVersion = ver.dwMinorVersion; + /* distinguish Windows Server 2016 and 2019 by build number */ + buildNumber = ver.dwBuildNumber; is_workstation = (ver.wProductType == VER_NT_WORKSTATION); platformId = ver.dwPlatformId; sprops.patch_level = _strdup(ver.szCSDVersion); @@ -440,6 +443,7 @@ } majorVersion = HIWORD(file_info->dwProductVersionMS); minorVersion = LOWORD(file_info->dwProductVersionMS); + buildNumber = HIWORD(file_info->dwProductVersionLS); free(version_info); } while (0); @@ -470,6 +474,8 @@ * Windows Server 2012 R2 6 3 (!VER_NT_WORKSTATION) * Windows 10 10 0 (VER_NT_WORKSTATION) * Windows Server 2016 10 0 (!VER_NT_WORKSTATION) + * Windows Server 2019 10 0 (!VER_NT_WORKSTATION) + * where (buildNumber > 17762) * * This mapping will presumably be augmented as new Windows * versions are released. @@ -543,7 +549,14 @@ } } else { switch (minorVersion) { - case 0: sprops.os_name = "Windows Server 2016"; break; + case 0: + /* Windows server 2019 GA 10/2018 build number is 17763 */ + if (buildNumber > 17762) { + sprops.os_name = "Windows Server 2019"; + } else { + sprops.os_name = "Windows Server 2016"; + } + break; default: sprops.os_name = "Windows NT (unknown)"; } }