< prev index next >

src/java.base/share/classes/java/text/DecimalFormat.java

Print this page
rev 51919 : 8215281: Use String.isEmpty() when applicable in java.base
Reviewed-by: dfuchs, alanb

@@ -1070,15 +1070,13 @@
             fastPathData.fractionalScaleFactor = (isCurrencyFormat)
                     ? 100.0d : 1000.0d;
 
             // Records the need for adding prefix or suffix
             fastPathData.positiveAffixesRequired
-                    = (positivePrefix.length() != 0)
-                        || (positiveSuffix.length() != 0);
+                    = !positivePrefix.isEmpty() || !positiveSuffix.isEmpty();
             fastPathData.negativeAffixesRequired
-                    = (negativePrefix.length() != 0)
-                        || (negativeSuffix.length() != 0);
+                    = !negativePrefix.isEmpty() || !negativeSuffix.isEmpty();
 
             // Creates a cached char container for result, with max possible size.
             int maxNbIntegralDigits = 10;
             int maxNbGroups = 3;
             int containerSize

@@ -1988,11 +1986,11 @@
                         FieldDelegate delegate,
                         FieldPosition[] positions,
                         Format.Field signAttribute) {
         int start = result.length();
 
-        if (string.length() > 0) {
+        if (!string.isEmpty()) {
             result.append(string);
             for (int counter = 0, max = positions.length; counter < max;
                  counter++) {
                 FieldPosition fp = positions[counter];
                 Format.Field attribute = fp.getFieldAttribute();

@@ -2943,11 +2941,11 @@
                         ++i;
                         string = symbols.getInternationalCurrencySymbol();
                     } else {
                         string = symbols.getCurrencySymbol();
                     }
-                    if (string.length() > 0) {
+                    if (!string.isEmpty()) {
                         if (positions == null) {
                             positions = new ArrayList<>(2);
                         }
                         FieldPosition fp = new FieldPosition(Field.CURRENCY);
                         fp.setBeginIndex(stringIndex);

@@ -3514,11 +3512,11 @@
                 negSuffixPattern = suffix.toString();
                 gotNegative = true;
             }
         }
 
-        if (pattern.length() == 0) {
+        if (pattern.isEmpty()) {
             posPrefixPattern = posSuffixPattern = "";
             setMinimumIntegerDigits(0);
             setMaximumIntegerDigits(MAXIMUM_INTEGER_DIGITS);
             setMinimumFractionDigits(0);
             setMaximumFractionDigits(MAXIMUM_FRACTION_DIGITS);
< prev index next >